From: "Qiu, Michael" <michael.qiu@intel.com> To: Yerden Zhumabekov <e_zhumabekov@sts.kz>, "dev@dpdk.org" <dev@dpdk.org> Subject: Re: [dpdk-dev] [PATCH 1/3] librte_hash: Fix unsupported instruction `crc32' in i686 platform Date: Thu, 5 Mar 2015 16:34:52 +0000 Message-ID: <533710CFB86FA344BFBF2D6802E60286CEF2C5@SHSMSX101.ccr.corp.intel.com> (raw) In-Reply-To: <54F87FEE.8090408@sts.kz> On 2015/3/6 0:12, Yerden Zhumabekov wrote: > Hi Michael, > > Thanks for this patch, in fact I didn't try to compile it on i686 when > developing original software fallback for CRC32. > > I think if we want to make code compilable as wide as possible, we > should compile out all SSE4.2 instructions. As to the patch, we may > compile out 'crc32l' instruction emitting code if the arch is not x86. > This concerns two functions: crc32c_sse42_u32() and > crc32c_sse42_u64_mimic(). OK, I will add the check for crc32l, make it only works for x86 Thanks, Michael > The compile check might be something like this: > > #if defined(RTE_ARCH_I686) || defined(RTE_ARCH_X86_64) > #endif > > Otherwise, the patch looks good. > > 05.03.2015 19:15, Michael Qiu пишет: >> CC rte_hash.o >> Error: unsupported instruction `crc32' >> >> The root cause is that i686 platform does not support 'crc32q' >> Need make it only available in x86_64 platform >> >> Signed-off-by: Michael Qiu <michael.qiu@intel.com> >> --- >> lib/librte_hash/rte_hash_crc.h | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/lib/librte_hash/rte_hash_crc.h b/lib/librte_hash/rte_hash_crc.h >> index d28bb2a..4e9546f 100644 >> --- a/lib/librte_hash/rte_hash_crc.h >> +++ b/lib/librte_hash/rte_hash_crc.h >> @@ -374,6 +374,7 @@ crc32c_sse42_u32(uint32_t data, uint32_t init_val) >> return init_val; >> } >> >> +#ifdef RTE_ARCH_X86_64 >> static inline uint32_t >> crc32c_sse42_u64(uint64_t data, uint64_t init_val) >> { >> @@ -383,6 +384,7 @@ crc32c_sse42_u64(uint64_t data, uint64_t init_val) >> : [data] "rm" (data)); >> return init_val; >> } >> +#endif >> >> static inline uint32_t >> crc32c_sse42_u64_mimic(uint64_t data, uint64_t init_val) >> @@ -476,8 +478,10 @@ rte_hash_crc_4byte(uint32_t data, uint32_t init_val) >> static inline uint32_t >> rte_hash_crc_8byte(uint64_t data, uint32_t init_val) >> { >> +#ifdef RTE_ARCH_X86_64 >> if (likely(crc32_alg == CRC32_SSE42_x64)) >> return crc32c_sse42_u64(data, init_val); >> +#endif >> >> if (likely(crc32_alg & CRC32_SSE42)) >> return crc32c_sse42_u64_mimic(data, init_val);
next prev parent reply other threads:[~2015-03-05 16:35 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-03-05 13:15 [dpdk-dev] [PATCH 0/3] dpdk2.0-rc1 build error fix Michael Qiu 2015-03-05 13:15 ` [dpdk-dev] [PATCH 1/3] librte_hash: Fix unsupported instruction `crc32' in i686 platform Michael Qiu 2015-03-05 16:10 ` Yerden Zhumabekov 2015-03-05 16:34 ` Qiu, Michael [this message] 2015-03-05 16:55 ` [dpdk-dev] [PATCH 1/3 v2] " Michael Qiu 2015-03-05 17:02 ` Yerden Zhumabekov 2015-03-05 17:10 ` Thomas Monjalon 2015-03-06 1:39 ` Qiu, Michael 2015-03-07 18:39 ` Thomas Monjalon 2015-03-10 3:55 ` Yerden Zhumabekov 2015-03-19 2:00 ` Qiu, Michael 2015-03-19 8:10 ` Thomas Monjalon 2015-03-09 5:58 ` [dpdk-dev] [PATCH 1/3 v3] " Michael Qiu 2015-03-18 13:20 ` Liu, Yong 2015-03-18 14:59 ` Qiu, Michael 2015-03-05 13:15 ` [dpdk-dev] [PATCH 2/3] app/test: Fix size_t printf formart issue Michael Qiu 2015-03-05 13:22 ` Bruce Richardson 2015-03-05 14:00 ` [dpdk-dev] [PATCH 2/3 v2] app/test: Fix size_t printf format issue Michael Qiu 2015-03-05 17:27 ` Thomas Monjalon 2015-03-06 1:42 ` Qiu, Michael 2015-03-06 3:53 ` [dpdk-dev] [PATCH 2/3 v3] " Michael Qiu 2015-03-05 13:15 ` [dpdk-dev] [PATCH 3/3] librte_eal/common: Fix redeclaration of enumerator ‘REG_EAX’ Michael Qiu 2015-03-05 13:23 ` Bruce Richardson 2015-03-05 13:36 ` David Marchand 2015-03-05 13:54 ` Qiu, Michael 2015-03-05 13:41 ` Qiu, Michael 2015-03-05 13:23 ` Qiu, Michael 2015-03-05 13:50 ` [dpdk-dev] [PATCH 3/3 v2] =?UTF-8?q?librte=5Feal/common:=20Fix=20redeclaration=20of?= =?UTF-8?q?=20enumerator=20=E2=80=98REG=5FEAX=E2=80=99?= Michael Qiu 2015-03-05 13:54 ` [dpdk-dev] [PATCH 3/3 v2] librte_eal/common: Fix redeclaration of enumerator ‘REG_EAX’ David Marchand 2015-03-05 14:03 ` Qiu, Michael 2015-03-05 14:38 ` Thomas Monjalon 2015-03-05 16:31 ` Qiu, Michael 2015-03-05 18:24 ` Thomas Monjalon 2015-03-05 13:57 ` [dpdk-dev] [PATCH 3/3 v3] =?UTF-8?q?librte=5Feal/common:=20Fix=20redeclaration=20of?= =?UTF-8?q?=20enumerator=20=E2=80=98REG=5FEAX=E2=80=99?= Michael Qiu 2015-03-06 6:28 ` [dpdk-dev] [PATCH 3/3 v3] librte_eal/common: Fix redeclaration of enumerator ‘REG_EAX’ David Marchand 2015-03-09 17:04 ` [dpdk-dev] [PATCH 0/3] dpdk2.0-rc1 build error fix Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=533710CFB86FA344BFBF2D6802E60286CEF2C5@SHSMSX101.ccr.corp.intel.com \ --to=michael.qiu@intel.com \ --cc=dev@dpdk.org \ --cc=e_zhumabekov@sts.kz \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git