From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 2DDED1B739 for ; Wed, 6 Jun 2018 21:00:44 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jun 2018 12:00:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,484,1520924400"; d="scan'208";a="55288527" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.42]) ([10.237.221.42]) by FMSMGA003.fm.intel.com with ESMTP; 06 Jun 2018 12:00:39 -0700 To: =?UTF-8?Q?Micha=c5=82_Krawczyk?= Cc: dev@dpdk.org, Marcin Wojtas , =?UTF-8?Q?Rafa=c5=82_Kozik?= , "Tzalik, Guy" , "Schmeilin, Evgeny" , Thomas Monjalon , "Matushevsky, Alexander" , Anatoly Burakov References: <20180604120918.16904-1-mk@semihalf.com> <30ba546f-b7b7-cb74-6ae4-3387250a7936@intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= xsFNBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABzSVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+wsF+BBMBAgAoAhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgAUCWZR3VQUJB33WBQAKCRD5M+tD3xNhH6DWEACVhEb8q1epPwZrUDoxzu7E TS1b8tmabOmnjXZRs6+EXgUVHkp2xxkCfDmL3pa5bC0G/74aJnWjNsdvE05V1cb4YK4kRQ62 FwDQ+hlrFrwFB3PtDZk1tpkzCRHvJgnIil+0MuEh32Y57ig6hy8yO8ql7Lohyrnpfk/nNpm4 jQGEF5qEeHcEFe1AZQlPHN/STno8NZSz2nl0b2cw+cujN1krmvB52Ah/2KugQ6pprVyrGrzB c34ZQO9OsmSjJlETCZk6EZzuhfe16iqBFbOSadi9sPcJRwaUQBid+xdFWl7GQ8qC3zNPibSF HmU43yBZUqJDZlhIcl6/cFpOSjv2sDWdtjEXTDn5y/0FsuY0mFE78ItC4kCTIVk17VZoywcd fmbbnwOSWzDq7hiUYuQGkIudJw5k/A1CMsyLkoUEGN3sLfsw6KASgS4XrrmPO4UVr3mH5bP1 yC7i1OVNpzvOxtahmzm481ID8sk72GC2RktTOHb0cX+qdoiMMfYgo3wRRDYCBt6YoGYUxF1p msjocXyqToKhhnFbXLaZlVfnQ9i2i8jsj9SKig+ewC2p3lkPj6ncye9q95bzhmUeJO6sFhJg Hiz6syOMg8yCcq60j07airybAuHIDNFWk0gaWAmtHZxLObZx2PVn2nv9kLYGohFekw0AOsIW ta++5m48dnCoAc7BTQRX1ky+ARAApzQNvXvE2q1LAS+Z+ni2R13Bb1cDS1ZYq1jgpR13+OKN ipzd8MPngRJilXxBaPTErhgzR0vGcNTYhjGMSyFIHVOoBq1VbP1a0Fi/NqWzJOowo/fDfgVy K4vuitc/gCJs+2se4hdZA4EQJxVlNM51lgYDNpjPGIA43MX15OLAip73+ho6NPBMuc5qse3X pAClNhBKfENRCWN428pi3WVkT+ABRTE0taxjJNP7bb+9TQYNRqGwnGzX5/XISv44asWIQCaq vOkXSUJLd//cdVNTqtL1wreCVVR5pMXj7VIrlk07fmmJVALCmGbFr53BMb8O+8dgK2A5mitM n44d+8KdJWOwziRxcaMk/LclmZS3Iv1TERtiWt98Y9AjeAtcgYPkA3ld0BcUKONogP8pHVz1 Ed3s5rDQ91yr1S0wuAzW91fxGUO4wY+uPmxCtFVuBgd9VT9NAKTUL0qHM7CDgCnZPe0TW6Zj 8OqtdCCyAfvU9cW5xWM7Icxhde6AtPxhDSBwE8fL2ZmrDmaA4jmUKXp3i4JxRPSX84S08b+s DWXHPxy10UFU5A7EK/BEbZAKBwn9ROfm+WK+6X5xOGLoRE++OqNuUudxC1GDyLOPaqCbBCS9 +P6HsTHzxsjyJa27n4jcrcuY3P9TEcFJYSZSeSDh8mVGvugi0exnSJrrBZDyVCcAEQEAAcLB ZQQYAQIADwIbDAUCWZR1ZwUJA59cIQAKCRD5M+tD3xNhH5b+D/9XG44Ci6STdcA5RO/ur05J EE3Ux1DCHZ5V7vNAtX/8Wg4l4GZfweauXwuJ1w7Sp7fklwcNC6wsceI+EmNjGMqfIaukGetG +jBGqsQ7moOZodfXUoCK98gblKgt/BPYMVidzlGC8Q/+lZg1+o29sPnwImW+MXt/Z5az/Z17 Qc265g+p5cqJHzq6bpQdnF7Fu6btKU/kv6wJghENvgMXBuyThqsyFReJWFh2wfaKyuix3Zyj ccq7/blkhzIKmtFWgDcgaSc2UAuJU+x9nuYjihW6WobpKP/nlUDu3BIsbIq09UEke+uE/QK+ FJ8PTJkAsXOf1Bc2C0XbW4Y2hf103+YY6L8weUCBsWC5VH5VtVmeuh26ENURclwfeXhWQ9Og 77yzpTXWr5g1Z0oLpYpWPv745J4bE7pv+dzxOrFdM1xNkzY2pvXph/A8OjxZNQklDkHQ7PIB Lki5L2F4XkEOddUUQchJwzMqTPsggPDmGjgLZrqgO+s4ECZK5+nLD3HEpAbPa3JLDaScy+90 Nu1lAqPUHSnP3vYZVw85ZYm6UCxHE4VLMnnJsN09ZhsOSVR+GyP5Nyw9rT1V3lcsuH7M5Naa 2Xobn9m7l9bRCD/Ji8kG15eV1WTxx1HXVQGjdUYDI7UwegBNbwMLh17XDy+3sn/6SgcqtECA Q6pZKA2mTQxEKMLBZQQYAQIADwIbDAUCWZR3hQUJA59eRwAKCRD5M+tD3xNhH4a/D/4jLAZu UhvU1swWcNEVVCELZ0D3LOV14XcY2MXa3QOpeZ9Bgq7YYJ4S5YXK+SBQS0FkRZdjGNvlGZoG ZdpU+NsQmQFhqHGwX0IT9MeTFM8uvKgxNKGwMVcV9g0IOqwBhGHne+BFboRA9362fgGW5AYQ zT0mzzRKEoOh4r3AQvbM6kLISxo0k1ujdYiI5nj/5WoKDqxTwwfuN1uDUHsWo3tzenRmpMyU NyW3Dc+1ajvXLyo09sRRq7BnM99Rix1EGL8Qhwy+j0YAv+FuspWxUX9FxXYho5PvGLHLsHfK FYQ7x/RRbpMjkJWVfIe/xVnfvn4kz+MTA5yhvsuNi678fLwY9hBP0y4lO8Ob2IhEPdfnTuIs tFVxXuelJ9xAe5TyqP0f+fQjf1ixsBZkqOohsBXDfje0iaUpYa/OQ/BBeej0dUdg2JEu4jAC x41HpVCnP9ipLpD0fYz1d/dX0F/VY2ovW6Eba/y/ngOSAR6C+u881m7oH2l0G47MTwkaQCBA bLGXPj4TCdX3lftqt4bcBPBJ+rFAnJmRHtUuyyaewBnZ81ZU2YAptqFM1kTh+aSvMvGhfVsQ qZL2rk2OPN1hg+KXhErlbTZ6oPtLCFhSHQmuxQ4oc4U147wBTUuOdwNjtnNatUhRCp8POc+3 XphVR5G70mnca1E2vzC77z+XSlTyRA== Message-ID: <533f5d69-933f-0401-1391-062288f378b8@intel.com> Date: Wed, 6 Jun 2018 20:00:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 00/26] net/ena: new features and fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jun 2018 19:00:45 -0000 On 6/6/2018 12:46 PM, Michał Krawczyk wrote: > Hi Ferruh, > > 2018-06-05 18:42 GMT+02:00 Ferruh Yigit : >> >> On 6/4/2018 1:09 PM, Michal Krawczyk wrote: >>> The ENA driver was updated with the new features and few fixes and minor >>> changes are introduced. >>> First of all, the communication layer which is delivered by vendor was >>> updated - the version in the HEAD is a bit outdated now. ENA is able to >>> communicate with the driver through Admin queue by using admin interrupts >>> instead of polling. >>> Admin interrupts are also used for handling AENQ events, which are used for >>> the following new features: >>> - LSC handlers >>> - watchdog and device rest >>> - monitoring the admin queue >>> - handling ENA notifications (getting hints from device) >>> For the watchdog and admin queue monitoring, the timers had to be used, so >>> the makefile was modified to do not cut out the librte_timer. >>> >>> From other fixes and changes: >>> - legacy LLQ was removed which is now deprecated API >>> - Rx out of order completion was added to enable cleaning up packets out >>> of order >>> - Tx mbufs are now linearized if they exceed supported number of segments >>> - pass information about maximum number of Tx and Rx descriptors >>> - the IO queue number is now taking into consideration maximum number of >>> sq and cq >>> - Tx id requested for sending is now being validated and the reset is >>> being triggered if it is invalid >>> - branch predictioning was added for better performance >>> - error checking and returned values were fixed >>> - macros for allocating memory in communication layer were fixed >>> - information about numa mode is now being passed to the NIC >>> >>> --- >>> v2: >>> * Rebased on top of dpdk-next-net >>> * Added link speed patch >>> * Added fix when allocating coherent memory in the PMD >> >> Hi Michał, >> >> I am getting build error for ICC [1] and shared library [2], can you please check? >> >> >> [1] >> .../drivers/net/ena/base/ena_com.c(323): error #592: variable "flags" is used >> before its value is set >> ENA_SPINLOCK_LOCK(admin_queue->q_lock, flags); >> ^ >> .../drivers/net/ena/base/ena_com.c(534): error #3656: variable "flags" may be >> used before its value is set >> ENA_SPINLOCK_LOCK(admin_queue->q_lock, flags); >> ^ >> .../drivers/net/ena/base/ena_com.c(589): error #592: variable "flags" is used >> before its value is set >> ENA_SPINLOCK_LOCK(admin_queue->q_lock, flags); >> ^ >> .../drivers/net/ena/base/ena_com.c(634): error #592: variable "flags" is used >> before its value is set >> ENA_SPINLOCK_LOCK(mmio_read->lock, flags); >> ^ >> .../drivers/net/ena/base/ena_com.c(1297): error #592: variable "flags" is used >> before its value is set >> ENA_SPINLOCK_LOCK(admin_queue->q_lock, flags); >> ^ >> .../drivers/net/ena/base/ena_com.c(1341): error #592: variable "flags" is used >> before its value is set >> ENA_SPINLOCK_LOCK(admin_queue->q_lock, flags); >> ^ >> > > That should be easy to fix - I prepared the patch but I want to send > it with second fix together. > >> >> >> [2] >> ena_ethdev.o: In function `eth_ena_pci_probe': >> .../drivers/net/ena/ena_ethdev.c:(.text+0x6de): undefined reference to >> `rte_timer_subsystem_init' >> .../drivers/net/ena/ena_ethdev.c:(.text+0x6ea): undefined reference to >> `rte_timer_init' >> ena_ethdev.o: In function `eth_ena_pci_remove': >> .../drivers/net/ena/ena_ethdev.c:(.text+0x854): undefined reference to >> `rte_timer_stop_sync' >> ena_ethdev.o: In function `ena_start': >> .../drivers/net/ena/ena_ethdev.c:(.text+0x1ff6): undefined reference to >> `rte_timer_reset' >> ena_ethdev.o: In function `ena_stop': >> .../drivers/net/ena/ena_ethdev.c:(.text+0x21a1): undefined reference to >> `rte_timer_stop_sync' >> ena_ethdev.o: In function `ena_close': >> .../drivers/net/ena/ena_ethdev.c:(.text+0x21d8): undefined reference to >> `rte_timer_stop_sync' >> > > Strange that this happens, it should be fixed in the patch: > mk: link librte_timer with --whole-archive > which seems to be no longer needed, because similar commit is already > applied (eb54ef42b02f94c4093556fdd6b51e2d7fd0df47). That should > resolve the issue with linking (at least for gcc it is helping) by > linking timer library with --whole-archive. > Could you, please, send me build logs so I could look closer if it is > properly built with ICC as I don't have access to it? Note "--whole-archive" is related to the static library build, but the above error is related to shared build, via "CONFIG_RTE_BUILD_SHARED_LIB=y" option. Adding librte_timer as a dependent library should fix the issue, like: diff --git a/drivers/net/ena/Makefile b/drivers/net/ena/Makefile index 43339f3b9..ff9ce315b 100644 --- a/drivers/net/ena/Makefile +++ b/drivers/net/ena/Makefile @@ -58,5 +58,6 @@ CFLAGS += $(INCLUDES) LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs LDLIBS += -lrte_bus_pci +LDLIBS += -lrte_timer include $(RTE_SDK)/mk/rte.lib.mk > > Thanks, > Michał >