From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f179.google.com (mail-we0-f179.google.com [74.125.82.179]) by dpdk.org (Postfix) with ESMTP id 4AE7A5921 for ; Mon, 5 Jan 2015 22:17:24 +0100 (CET) Received: by mail-we0-f179.google.com with SMTP id q59so8509877wes.24 for ; Mon, 05 Jan 2015 13:17:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=R9gsoLL8UR/bCzfImjdMMfxRyFLRk4bnELv+/kZDXSQ=; b=QkX68lbAbc0JHTsStYHfOHpRI/jQDpR0uBMYjkZoBRgyxZA1EJfgbztm58vjATJret SpaRB4ConvayetPfAemAi39Ec68vWqB0lVWVGA0phoBdrKTmC9IROZBy0OdJ/SIJwn/M H6zVbzML7xqQX4h78tfh/SbnBkZPbrAXP0Ae+LGvhPJP6GTxf/UAuK4UF2M5malcTojL zkQvHuTYgBzl58MhOcvkUk5rjE2ryg6L50tkGeKjT8KTqrLYsRysBqrsEJNpuTxRaVNu UsOjzg2PTJb7nWufJU/FbZLtxm3uXP5IbPQVzG2VWHpHUO7DR4/wJcOQoca7rwmfNIB5 hWJA== X-Gm-Message-State: ALoCoQkkVJijCOtpKaCPnSa1owtN71JP8FF5paQWOR/P8UzxAzbWcXHY7JC/TRaeJzITeA8O2bzS X-Received: by 10.194.185.243 with SMTP id ff19mr178817981wjc.126.1420492644180; Mon, 05 Jan 2015 13:17:24 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id ez1sm12072226wjd.31.2015.01.05.13.17.22 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Jan 2015 13:17:23 -0800 (PST) Date: Mon, 05 Jan 2015 13:17:23 -0800 (PST) X-Google-Original-Date: Mon, 05 Jan 2015 22:17 +0100 From: Thomas Monjalon To: Ravi Kerur Message-ID: <5340807.22YuSvaAXs@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.6-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <1419957440-11767-6-git-send-email-rkerur@gmail.com> References: <1419957384-11693-1-git-send-email-rkerur@gmail.com> <1419957440-11767-1-git-send-email-rkerur@gmail.com> <1419957440-11767-6-git-send-email-rkerur@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 6/6] Move common functions in eal_memory.c X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jan 2015 21:17:24 -0000 2014-12-30 11:37, Ravi Kerur: > Use common function names rte_eal_hugepage_init and > rte_eal_hugepage_attach for BSD and Linux. I'd like to be sure that using hugepage wording instead of contigmem is not too weird for BSD people. Do not forget that we have a kernel module called contigmem. Here, an ifdef or a wrapper seems appropriate to keep right wording. -- Thomas