From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD5B1A0C54; Tue, 10 Aug 2021 10:54:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5887440686; Tue, 10 Aug 2021 10:54:29 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 6D3674014F for ; Tue, 10 Aug 2021 10:54:27 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10070"; a="211756544" X-IronPort-AV: E=Sophos;i="5.84,310,1620716400"; d="scan'208";a="211756544" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2021 01:54:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,310,1620716400"; d="scan'208";a="506082698" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga004.fm.intel.com with ESMTP; 10 Aug 2021 01:54:26 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Tue, 10 Aug 2021 01:54:25 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Tue, 10 Aug 2021 01:54:25 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Tue, 10 Aug 2021 01:54:25 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.170) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Tue, 10 Aug 2021 01:54:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X6H2fvSEqi4NVY2qgvhvtH9xeYp0oZCF6r/hzFaA5S8QynFYsElqgBr/6WXpzp7gGCksIpY1FEjc/iLZPaJcaAumXUVFJwFHVJip1ZXw9roDVl9Wxrb9uzI3fdJ637vWtqqJxWeB+DD7/TLyykuMexbWfNISkQmjFdUPDzT7trJwRbcd1aWNGw6ASr6MGQReB2vZZDJR0TbkBPBUPKEdaelXlc27jfyatEkertvIAc6BENi/egLQSEdM8bjiYzT/ydza9sMfzZ75vNxpi7kxCiNV7hmTzkwKAJhBKxv4sDConkgvtYR/PxiZJrqOCml7QOFe2YKoLHOa23FzdTfYnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XmLZyhZ3p+Egrem9aNxbQJ3ciwRNab9z9vtXTod+k9w=; b=PmpW8C1dWxw3sHMnrnJkzH5hH4yXUBh9CidpRS632515lueKKWZSaXIcTeBuzp2drq0xZVfDAzZoDij4+K90Be07o2MeGvgcr6SHpqEVYvKvf0xTXJn1v9IxJZ/5xtY6ZBkh6YyddNg2cXX08AOUfFrqkEKz/DcSHFAQKIFlV/z+UE84TMODS0hQjfSfPEJWyZRguCrG0kmecq8tYV91qmtaE25MXYVv1pEVt6U7vYfj/NaAfEgNoNsgOogaGZlV2KrdfyGyVGOlml7+uRJff1VQpZ5iwNT1rorTLF2WVjSnupBElTS/L+O+k6GqorQVrn56Z1MTT1RKQe6ViqcmVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XmLZyhZ3p+Egrem9aNxbQJ3ciwRNab9z9vtXTod+k9w=; b=C81YIpVMse3INvnKJt/FD+KH2/tMJjigCGj51H37RGcECav8e8XO/cB55GSZfpMUvNQ49X01OCTTtQihMoXd+sKpzCDM4wkCMuovo3F5BczFPQZ17n6jcS15CU1tGosyO35AsPUG4WhHkyNzgfdca+PTeevY2F5OuIWvXMNxjPk= Authentication-Results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4823.namprd11.prod.outlook.com (2603:10b6:510:43::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.21; Tue, 10 Aug 2021 08:54:24 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::2979:70ca:38a:dbaf]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::2979:70ca:38a:dbaf%6]) with mapi id 15.20.4394.023; Tue, 10 Aug 2021 08:54:24 +0000 To: "Xueming(Steven) Li" , "Singh, Aman Deep" , Andrew Rybchenko CC: "dev@dpdk.org" , Slava Ovsiienko , NBU-Contact-Thomas Monjalon References: <20210727034134.20556-1-xuemingl@nvidia.com> <24309185-57e8-9a21-6b3a-939c4d74f1e7@oktetlabs.ru> <3032fdb1-58a5-5470-9903-09b992c059d4@intel.com> <8f8178d5-65e5-43f4-fc17-f753183e8042@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <534241c3-4423-bfa9-b7ee-56f0f5e59f5f@intel.com> Date: Tue, 10 Aug 2021 09:54:17 +0100 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: ZR0P278CA0034.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1c::21) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.206] (37.228.236.146) by ZR0P278CA0034.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.15 via Frontend Transport; Tue, 10 Aug 2021 08:54:22 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 55541170-3e38-4933-30c5-08d95bdc73cc X-MS-TrafficTypeDiagnostic: PH0PR11MB4823: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CNS5KYMCBu6I+nWmkc56USvJgaS7eOwIlJukL6GgnggzBxl2r47Q36Sfl+3gX3f4LJrS+N/KTGZSmUiiL2zyRyT3oAGXmyD/aWRLVNtTxhY5sv9Wv/wPAfVrjZsfArXhxmMSXtDw23ZqP/4TrpTioh26kxvyBdZXXa2gpvRUahspa8liUu6w3IVREjTx74gKX4k8Va4O08bXXYjUQtmkUDXMy209TuGqUHQ2C9Tfdz87dUsvgsDesO4i5TPANmf516u2tVdkvu31fVIXzGfvyytyTQRO64gYsTWVsY4XpWoSoYqe8JQajd/EuVG7RCKj27R2gyDRmyTlxe/khkoPtIViy1z1A904stmVvL73kkUG3+a3ZKx19GL8sbrJinE1fR5CkeGNVntT/vwPcYG3Viq13Df7M92Zp3kK8RJCsGTI5p29etmuQkPmxIryDG8rkTeP4vruIVNx6WfrP3cLtI1Afn+qvTEF4XRwNXWT3y+JZZNDEEDnJG1Sq/Pw1JqsOowP7zn93nE5Yqy6cRCgWJiZmuAG6f0LQ8I2zo5mvrylZJaMISVyBc8KZwYUoS7TjwVK0Jg3WMCuqxyBOKNeNCzKniQRTP8Hjl2Bo/D1RlVCb7MTzd9N1tvbUHvf8alUq7LMfBnz+2UyGDNlyhyfhlXw5Ew7i76UMlDwltENh0DpSS3gxmilezsrORxj2u99yW3QHGGEKFKn4UwUQYocsQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(376002)(39860400002)(366004)(136003)(36756003)(38100700002)(478600001)(4326008)(44832011)(31696002)(956004)(316002)(5660300002)(2906002)(6486002)(83380400001)(53546011)(110136005)(16576012)(2616005)(186003)(86362001)(8676002)(31686004)(66946007)(6666004)(54906003)(66476007)(66556008)(26005)(8936002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dm1ySUFwNFNaUXpWekFQWTBtMjN1Y0VGV2hYQzlveTVjY2ZQbFU5aXpCOFF5?= =?utf-8?B?RWJKSXd3Snl3RG5HK2NxbDdXSGdoTnNXZDJCRzkwRUFQNHJEVUl2UkZRakZ0?= =?utf-8?B?L0xIYUxmQVJ5RlN6R0tKRHYxdkw0OUFucXpQSVVlM3FkbXlyZ05qdWxWem1t?= =?utf-8?B?OXRna3RQVUZMa0ZiYWMvNTJudkovRGkwSTRSMEl3bUVZbjI2TDZWREUwdWhw?= =?utf-8?B?UTY2b3FxQVBmaTc4T1dxRCthTzBKSkVSRmp0UU0wbEJRdFBGQVpQSjM2MTlX?= =?utf-8?B?dTRlZEtsYlNmVEY0VmsrQWF5bHlKVFduUE1kWEpiaitYTjRSQll1ak1CSzNI?= =?utf-8?B?WTZsUC9TSko0SWx2ZHJOMkxLaFVaOXlDSk45NUFiK3hsd3l6RFlBTUxyS0Vz?= =?utf-8?B?dVRXYTZtVDNTUnpUZ0xOZ2JKN1lCOEtVNmV2alNxTnNidjUzVytmSDZDR3BV?= =?utf-8?B?dFJVeHNKNGlySUVmNGY1dEl5dFU3bUFYaFI3Uk56MlQvZDdlcXoxSE13MnVY?= =?utf-8?B?YUR1YWF3TzZoYzAyOFJ4WGtndDNVanROT01oQk40VVQ2eHlhejJ2RjY1V1cr?= =?utf-8?B?V292R2c1eXJrRWV3dnQ5WXNVOUtZUEliWEhGOXMwcWlwajA2SHg2aC9jNDJ3?= =?utf-8?B?UVczbEJqaXNqZUhWZTh6ajYrOW5raGwzMXAycEM1ZUR4Y2xOS2JuelV4ME01?= =?utf-8?B?eGJwU2RpN1dESEZLUDd0SjdLQTduWk1OcFl0MERoMlMvSWNDcVJwWDQ5R0VF?= =?utf-8?B?dHlmc0RjVmI0cnFlaCtMa1pkVTJBQmpzVXJScDlqZlNpd0EzanhHVjluYmJ4?= =?utf-8?B?azBSenlqLzhHcWZhVGM3RFg2NG55bU8vdWo5R0lFaG9FSVVwTlYwb1loWU5X?= =?utf-8?B?NXd0VXNXU05oNGl3QWRKRTI5RERiVjR0M2tENEZNRmdiZDB3WWlLOWdLaUhU?= =?utf-8?B?Z1B1dVdRekJLejdhRGxnUUpycFpzMUxnaWpkTkFuMTAxRDB0V2lzMHNPaWFJ?= =?utf-8?B?MlVneUxCTDBua3cxM3FXSFRlTkQ5aGROQmdZVXkwZUVsenVhNmNKWGZzOVRx?= =?utf-8?B?UEFPM052QmNLWHo5bHR2ZFg3TVN1aWQ3SDhqbkhjaGx1N01Oc21qTWtMMlJM?= =?utf-8?B?M3JEcGNmUmorY2hrcEF3MVdaZEpYOERiZnZjT1FxaFM1Wm5YTlhzeXNRV1lz?= =?utf-8?B?eHVGQjZVb1RhMGovdFNSZTl0WUtncnljRUdvVUF2T2NFdWpwdTNQNWluOXBF?= =?utf-8?B?ZWtnOEdWQW1xTHlOM1NOVFdGV01pQjFTaXlCZ1Z5VUYvck5VSkUxeUVBNDZD?= =?utf-8?B?NkROS3JEd0YzaUtPUFkxelFBdUh2dUM5L04zemZyeU56cEluRlE4b0ZXb0k0?= =?utf-8?B?cENPMEJYeUhvcHcycStGZDduWmR3YnQ1M3d4VEEramJlUjAzb0taTTdpaitU?= =?utf-8?B?TjZWMUNyZEFNc0c3VzFEQW5RVVJzaWtBeTRYRTVXek1BMS91TXlJNDYvY0tj?= =?utf-8?B?M3FGV01jYzRoa3pvbDJJS2p5Y0hVNEhSWEViczdsWHpLN2J3cVFrUEZKWm1x?= =?utf-8?B?b2xkeTFFS0JqSjVnYXRwVnlueFBNR3VzVXhHdG5YbU5kQVF1M0lnUlA3WlpC?= =?utf-8?B?RVlqSjNkWHY5a0d2VFppY3JPUVkyR25XRzdPMzF4aU1GTG1TRTZFWVExN0xG?= =?utf-8?B?OTNrRzVSUk14N1RyQUhTRkpXTWlyUHFuWklUMGNrYXZ1S09ZK29DQmtVUllv?= =?utf-8?Q?sER7L19oidAt/FhC5ufTCZxKuG34Wa2nFFpjwja?= X-MS-Exchange-CrossTenant-Network-Message-Id: 55541170-3e38-4933-30c5-08d95bdc73cc X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2021 08:54:24.4574 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PZi0G8H8eE/JOrkFEQtOLEaNoZ6/hQ2h3GB+zmDnAki2SEPVstNzu6AgEHQNC/zbgj7v5Qnmt+NWdtij8SMl1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4823 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [RFC] ethdev: change queue release callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/10/2021 9:03 AM, Xueming(Steven) Li wrote: > Hi Singh and Ferruh, > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Monday, August 9, 2021 11:31 PM >> To: Singh, Aman Deep ; Andrew Rybchenko ; Xueming(Steven) Li >> >> Cc: dev@dpdk.org; Slava Ovsiienko ; NBU-Contact-Thomas Monjalon >> Subject: Re: [dpdk-dev] [RFC] ethdev: change queue release callback >> >> On 8/9/2021 3:39 PM, Singh, Aman Deep wrote: >>> Hi Xueming, >>> >>> On 7/28/2021 1:10 PM, Andrew Rybchenko wrote: >>>> On 7/27/21 6:41 AM, Xueming Li wrote: >>>>> To align with other eth device queue configuration callbacks, change >>>>> RX and TX queue release callback API parameter from queue object to >>>>> device and queue index. >>>>> >>>>> Signed-off-by: Xueming Li >>>> >>>> In fact, there is no strong reasons to do it, but I think it is a >>>> nice cleanup to use (dev + queue index) on control path. >>>> >>>> Hopefully it will not result in any regressions. >>> >>> Combined there are 100+ API's for Rx/Tx queue_release that need to be >>> modified for it. >>> >>> I believe all regression possibilities here will be caught, in >>> compilation phase itself. >>> >> >> Same here, it is a good cleanup but there is no strong reason for it. >> >> Since it is all internal, there is no ABI restriction on the patch, and v21.11 will be full ABI break patches, to not cause conflicts with this >> change, what would you think to have it on v22.02? > > This patch is required by shared-rxq feature which ABI broken, target to 21.11. Why it is required? > I'll do it carefully, fortunately, the change is straightforward. >