From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9F849A04B7;
	Wed, 14 Oct 2020 09:46:18 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id DE9BB1DB88;
	Wed, 14 Oct 2020 09:46:15 +0200 (CEST)
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 4D36F1DAA2;
 Wed, 14 Oct 2020 09:46:13 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
 by mailout.nyi.internal (Postfix) with ESMTP id CE78C5C0127;
 Wed, 14 Oct 2020 03:46:11 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute2.internal (MEProxy); Wed, 14 Oct 2020 03:46:11 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=fm2; bh=
 kIfh+HpBgGHO64rjjtDJE7hfDDTLx9e+QABTNMpJu1M=; b=m0mbL2+jnxylW1h1
 /60iGYxYx30uBjB6g2I0CO1ozw9FnXniDJhn+UQ75PkghcF4H7n4BvddCob5AI/m
 IYMvI7LKcWPep8rcacM3F3EEz9P16h2qTmrQFpmNRugW90PHWbkuDrvNkl2QAcfS
 yxXRjfC07xKm8rL1DPP1/uRhE8JRBTc5NritXlZfobTsvgYU3VO2hFbq2YO/XP+y
 8aJ8UoagsHlTq/oKJPGanDNVABkTrjS5P0pOwkrLyL2mp0x2PSYptjrtN7C/yHdK
 /8TEk7dRwJ6MBMzM917i0ZQSnCPyxWWNAraFWdA8DyyBy2ioTejIqBb5n/Fd+Z8W
 iSlCxA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=kIfh+HpBgGHO64rjjtDJE7hfDDTLx9e+QABTNMpJu
 1M=; b=WwbT3WPsx0IUfk/Bk745uGwW7rDFNMZRaRYGOoHIolbH2rK/PrkBMUt6z
 ZM0L1pngnPE0VDjfmvDjnAP8CmeMM5e2kHB4sd2A4nKbfiX4srYki7LDJMwtDYu6
 6wcAl3sgGTPE1H1GLhxlIKFA+CNIoqAPAoK1RWBWLDrsWfmoNime/YwTSjB4ljMa
 LhL3TZR0L/2a2bbOU9Fe7NY/4Tg/eN7Mz06+/YKzo3+JoyoouxNM+s9MQNAh+Du7
 tDGtxoaC3rJiRgLjDHzwDIfaBmmbyJiet4vI2iehPWhpb+f0F+AhOM+U1fbT2lEI
 YmltovWg63dMTYafdBJNrXDXD9Lqg==
X-ME-Sender: <xms:w6yGX1Rw9HgkNbOuy08hoBmCzF0er250rugZHE72aANGeBv_yQS4HA>
 <xme:w6yGX-xnZcp5H602hc9SIWw0H2O6niiMzny13L4LXz0urpaGebtWvvzTKuTkRnqbK
 ibvEgzAxqJ03quN_A>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedriedtgdduvdeiucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
 shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
 ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu
 ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf
 hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl
 ohhnrdhnvght
X-ME-Proxy: <xmx:w6yGX62fe7VPavdVWRc-XMkZfgzKSRU5UzsBfWEYn5LKjzwywXYFbg>
 <xmx:w6yGX9DWd9UFpYTIBYpHcmg7TH99J43yqLnjPIc4wfkFmFFi9PxBXw>
 <xmx:w6yGX-gaCTNrWnLnoYuC44xkCXLcE_Eh6hTbhDqJarqsZkovYmnzwA>
 <xmx:w6yGX2ePQMzZUg7c43E36wc1-ouNxQjlu_fzFKG8i9f2Z2WVeTP30Q>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 8BD29306467D;
 Wed, 14 Oct 2020 03:46:10 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Akhil Goyal <akhil.goyal@nxp.com>
Cc: dev@dpdk.org, techboard@dpdk.org, anoobj@marvell.com,
 hemant.agrawal@nxp.com, declan.doherty@intel.com, david.coyle@intel.com
Date: Wed, 14 Oct 2020 09:46:09 +0200
Message-ID: <5343391.ofL17Uz9jy@thomas>
In-Reply-To: <20201012141006.31463-3-akhil.goyal@nxp.com>
References: <20201011213403.21169-1-akhil.goyal@nxp.com>
 <20201012141006.31463-1-akhil.goyal@nxp.com>
 <20201012141006.31463-3-akhil.goyal@nxp.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v3 2/8] security: modify PDCP xform to
	support SDAP
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

12/10/2020 16:10, Akhil Goyal:
> The SDAP is a protocol in the LTE stack on top of PDCP for
> QOS. A particular PDCP session may or may not have
> SDAP enabled. But if it is enabled, SDAP header should be
> authenticated but not encrypted if both confidentiality and
> integrity is enabled. Hence, the driver should be intimated
> from the xform so that it skip the SDAP header while encryption.
> 
> A new field is added in the PDCP xform to specify SDAP is enabled.
> The overall size of the xform is not changed, as hfn_ovrd is just
> a flag and does not need uint32. Hence, it is converted to uint8_t
> and a 16 bit reserved field is added for future.
> 
> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
> ---
>  doc/guides/rel_notes/release_20_11.rst |  9 +++++++++
>  lib/librte_security/rte_security.h     | 12 ++++++++++--
>  2 files changed, 19 insertions(+), 2 deletions(-)
> 
> diff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst
> index c34ab5493..fad91487a 100644
> --- a/doc/guides/rel_notes/release_20_11.rst
> +++ b/doc/guides/rel_notes/release_20_11.rst
> @@ -103,6 +103,11 @@ New Features
>    also known as Mount Bryce.  See the
>    :doc:`../bbdevs/acc100` BBDEV guide for more details on this new driver.
>  
> +* **Updated rte_security library to support SDAP.**
> +
> +  ``rte_security_pdcp_xform`` in ``rte_security`` lib is updated to enable
> +  5G NR processing of SDAP header in PMDs.
> +

Please try to keep the ordering:
crypto and security stuff should be after ethdev drivers
and related stuff (I would say even after flow-perf).

>  * **Updated Virtio driver.**
>  
>    * Added support for Vhost-vDPA backend to Virtio-user PMD.
> @@ -307,6 +312,10 @@ API Changes
>    ``rte_fpga_lte_fec_configure`` and structure ``fpga_lte_fec_conf`` to
>    ``rte_fpga_lte_fec_conf``.
>  
> +* security: ``hfn_ovrd`` field in ``rte_security_pdcp_xform`` is changed from
> +  ``uint32_t`` to ``uint8_t`` so that a new field ``sdap_enabled`` can be added
> +  to support SDAP.

For the API change,
Acked-by: Thomas Monjalon <thomas@monjalon.net>