[dpdk-dev] [PATCH] app/testbbdev: fix unchecked return value

[dpdk-dev] [PATCH] app/testbbdev: fix unchecked return value

[Amr Mokhtar]

add check for rte_bbdev_callback_register() retun

Coverity issue: 257027
Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev")

Signed-off-by: Amr Mokhtar <amr.mokhtar@intel.com>
---
 app/test-bbdev/test_bbdev_perf.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
index f7b51ca..21efad4 100644
--- a/app/test-bbdev/test_bbdev_perf.c
+++ b/app/test-bbdev/test_bbdev_perf.c
@@ -1557,9 +1557,11 @@ throughput_test(struct active_device *ad,
 			throughput_function = throughput_intr_lcore_enc;
 
 		/* Dequeue interrupt callback registration */
-		rte_bbdev_callback_register(ad->dev_id, RTE_BBDEV_EVENT_DEQUEUE,
-				dequeue_event_callback,
+		ret = rte_bbdev_callback_register(ad->dev_id,
+				RTE_BBDEV_EVENT_DEQUEUE, dequeue_event_callback,
 				&t_params);
+		if (ret < 0)
+			return ret;
 	} else {
 		if (test_vector.op_type == RTE_BBDEV_OP_TURBO_DEC)
 			throughput_function = throughput_pmd_lcore_dec;
-- 
2.7.4

Re: [dpdk-dev] [PATCH] app/testbbdev: fix unchecked return value

[Thomas Monjalon]

31/01/2018 14:54, Amr Mokhtar:
> add check for rte_bbdev_callback_register() retun
> 
> Coverity issue: 257027
> Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev")
> 
> Signed-off-by: Amr Mokhtar <amr.mokhtar@intel.com>

Applied, thanks

[dpdk-dev] [PATCH] app/testbbdev: fix unchecked return value

[Kamil Chalupnik]

Fixing CHECKED_RETURN issue by checking values returned
by rte_bbdev_dec_op_alloc_bulk and rte_bbdev_enc_op_alloc_bulk
functions.

Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev")
Coverity issue: 279447, 279456

Signed-off-by: Kamil Chalupnik <kamilx.chalupnik@intel.com>
---
 app/test-bbdev/test_bbdev_perf.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
index ca162d9..6861edc 100644
--- a/app/test-bbdev/test_bbdev_perf.c
+++ b/app/test-bbdev/test_bbdev_perf.c
@@ -1731,7 +1731,9 @@ latency_test_dec(struct rte_mempool *mempool,
 		if (unlikely(num_to_process - dequeued < burst_sz))
 			burst_sz = num_to_process - dequeued;
 
-		rte_bbdev_dec_op_alloc_bulk(mempool, ops_enq, burst_sz);
+		ret = rte_bbdev_dec_op_alloc_bulk(mempool, ops_enq, burst_sz);
+		TEST_ASSERT_SUCCESS(ret,
+				"rte_bbdev_dec_op_alloc_bulk() failed");
 		if (test_vector.op_type != RTE_BBDEV_OP_NONE)
 			copy_reference_dec_op(ops_enq, burst_sz, dequeued,
 					bufs->inputs,
@@ -1798,7 +1800,9 @@ latency_test_enc(struct rte_mempool *mempool,
 		if (unlikely(num_to_process - dequeued < burst_sz))
 			burst_sz = num_to_process - dequeued;
 
-		rte_bbdev_enc_op_alloc_bulk(mempool, ops_enq, burst_sz);
+		ret = rte_bbdev_enc_op_alloc_bulk(mempool, ops_enq, burst_sz);
+		TEST_ASSERT_SUCCESS(ret,
+				"rte_bbdev_enc_op_alloc_bulk() failed");
 		if (test_vector.op_type != RTE_BBDEV_OP_NONE)
 			copy_reference_enc_op(ops_enq, burst_sz, dequeued,
 					bufs->inputs,
-- 
2.5.5

Re: [dpdk-dev] [PATCH] app/testbbdev: fix unchecked return value

[Mokhtar, Amr]

> -----Original Message-----
> From: Chalupnik, KamilX
> Sent: Wednesday 16 May 2018 14:57
> To: Mokhtar, Amr <amr.mokhtar@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org; Chalupnik, KamilX <kamilx.chalupnik@intel.com>
> Subject: [PATCH] app/testbbdev: fix unchecked return value
> 
> Fixing CHECKED_RETURN issue by checking values returned
> by rte_bbdev_dec_op_alloc_bulk and rte_bbdev_enc_op_alloc_bulk
> functions.
> 
> Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev")
> Coverity issue: 279447, 279456
> 
> Signed-off-by: Kamil Chalupnik <kamilx.chalupnik@intel.com>

Acked-by: Amr Mokhtar <amr.mokhtar@intel.com>

Re: [dpdk-dev] [PATCH] app/testbbdev: fix unchecked return value

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: Mokhtar, Amr
> Sent: Thursday, May 17, 2018 1:41 PM
> To: Chalupnik, KamilX <kamilx.chalupnik@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] app/testbbdev: fix unchecked return value
> 
> 
> > -----Original Message-----
> > From: Chalupnik, KamilX
> > Sent: Wednesday 16 May 2018 14:57
> > To: Mokhtar, Amr <amr.mokhtar@intel.com>; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch@intel.com>
> > Cc: dev@dpdk.org; Chalupnik, KamilX <kamilx.chalupnik@intel.com>
> > Subject: [PATCH] app/testbbdev: fix unchecked return value
> >
> > Fixing CHECKED_RETURN issue by checking values returned by
> > rte_bbdev_dec_op_alloc_bulk and rte_bbdev_enc_op_alloc_bulk functions.
> >
> > Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev")
> > Coverity issue: 279447, 279456

Added Cc: stable@dpdk.org

> >
> > Signed-off-by: Kamil Chalupnik <kamilx.chalupnik@intel.com>
> 
> Acked-by: Amr Mokhtar <amr.mokhtar@intel.com>

Applied to dpdk-next-crypto.

By the way, could you change your author name to Kamil Chalupnik,
to match your "Signed-off-by:" line.

Thanks,
Pablo