From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2C92A0524; Fri, 27 Nov 2020 18:56:48 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 44CA6C94E; Fri, 27 Nov 2020 18:56:46 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 5CA6AC93C for ; Fri, 27 Nov 2020 18:56:43 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id ED9605C0055; Fri, 27 Nov 2020 12:56:41 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 27 Nov 2020 12:56:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 4M5VY18OS3+o/qU5/NHrC7HhA0OIy8j3swyQcbcWtsE=; b=YgOqscPdwYiGIEMq QCDZjchtDD4OifZYTWM4TvOxoflCticT5Yo3P61mKhJMrfYPj/ZapxBpMGF/sIfp S0ua8An7rG5K2ODvRyjVUtDF8vxSVnngl/jZd12LDQtNv/m1EBtsYk8UVh29KxmQ vIkC7iUht/cLzdoLyC3g7K1ou7LRx9+xygEYkhAirImKfS85WBbbDR+W+JRgacp0 K6m5OMGcewEmhYZHchmUnZpQwX8uuGuEPKBNLxOw+9B0dbEUND4ZWT0Ds1rcFumq z1+RkylMK5+FVkfqjje85bVevGuIJ+6+wJjZbbk0+Lp7gXpN8poHOo1NdKW5Yhhd Yp3GEA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=4M5VY18OS3+o/qU5/NHrC7HhA0OIy8j3swyQcbcWt sE=; b=c6zUuGWlJ57h+NIOz32lKlKLX8sFTWMgf2g4w3ORkrJUhb1Lxkmz7U4y/ wdwu5w5gk3U7JCs1Q0SvhMvvWRATvs/1SXPpRy4Nn3WiIxaU2uon3LhsDnzbpH+4 a40llPg9AGarCjemWqu0cI6ZnjvHtLTIno9vduGA0LoYIKKyNsrw7mQOeKv5nlSr aoPa9ParBAJ3zl4Cx4pNeutn8CqHDzyIK0L6veGw+A2xU4LDZS1nwanVhVn9YEmY 2TH+iVnJ9pzQoME1d6QGTIb+hXN1G1ifQczXzZ/ojsaBl/QFbN9XX9Hfj1aWDSJW /QRpsyPpozXWS5GN0CSQ7Ho4t0/tg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudehgedguddtkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 00B173064AAA; Fri, 27 Nov 2020 12:56:39 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, Ray Kinsella , Neil Horman , Andrew Rybchenko , Ori Kam , Ajit Khaparde , bruce.richardson@intel.com Date: Fri, 27 Nov 2020 18:56:38 +0100 Message-ID: <5350841.JcZGr44II1@thomas> In-Reply-To: References: <20201123134007.2870297-1-ferruh.yigit@intel.com> <20201124131535.276072-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] doc: announce flow API matching pattern struct changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 24/11/2020 15:29, Ajit Khaparde: > On Tue, Nov 24, 2020 at 5:15 AM Ferruh Yigit wrote: > > > > Proposing to replace protocol header fields in the ``rte_flow_item_*`` > > structures with the protocol structs. > > > > This is both for documenting the intention and to be sure > > ``rte_flow_item_*`` always starts with complete protocol header. > > > > Change will be done in two steps, at first step in v21.02 release, > > protocol header struct will be added as union, for example: > > > > Current ``struct rte_flow_item_eth``, > > > > struct rte_flow_item_eth { > > struct rte_ether_addr dst; > > struct rte_ether_addr src; > > rte_be16_t type; > > uint32_t has_vlan:1; > > uint32_t reserved:31; > > } > > > > will become in v21.02: > > > > __extension__ > > struct rte_flow_item_eth { > > union { > > struct { > > struct rte_ether_addr dst; > > struct rte_ether_addr src; > > rte_be16_t type; > > }; > > struct rte_ether_hdr hdr; > > }; > > uint32_t has_vlan:1; > > uint32_t reserved:31; > > } > > > > After this point usage should switch to 'hdr' struct. > > > > And in the second step, in the v21.11 LTS release the protocol fields > > will be removed, and the struct will become: > > > > struct rte_flow_item_eth { > > struct rte_ether_hdr hdr; > > uint32_t has_vlan:1; > > uint32_t reserved:31; > > } > > > > Already many ``rte_flow_item_*`` structures implemented to have protocol > > struct, target is convert all to this usage. > > > > Signed-off-by: Ferruh Yigit > > Acked-by: Andrew Rybchenko > Acked-by: Ajit Khaparde Acked-by: Thomas Monjalon Applied, thanks