From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7FF58433F0; Tue, 28 Nov 2023 11:32:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0BB3240E54; Tue, 28 Nov 2023 11:32:03 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 7B211402C2 for ; Tue, 28 Nov 2023 11:32:01 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 5A07D3200A82; Tue, 28 Nov 2023 05:31:57 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 28 Nov 2023 05:31:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1701167516; x=1701253916; bh=adPnv8noVbTolsVSi3buywJ8+u1NvVSMAes uGHDiFYg=; b=GwGqFnnXW9Clw0rIPRWbvn8xFpSYmBOlo4ktfOxzzkXEEcDNJ6t VyuOFEK8kAb3unvb1azdzytvJiiozRJYEsoZ/+oDX/TGMP4QJipyw4IR+8x34zZc It5rPrAKLtVRVIYwJ0PGA3v1jDHCwJHBsEbVxYnuJDs6we95VucBjgzemUY3zU4B 1jVqgzi/p6X8d05l+Xvo4pGdQ+33w7SxCEGqBH7a2ZOhceXBF0Jf1W8STNvtcUqT XB8GDHj4FCHdQX59k6Gu/VhDV3b9fkPjp/pEkjd1XEctv3meUa5jx/5VHWNf2IDH Wbs5if24MTwcF4Z0vOCaqzAuy92eMbnZggw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1701167516; x=1701253916; bh=adPnv8noVbTolsVSi3buywJ8+u1NvVSMAes uGHDiFYg=; b=lzV+8vdTyhiEaSAJZKpbaAIk1B7sq9wUInuEsLD5ogIpZT5M0eG VPARywTu/UDJVuU3y69lKPr6nusUbdTslFyauSdvS0zZ8ntpL58kVIyQ7NlcDVlQ Gu6pYc4I/TmjhqIBFc/lDBsxFtAdqcjS/oqTQIdP4BaMO7q09xbTsBNteRHXemDU hAVJvt0kgWGtO1DOWnkDN9TblQfb6KnLNBGaaPCkoB1vzLJY9s12sRVCe4ype62n PxcaoExjb3IUDQwmbZdGRy8sgUUdgfi+xcPXbB6+uKm1H6R8buJK/A99h3Y/oP3g 3+y8nnGuHU2g5tvY9BhyrAHLWMZbBMdxy7Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeifedgudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 28 Nov 2023 05:31:54 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit , Dengdui Huang , Jie Hai Cc: dev@dpdk.org, David Marchand , stephen@networkplumber.org, lihuisong@huawei.com, liuyonglong@huawei.com, fengchengwen@huawei.com Subject: Re: [PATCH 0/3] fix some bug for hns3 Date: Tue, 28 Nov 2023 11:31:52 +0100 Message-ID: <5351521.1BCLMh4Saa@thomas> In-Reply-To: References: <20231127133903.1138657-1-huangdengdui@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 28/11/2023 04:33, Jie Hai: > On 2023/11/28 2:33, Ferruh Yigit wrote: > > On 11/27/2023 1:55 PM, Jie Hai wrote: > >> On 2023/11/27 21:39, Dengdui Huang wrote: > >>> Dengdui Huang (3): > >>> net/hns3: fix reset detect be ignored > >>> net/hns3: fix VF wrong clear reset status > >>> net/hns3: fix the VF reset interrupted possibly > >> Hi, Dengdui, > >> > >> Good fix. > >> For the patchset, > >> Acked-by: Jie Hai > >> > > > > > > Hi Jie, Dengdui, is this set for this release, which is a few days away? > > My suggestion is to wait next version as issues doesn't look critical. > > > > > > I applied set to next-net, but leaving decision to pull it for the > > release or not to Thomas/David. > > > > Applied to dpdk-next-net/main, thanks. > > > Hi, Ferruh, Thomas and David, > > I'm sorry that this problem is a little serious. > > a) Without [PATCH 2/3], when the VF executes the > hns3_clear_reset_event(), unexpected memory is written. > As a result, unexpected errors occur in the program or even the app may > crash. > b) Without [PATCH 3/3], there is a low probability that the app is > unavailable after the FLR reset is done. > c) In addition, some LTS versions have the same problem. > > Therefore, we hope that the problem can be solved in the current version. OK applied, thanks.