* [PATCH] config/x86: config support for AMD EPYC processors
@ 2023-12-20 7:10 Sivaprasad Tummala
2023-12-20 7:27 ` Morten Brørup
2023-12-21 5:11 ` [PATCH v2] " Sivaprasad Tummala
0 siblings, 2 replies; 6+ messages in thread
From: Sivaprasad Tummala @ 2023-12-20 7:10 UTC (permalink / raw)
To: mb, david.marchand, ktraynor, thomas, konstantin.ananyev,
konstantin.v.ananyev, bruce.richardson, maxime.coquelin, aconole,
ferruh.yigit
Cc: dev
On x86 platforms, max lcores are limited to 128 by default.
On AMD EPYC processors, this limit was adjusted for native
builds in the previous patch.
https://patches.dpdk.org/project/dpdk/patch/
20230925151027.558546-1-sivaprasad.tummala@amd.com/
As agreed earlier in mailing list, this patch adjusts the limit
for specific AMD EPYC target/cross builds.
Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
---
config/x86/meson.build | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/config/x86/meson.build b/config/x86/meson.build
index 5355731cef..f2df4c2003 100644
--- a/config/x86/meson.build
+++ b/config/x86/meson.build
@@ -91,13 +91,21 @@ epyc_zen_cores = {
'__znver1__':128
}
-if get_option('platform') == 'native'
+cpu_instruction_set = get_option('cpu_instruction_set')
+if cpu_instruction_set == 'native'
foreach m:epyc_zen_cores.keys()
if cc.get_define(m, args: machine_args) != ''
dpdk_conf.set('RTE_MAX_LCORE', epyc_zen_cores[m])
break
endif
endforeach
+else
+ foreach m:epyc_zen_cores.keys()
+ if m.contains(cpu_instruction_set)
+ dpdk_conf.set('RTE_MAX_LCORE', epyc_zen_cores[m])
+ break
+ endif
+ endforeach
endif
dpdk_conf.set('RTE_MAX_NUMA_NODES', 32)
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] config/x86: config support for AMD EPYC processors
2023-12-20 7:10 [PATCH] config/x86: config support for AMD EPYC processors Sivaprasad Tummala
@ 2023-12-20 7:27 ` Morten Brørup
2023-12-20 9:22 ` Tummala, Sivaprasad
2023-12-21 5:11 ` [PATCH v2] " Sivaprasad Tummala
1 sibling, 1 reply; 6+ messages in thread
From: Morten Brørup @ 2023-12-20 7:27 UTC (permalink / raw)
To: Sivaprasad Tummala, david.marchand, ktraynor, thomas,
konstantin.ananyev, konstantin.v.ananyev, bruce.richardson,
maxime.coquelin, aconole, ferruh.yigit
Cc: dev
> From: Sivaprasad Tummala [mailto:sivaprasad.tummala@amd.com]
> Sent: Wednesday, 20 December 2023 08.11
>
> On x86 platforms, max lcores are limited to 128 by default.
>
> On AMD EPYC processors, this limit was adjusted for native
> builds in the previous patch.
> https://patches.dpdk.org/project/dpdk/patch/
> 20230925151027.558546-1-sivaprasad.tummala@amd.com/
>
> As agreed earlier in mailing list, this patch adjusts the limit
> for specific AMD EPYC target/cross builds.
>
> Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
> ---
[...]
> + foreach m:epyc_zen_cores.keys()
> + if m.contains(cpu_instruction_set)
> + dpdk_conf.set('RTE_MAX_LCORE', epyc_zen_cores[m])
> + break
The indentation of "break" uses a mix of tab and spaces, and should be fixed.
Acked-by: Morten Brørup <mb@smartsharesystems.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] config/x86: config support for AMD EPYC processors
2023-12-20 7:27 ` Morten Brørup
@ 2023-12-20 9:22 ` Tummala, Sivaprasad
0 siblings, 0 replies; 6+ messages in thread
From: Tummala, Sivaprasad @ 2023-12-20 9:22 UTC (permalink / raw)
To: Morten Brørup, david.marchand, ktraynor, thomas,
konstantin.ananyev, konstantin.v.ananyev, bruce.richardson,
maxime.coquelin, aconole, Yigit, Ferruh
Cc: dev
[AMD Official Use Only - General]
Hi Morten,
> -----Original Message-----
> From: Morten Brørup <mb@smartsharesystems.com>
> Sent: Wednesday, December 20, 2023 12:58 PM
> To: Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com>;
> david.marchand@redhat.com; ktraynor@redhat.com; thomas@monjalon.net;
> konstantin.ananyev@huawei.com; konstantin.v.ananyev@yandex.ru;
> bruce.richardson@intel.com; maxime.coquelin@redhat.com;
> aconole@redhat.com; Yigit, Ferruh <Ferruh.Yigit@amd.com>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] config/x86: config support for AMD EPYC processors
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> > From: Sivaprasad Tummala [mailto:sivaprasad.tummala@amd.com]
> > Sent: Wednesday, 20 December 2023 08.11
> >
> > On x86 platforms, max lcores are limited to 128 by default.
> >
> > On AMD EPYC processors, this limit was adjusted for native builds in
> > the previous patch.
> > https://patches.dpdk.org/project/dpdk/patch/
> > 20230925151027.558546-1-sivaprasad.tummala@amd.com/
> >
> > As agreed earlier in mailing list, this patch adjusts the limit for
> > specific AMD EPYC target/cross builds.
> >
> > Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
> > ---
>
> [...]
>
> > + foreach m:epyc_zen_cores.keys()
> > + if m.contains(cpu_instruction_set)
> > + dpdk_conf.set('RTE_MAX_LCORE', epyc_zen_cores[m])
> > + break
>
> The indentation of "break" uses a mix of tab and spaces, and should be fixed.
Thanks for spotting this. Will fix this in v2.
>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] config/x86: config support for AMD EPYC processors
2023-12-20 7:10 [PATCH] config/x86: config support for AMD EPYC processors Sivaprasad Tummala
2023-12-20 7:27 ` Morten Brørup
@ 2023-12-21 5:11 ` Sivaprasad Tummala
2024-01-02 18:18 ` Konstantin Ananyev
1 sibling, 1 reply; 6+ messages in thread
From: Sivaprasad Tummala @ 2023-12-21 5:11 UTC (permalink / raw)
To: mb, david.marchand, ktraynor, thomas, konstantin.ananyev,
konstantin.v.ananyev, bruce.richardson, maxime.coquelin, aconole,
ferruh.yigit
Cc: dev
On x86 platforms, max lcores are limited to 128 by default.
On AMD EPYC processors, this limit was adjusted for native
builds in the previous patch.
https://patches.dpdk.org/project/dpdk/patch/
20230925151027.558546-1-sivaprasad.tummala@amd.com/
As agreed earlier in mailing list, this patch adjusts the limit
for specific AMD EPYC target/cross builds.
Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
---
config/x86/meson.build | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/config/x86/meson.build b/config/x86/meson.build
index 5355731cef..8087b9ae91 100644
--- a/config/x86/meson.build
+++ b/config/x86/meson.build
@@ -91,13 +91,21 @@ epyc_zen_cores = {
'__znver1__':128
}
-if get_option('platform') == 'native'
+cpu_instruction_set = get_option('cpu_instruction_set')
+if cpu_instruction_set == 'native'
foreach m:epyc_zen_cores.keys()
if cc.get_define(m, args: machine_args) != ''
dpdk_conf.set('RTE_MAX_LCORE', epyc_zen_cores[m])
break
endif
endforeach
+else
+ foreach m:epyc_zen_cores.keys()
+ if m.contains(cpu_instruction_set)
+ dpdk_conf.set('RTE_MAX_LCORE', epyc_zen_cores[m])
+ break
+ endif
+ endforeach
endif
dpdk_conf.set('RTE_MAX_NUMA_NODES', 32)
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v2] config/x86: config support for AMD EPYC processors
2023-12-21 5:11 ` [PATCH v2] " Sivaprasad Tummala
@ 2024-01-02 18:18 ` Konstantin Ananyev
2024-02-13 14:28 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Konstantin Ananyev @ 2024-01-02 18:18 UTC (permalink / raw)
To: Sivaprasad Tummala, mb, david.marchand, ktraynor, thomas,
konstantin.v.ananyev, bruce.richardson, maxime.coquelin, aconole,
ferruh.yigit
Cc: dev
> On x86 platforms, max lcores are limited to 128 by default.
>
> On AMD EPYC processors, this limit was adjusted for native
> builds in the previous patch.
> https://patches.dpdk.org/project/dpdk/patch/
> 20230925151027.558546-1-sivaprasad.tummala@amd.com/
>
> As agreed earlier in mailing list, this patch adjusts the limit
> for specific AMD EPYC target/cross builds.
>
> Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
> ---
> config/x86/meson.build | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/config/x86/meson.build b/config/x86/meson.build
> index 5355731cef..8087b9ae91 100644
> --- a/config/x86/meson.build
> +++ b/config/x86/meson.build
> @@ -91,13 +91,21 @@ epyc_zen_cores = {
> '__znver1__':128
> }
>
> -if get_option('platform') == 'native'
> +cpu_instruction_set = get_option('cpu_instruction_set')
> +if cpu_instruction_set == 'native'
> foreach m:epyc_zen_cores.keys()
> if cc.get_define(m, args: machine_args) != ''
> dpdk_conf.set('RTE_MAX_LCORE', epyc_zen_cores[m])
> break
> endif
> endforeach
> +else
> + foreach m:epyc_zen_cores.keys()
> + if m.contains(cpu_instruction_set)
> + dpdk_conf.set('RTE_MAX_LCORE', epyc_zen_cores[m])
> + break
> + endif
> + endforeach
> endif
>
> dpdk_conf.set('RTE_MAX_NUMA_NODES', 32)
> --
Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
> 2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] config/x86: config support for AMD EPYC processors
2024-01-02 18:18 ` Konstantin Ananyev
@ 2024-02-13 14:28 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2024-02-13 14:28 UTC (permalink / raw)
To: Sivaprasad Tummala, Konstantin Ananyev
Cc: mb, david.marchand, ktraynor, konstantin.v.ananyev,
bruce.richardson, maxime.coquelin, aconole, ferruh.yigit, dev
02/01/2024 19:18, Konstantin Ananyev:
>
> > On x86 platforms, max lcores are limited to 128 by default.
> >
> > On AMD EPYC processors, this limit was adjusted for native
> > builds in the previous patch.
> > https://patches.dpdk.org/project/dpdk/patch/
> > 20230925151027.558546-1-sivaprasad.tummala@amd.com/
> >
> > As agreed earlier in mailing list, this patch adjusts the limit
> > for specific AMD EPYC target/cross builds.
> >
> > Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
> > Acked-by: Morten Brørup <mb@smartsharesystems.com>
>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-02-13 14:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-20 7:10 [PATCH] config/x86: config support for AMD EPYC processors Sivaprasad Tummala
2023-12-20 7:27 ` Morten Brørup
2023-12-20 9:22 ` Tummala, Sivaprasad
2023-12-21 5:11 ` [PATCH v2] " Sivaprasad Tummala
2024-01-02 18:18 ` Konstantin Ananyev
2024-02-13 14:28 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).