From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35100A0521; Tue, 3 Nov 2020 16:56:01 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0746ECBDB; Tue, 3 Nov 2020 16:55:59 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 7E9CFCBAB for ; Tue, 3 Nov 2020 16:55:57 +0100 (CET) IronPort-SDR: VLjj3n5kpiL2dT5ZrMr8mVRQOVd6HVkZ0JTYx8KHgDteUE22yk42UkEq0mlP25ezQWBFMNmHEk g5cRbjzOCxuA== X-IronPort-AV: E=McAfee;i="6000,8403,9794"; a="156063915" X-IronPort-AV: E=Sophos;i="5.77,448,1596524400"; d="scan'208";a="156063915" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 07:55:42 -0800 IronPort-SDR: 4wGbljD2tG6hp9UrWeF6cj/qZ5sitaWBiS8Sr13+Aatu0wO5lix+lv16ZAw1vdavfPToWSS3J6 /DE+jq6P/VEw== X-IronPort-AV: E=Sophos;i="5.77,448,1596524400"; d="scan'208";a="538533629" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.218.178]) ([10.213.218.178]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 07:55:41 -0800 To: Andrew Boyer Cc: dev@dpdk.org, cardigliano@ntop.org References: <20201102183527.69209-1-aboyer@pensando.io> <20201102183527.69209-4-aboyer@pensando.io> <1852D797-1831-43D8-972D-81B0843F8880@pensando.io> From: Ferruh Yigit Message-ID: <535d3f46-168c-5e23-1bb9-d37223cdcd70@intel.com> Date: Tue, 3 Nov 2020 15:55:40 +0000 MIME-Version: 1.0 In-Reply-To: <1852D797-1831-43D8-972D-81B0843F8880@pensando.io> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 3/8] ionic: update ionic_if.h to the latest version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/3/2020 2:36 PM, Andrew Boyer wrote: > > >> On Nov 3, 2020, at 7:44 AM, Ferruh Yigit > > wrote: >> >> On 11/2/2020 6:35 PM, Andrew Boyer wrote: >>> This file contains the firmware interface definitions. >> >> Is the version number stored somewhere for documentation? >> > > No, it is controlled by our internal repository. > It can help you to have one somewhere in the repo (.h, text file, at worst in commit log). >>> Signed-off-by: Andrew Boyer> >>> --- >>>  drivers/net/ionic/ionic_if.h   | 1349 ++++++++++++++++++++++---------- >>>  drivers/net/ionic/ionic_regs.h |    3 - >>>  2 files changed, 933 insertions(+), 419 deletions(-) >>> diff --git a/drivers/net/ionic/ionic_if.h b/drivers/net/ionic/ionic_if.h >>> index f83c8711b..fe6b52b17 100644 >>> --- a/drivers/net/ionic/ionic_if.h >>> +++ b/drivers/net/ionic/ionic_if.h >>> @@ -1,17 +1,15 @@ >>> -/* SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB OR BSD-3-Clause */ >>> -/* Copyright (c) 2017-2019 Pensando Systems, Inc.  All rights reserved. */ >>> +/* SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB OR BSD-2-Clause */ >>> +/* Copyright (c) 2017-2020 Pensando Systems, Inc.  All rights reserved. */ >> >> This is changing the license, for any specific reason? > > Good catch... I am surprised to see the internal and external version of this > file have different licenses. (Well, technically different.) I’ll revert that part. > > -Andrew >