From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5194A0A02; Fri, 26 Mar 2021 10:28:45 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 70A9840685; Fri, 26 Mar 2021 10:28:45 +0100 (CET) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by mails.dpdk.org (Postfix) with ESMTP id 708984067B for ; Fri, 26 Mar 2021 10:28:44 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id E9016580D71; Fri, 26 Mar 2021 05:28:43 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 26 Mar 2021 05:28:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= 47hSOr9NKJei/FCJYbd+9fswwhL0SQqUPC8fLgvByJ8=; b=rkoN1bDZuYuMHLsL V7Qghzq62eTrc57ufqp/CFQTr68qBH8+IlaugjqH3F+aLvC3H8glssWpQJkVLGG2 vpXH8AnipdBC3/+Le+Ly5PlGv8uWBTxtxlX91GCCTWUfQx+z28GCUt+OHy38G17D XBhrKTfyjF0nGFKOcdSwkvXyVLkdggHYN3Ts3s9KNDk7PKWW6FEgDM/8QPe0Cb/m JeUnEnNHfF84UepxPstIXgGNzOn2iHU9cAyTaFkjs75z1WHWH0R5xwvp1wGNvMwF n6GBCwvKyqE2eWDn3gnXrv9EqH7g9uYFxESzesyT/ZeJla5h/HwytEJrHhjZG+ZH LvlWOw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=47hSOr9NKJei/FCJYbd+9fswwhL0SQqUPC8fLgvBy J8=; b=G8gqgPIr8H8H5bstsN0LgrXI8iQ2nHe72tVNaX7JM7u0lfg0cLupywQNJ 9dtkVkCVdF5PwrRoCBVBH6AW8sQHJ49EFKpegYLv/mfwkek4XDHTpFaI/ZZ/YlpM wdb6awqa/CdByk8FvaBdabvp+0OJbLJuVX7IFvqZxiV2nR2o9W8eJJfp6hb16/qb xQXQwI4A5YluTX8m6iwD9qcoylcsh2nAp5XkgFUcHvUv+Fq5II9piUntahFhF05x XkqirHiP4xtCoUJsEdpmhvjCNYSVyGSJnc/wFl2YePyyZkC/k79KJAwgWp/G41sv R8rlRUSfDCSeHNhEkV89/zv1k7mQg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudehvddgtdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepffdvffejueetleefieeludduuefgteejleevfeekjeefieegheet ffdvkeefgedunecuffhomhgrihhnpeguphgukhdrohhrghenucfkphepkedurddukeehrd duieehrddukedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (180.165.185.81.rev.sfr.net [81.185.165.180]) by mail.messagingengine.com (Postfix) with ESMTPA id 6AE01240054; Fri, 26 Mar 2021 05:28:40 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: dev@dpdk.org, Tyler Retzlaff , Jie Zhou , Ranjit Menon , Beilei Xing , Jeff Guo , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Olivier Matz Date: Fri, 26 Mar 2021 10:28:38 +0100 Message-ID: <5366968.186Eh59Hp8@thomas> In-Reply-To: <20210320130525.16452-6-dmitry.kozliuk@gmail.com> References: <20210320112733.13160-1-dmitry.kozliuk@gmail.com> <20210320130525.16452-1-dmitry.kozliuk@gmail.com> <20210320130525.16452-6-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 5/5] net: replace Windows networking shim X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/03/2021 14:05, Dmitry Kozlyuk: > Remove networking shim from Windows EAL. > > Replace it with system headers with two workarounds: > > 1. Windows Sockets headers contain `#define s_addr S_un.S_addr`, which > conflicts with `s_addr` field of `struct rte_ether_hdr`. Undefining > this macro in had been breaking some usages of DPDK > and Windows headers in one file. I don't understand this last sentence. > > Renaming is planned: > https://mails.dpdk.org/archives/dev/2021-March/201444.html > > Temporarily disable `s_addr` macro around `struct rte_ether_hdr` > definition to avoid conflict. Place source MAC address in both > `s_addr` and `S_un.S_addr` fields, so that access works either > directly or through the macro. It could be a patch in itself. > > 2. Provide some IPPROTO_* constants and IPVERSION, missing on Windows. I think it belongs to previous patch about extending the IP-related API. > --- a/drivers/net/i40e/i40e_fdir.c > +++ b/drivers/net/i40e/i40e_fdir.c > @@ -22,6 +22,7 @@ > #include > #include > #include > +#include Why is it needed? [...] > --- a/lib/librte_net/rte_ip.h > +++ b/lib/librte_net/rte_ip.h > @@ -17,11 +17,15 @@ > > #include > > +#ifdef RTE_EXEC_ENV_WINDOWS > +#include > +#else > #include > #include > #include > #include > #include > +#endif Should be in previous patch about extending IP API to any OS. > --- a/lib/librte_net/rte_net.c > +++ b/lib/librte_net/rte_net.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include Why is it needed?