From: Igor Ryzhov <iryzhov@arccn.ru>
To: Olivier MATZ <olivier.matz@6wind.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] RTE Ring removing
Date: Wed, 07 May 2014 16:42:44 +0400 [thread overview]
Message-ID: <536A2A44.1030801@arccn.ru> (raw)
In-Reply-To: <536A1B5C.2010201@6wind.com>
It seems to be a good idea, thank you, Olivier!
But a few questions:
1. Will this changes affect performance?
2. In PATCH 2/2 you have a small bug:
In file rte_ring.h, in comments describing rte_ring_init function you have:
+ * @param name
+ * The size of the ring.
But it is name of the ring, not size.
Best regards,
Igor Ryzhov
07.05.2014 15:39, Olivier MATZ пишет:
> Hi Igor,
>
> On 05/07/2014 09:54 AM, Igor Ryzhov wrote:
>> I noticed that in Memzone realization there is a special global variable
>> "free_memseg" containing pointers on free memory segments.
>> An memzone reserve function just finst the best segment for allocation
>> from this "free_memseg" variable.
>>
>> So I think there is a possibility to unreserve already reserved memory
>> back to "free_memseg", and impossibility of unreserving memory is just
>> because there is no function for that, not because it is impossible in
>> principle.
>> Am I right? Or there are any restrictions?
>
> I think that implementing a freeing of memory segment is feasible, but
> it would require some work to properly merge freed zones to avoid memory
> fragmentation.
>
> Another solution is to allocate/free rings in standard memory (malloc
> for instance) instead of rte_memzones. Let me know if the patches I've
> just sent on the mailing list solves your issue.
>
> By the way, I plan to do the same thing for mempools in the coming
> weeks but there is much more work.
>
> Regards,
> Olivier
>
next prev parent reply other threads:[~2014-05-07 12:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 9:05 Igor Ryzhov
2014-05-07 7:54 ` Igor Ryzhov
2014-05-07 11:39 ` Olivier MATZ
2014-05-07 12:42 ` Igor Ryzhov [this message]
2014-05-07 13:08 ` Olivier MATZ
2014-05-07 14:01 ` Venkatesan, Venky
2014-05-07 15:09 ` Olivier MATZ
2014-05-07 15:19 ` Ananyev, Konstantin
2014-05-07 15:37 ` Olivier MATZ
2014-05-07 15:36 ` Rogers, Gerald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536A2A44.1030801@arccn.ru \
--to=iryzhov@arccn.ru \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).