From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com [74.125.82.44])
 by dpdk.org (Postfix) with ESMTP id EB5F6595A
 for <dev@dpdk.org>; Wed,  7 May 2014 15:04:47 +0200 (CEST)
Received: by mail-wg0-f44.google.com with SMTP id a1so941645wgh.3
 for <dev@dpdk.org>; Wed, 07 May 2014 06:04:53 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to
 :subject:references:in-reply-to:content-type
 :content-transfer-encoding;
 bh=XUb9Zfox5F9ICUzVqnbu9oJ+lFuiVWF69l5YunT5ohA=;
 b=E6M08hF3MbH7oiHmvb5pikqki917sYqE8l7x52JgsZpMMr5M284pQPSStXMZ10MIBW
 fA0R9DNFF4wCxlEBDjNAllEcKC3p81bvNC03Fzn4tOaCexWSfYZjjz78GO1FRPSWBNob
 8oQj9SeokQjwK+BTD/h82FOcUCGBRrfa9Ie6feDMMQ58SWGdF8kytLVhhCAEBjJjr/6D
 rbcn3jmkd8I/bsn7yGv0ev1sHm19brYHmsI+telr9XsnGGrUe0nzjdwn/eK8J56HsEvV
 qRVAJMHeDrL/ogCr3YSmbCFyI1T3rnG0K+jyIZrIFx+RFHZ60Y72AmBVxHDhaXGlcbHv
 57SQ==
X-Gm-Message-State: ALoCoQlGGDNthJQRCaidtaW+phqR/huXXsW33jddUQWeP2E8ZmrRaBy08jwOACPuTLOWQ35AsTme
X-Received: by 10.194.93.234 with SMTP id cx10mr1725911wjb.39.1399467893544;
 Wed, 07 May 2014 06:04:53 -0700 (PDT)
Received: from [10.16.0.195] (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id cw2sm26509881wjb.39.2014.05.07.06.04.52
 for <multiple recipients>
 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Wed, 07 May 2014 06:04:52 -0700 (PDT)
Message-ID: <536A2F73.8040300@6wind.com>
Date: Wed, 07 May 2014 15:04:51 +0200
From: Olivier MATZ <olivier.matz@6wind.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:24.0) Gecko/20100101 Icedove/24.4.0
MIME-Version: 1.0
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, 
 "dev@dpdk.org" <dev@dpdk.org>
References: <1399462711-12815-1-git-send-email-olivier.matz@6wind.com>
 <1399462711-12815-2-git-send-email-olivier.matz@6wind.com>
 <2601191342CEEE43887BDE71AB9772580EFA3F27@IRSMSX105.ger.corp.intel.com>
In-Reply-To: <2601191342CEEE43887BDE71AB9772580EFA3F27@IRSMSX105.ger.corp.intel.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 1/2] ring: introduce rte_ring_get_memsize()
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 07 May 2014 13:04:48 -0000

Hi Konstantin,

On 05/07/2014 02:35 PM, Ananyev, Konstantin wrote:
> 1. ssize_t rte_ring_get_memsize(unsigned count)
>
> Can you use usual syntax for functions definitions in DPDK:
>
> ssize_t
> rte_ring_get_memsize(unsigned count)
>
> 2. sz = (sz + CACHE_LINE_MASK) & (~CACHE_LINE_MASK);
>
> Use RTE_ALIGN(sz, CACHE_LINE_SIZE) instead?

Thank you for reviewing. I'll include these 2 changes in
a patch-v2.

Regards,
Olivier