From: Olivier MATZ <olivier.matz@6wind.com>
To: Igor Ryzhov <iryzhov@arccn.ru>, dev@dpdk.org
Subject: Re: [dpdk-dev] RTE Ring removing
Date: Wed, 07 May 2014 15:08:10 +0200 [thread overview]
Message-ID: <536A303A.5040702@6wind.com> (raw)
In-Reply-To: <536A2A44.1030801@arccn.ru>
Hi Igor,
On 05/07/2014 02:42 PM, Igor Ryzhov wrote:
> But a few questions:
> 1. Will this changes affect performance?
It should not. If you have many rings, you may allocate them
in huge pages to avoid TLB misses.
> 2. In PATCH 2/2 you have a small bug:
>
> In file rte_ring.h, in comments describing rte_ring_init function you have:
>
> + * @param name
> + * The size of the ring.
>
> But it is name of the ring, not size.
Thank you for this comment, I'll fix it in the v2.
Regards,
Olivier
next prev parent reply other threads:[~2014-05-07 13:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 9:05 Igor Ryzhov
2014-05-07 7:54 ` Igor Ryzhov
2014-05-07 11:39 ` Olivier MATZ
2014-05-07 12:42 ` Igor Ryzhov
2014-05-07 13:08 ` Olivier MATZ [this message]
2014-05-07 14:01 ` Venkatesan, Venky
2014-05-07 15:09 ` Olivier MATZ
2014-05-07 15:19 ` Ananyev, Konstantin
2014-05-07 15:37 ` Olivier MATZ
2014-05-07 15:36 ` Rogers, Gerald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536A303A.5040702@6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=iryzhov@arccn.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).