From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com
 [209.85.212.181]) by dpdk.org (Postfix) with ESMTP id 248A6595A
 for <dev@dpdk.org>; Wed,  7 May 2014 15:08:08 +0200 (CEST)
Received: by mail-wi0-f181.google.com with SMTP id n15so1276805wiw.14
 for <dev@dpdk.org>; Wed, 07 May 2014 06:08:14 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to
 :subject:references:in-reply-to:content-type
 :content-transfer-encoding;
 bh=qBRR/4HP7mEBUyzzmhbqzzjw0QFEGTu0hqb+nnMulIw=;
 b=liz8E0+0+FUBqau460Vr3+NVHHKS91oW/HfAL4HAb/UqlOtC3sz6SnTgd7Y2R6XvhD
 4fI38dkl8BfU8aZ0K9cP2FZ7d5NqUMJ09ZFiEC64UcSt7m1W7XFVvKSCathYJzacZDK5
 mF2DgekRvJzHMTuvw2p+5KLthwM4uU92RMfMZTtPDs4wg22WVzvyD6YWW5aOVoGAZ4K9
 oe9PC+b55e3cxvGUmGJmrJhhkLmqsgRL+2cxV0IgMvF6MF1XI00Hz0F7Hz11hCR7XH4K
 ERDAT0hizo8TQXPVeOuBeBw6iyl64rdh8DsG9VCX7Zlb0w82QUTZBIQUP2Dq185Z29at
 1IDA==
X-Gm-Message-State: ALoCoQlXhERV0/VpXL1W/UdKH2HiltVyCYFVDURNPIg5PYkNKi0cmU2idK8+2dXlGlq2N2lGXT2e
X-Received: by 10.180.7.198 with SMTP id l6mr7793887wia.52.1399468094005;
 Wed, 07 May 2014 06:08:14 -0700 (PDT)
Received: from [10.16.0.195] (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id gd5sm2015734wjb.40.2014.05.07.06.08.11
 for <multiple recipients>
 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Wed, 07 May 2014 06:08:12 -0700 (PDT)
Message-ID: <536A303A.5040702@6wind.com>
Date: Wed, 07 May 2014 15:08:10 +0200
From: Olivier MATZ <olivier.matz@6wind.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:24.0) Gecko/20100101 Icedove/24.4.0
MIME-Version: 1.0
To: Igor Ryzhov <iryzhov@arccn.ru>, dev@dpdk.org
References: <5368A5E0.8090903@arccn.ru> <5369E6AF.4040402@arccn.ru>
 <536A1B5C.2010201@6wind.com> <536A2A44.1030801@arccn.ru>
In-Reply-To: <536A2A44.1030801@arccn.ru>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] RTE Ring removing
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 07 May 2014 13:08:08 -0000

Hi Igor,

On 05/07/2014 02:42 PM, Igor Ryzhov wrote:
> But a few questions:
> 1. Will this changes affect performance?

It should not. If you have many rings, you may allocate them
in huge pages to avoid TLB misses.

> 2. In PATCH 2/2 you have a small bug:
>
> In file rte_ring.h, in comments describing rte_ring_init function you have:
>
> + * @param name
> + *   The size of the ring.
>
> But it is name of the ring, not size.

Thank you for this comment, I'll fix it in the v2.

Regards,
Olivier