From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 7B810532D for ; Fri, 9 May 2014 23:49:55 +0200 (CEST) Received: from [82.228.133.41] (helo=[192.168.0.15]) by mail.droids-corp.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1WishW-0006QE-PX; Fri, 09 May 2014 23:51:43 +0200 Message-ID: <536D4D79.4080609@6wind.com> Date: Fri, 09 May 2014 23:49:45 +0200 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.4.0 MIME-Version: 1.0 To: Stephen Hemminger References: <1399647038-15095-1-git-send-email-olivier.matz@6wind.com> <20140509100431.7af69959@nehalam.linuxnetplumber.net> In-Reply-To: <20140509100431.7af69959@nehalam.linuxnetplumber.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH RFC 00/11] ixgbe/mbuf: add TSO support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 May 2014 21:49:56 -0000 Hi Stephen, On 05/09/2014 07:04 PM, Stephen Hemminger wrote: > I would also like to propose changing the checksum offload flags. > Many devices can indicate good checksum in some cases but can't test > for many other types of packets. By changing the flags to be: > PKT_RX_L4_CKSUM_GOOD and PKT_RX_IP_CKSUM_GOOD > > It is then possible to support devices where some cases (IPv4 + TCP) > are supported but others are not. I agree. That's also what I'm talking about in the commit log of the patch 08/11. If there is not much rework for all the patches, I think it's feasible to include this kind of modification in the v2 of this series. Regards, Olivier