From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22C7FA0C47; Wed, 3 Nov 2021 20:13:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DEF0240E5A; Wed, 3 Nov 2021 20:12:59 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id D749440E0F for ; Wed, 3 Nov 2021 20:12:58 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10157"; a="218767015" X-IronPort-AV: E=Sophos;i="5.87,206,1631602800"; d="scan'208";a="218767015" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2021 12:12:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,206,1631602800"; d="scan'208";a="729034917" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga006.fm.intel.com with ESMTP; 03 Nov 2021 12:12:56 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 3 Nov 2021 12:12:56 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 3 Nov 2021 12:12:55 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 3 Nov 2021 12:12:55 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.43) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 3 Nov 2021 12:12:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hYiIhO+yAnqUpeXICqNjz7ZfjCuh/2izKq23E5q6RWA6RVU2CWNjligWh4vgbymQOJ3nXcKu+1MxFXY3wRv5cWsMUsxOYO10a+Fs3Ayb05//fN0Ao2QKkPhi83NBnnZjLwfuGqEJROKFBk9axos4PwND7mtTUfdM3ek+IPkfI4ICslFF4K0FBn1YJXmvLaM4gu/5dBb6tX5kabAjFjnit6XsdC17tIPJYfwJDnqg/QzPgM/JmWW2Z/c+ueSZGWhe2VeLkGc76NBoLtHxcggonnwrTV+ZArcB74mp2bNrk05pMy2h8dyW8lLatEMD7Y84ww7PrLWHGocA8+r92bAYwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TIrWa8sYc960mRz1PucVPqieD7b4vBRzy98CWhI+eMs=; b=AfoFk00zUxJNErTxpXIXtQuHo/7C93UY7jZElGunVGGNWuoMXkhUyj/bBmIAbwX4+JOQJEoV65sRPN8M5JUTZFgA71NVpt4g8BJGm8fer4gM294Y+ge17Y2ZsGfyceeTOxG+45LpRJX+NcZ8gGS3wgLVH2PB5ZqmAQFE2m0W7p7NihiPwkUdW/2n0rUzXUwuTVKrefslvskAgDAATPGNM4jdkqy1XN3rsC45HmFGF3wVCaciaj6S2yVCpHnJor3+j9o4BnWS100UsRswItgwNBXEGo4/47iSfZN6XhD1C+Ak6X4uq3gxqLc6nDVPC0fluMaPZee9lbp86rBMiG2fyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TIrWa8sYc960mRz1PucVPqieD7b4vBRzy98CWhI+eMs=; b=jdtr1361rSTuGEANSWtm5RCe/7SfxUMg1dT2kReelAR4Zzqc0tb50okbldkrSvtqvtA8crSTAe//jMNjeRHlgghxXVEll/Q/Doobfr+sEvaApwUXyP3xalJqAmXSsuXmkApMfmkdVeuJfIBx1x3APq2x6r0xg709ESvx/nKuIAY= Authentication-Results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH7PR11MB5886.namprd11.prod.outlook.com (2603:10b6:510:135::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Wed, 3 Nov 2021 19:12:54 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%7]) with mapi id 15.20.4669.011; Wed, 3 Nov 2021 19:12:54 +0000 Message-ID: <53762631-743c-0d11-0693-47e4ec6b67e4@intel.com> Date: Wed, 3 Nov 2021 19:12:47 +0000 Content-Language: en-US To: Gregory Etelson , Ori Kam CC: , , Xiaoyun Li , Viacheslav Ovsiienko , , Thomas Monjalon , David Marchand References: <20211026152000.11665-1-getelson@nvidia.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211026152000.11665-1-getelson@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0393.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:f::21) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by LO2P265CA0393.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10 via Frontend Transport; Wed, 3 Nov 2021 19:12:52 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 04489b1d-d9f3-4907-ad48-08d99efdefeb X-MS-TrafficTypeDiagnostic: PH7PR11MB5886: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UQB+XoRtmRbc9tat6eLzlszSCWnUb08gp82Kbr/Y/qHyn2RdYN1p9Qx5k44ghn6OvySiaZUe73CisLTJjl64DMQMBrwz2QY6+5mmzpT1jevgluWsE+osMZS9I4g2b5AXNHjAt0zQZFWda+bau9NEBzFoM8jRbG0P5EbNdZScd3RDpSFjhvxO5m8ellzGw5NVe22ILR4LRchfGOucVuRYQdT/J5fG82nZoDRz+RuxUdQUj3cbAjhoj+io9z1fakL7gs9hm8QGotL0EDXSschhMIzQVDvpBC4YXEkvWTHNPmTus/HzaCOuNaqQgSxAG7BZU7I5JduVpPpC85Kj85jsX6wWM7XDLOq4k+Iw+1mpL6ypwVG14xEP/67e4L0Mpg1bBG+GKse4VO9Xn26k7Jf/MRGSH5iGPZBNW1E+EXjnHoGi3m5O3fKMe4NXMAd6Uc87Qcfmh6ZoWnayIKrM9juGleR6dWfQomOJBE5B0QdSeizZpRWxu4d1PrWaawFF6ho39pMkv6ClmMJoixNgNU+mlilT9CSgDbfOUUJ9QYpsVM9Ns4fSIK6aF7L3QcpSspdJztXQAJQEyX/FW6gMCxjUcwVKlWauSqhAPNRXLg3IjcsgYX6c1EFB1mdb+f4QNjb9B+YR4+ajh8eQGBDvgr+3WxL7QMMo8K94pqMSv3BrS2SA8pihC4bvgkrhGIq9K/mhfyth6iFhpnhBwE+xFAHUhw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(38100700002)(8936002)(66556008)(31696002)(5660300002)(66476007)(8676002)(6486002)(31686004)(186003)(26005)(66946007)(53546011)(2906002)(86362001)(54906003)(508600001)(16576012)(316002)(4326008)(44832011)(6666004)(2616005)(956004)(36756003)(83380400001)(110136005)(82960400001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N0lZQmtWU0M1Z2lGdlRPTE9CRlpkMWFCNVRveDRwdHh6Nkd3Tk1WVUwxWjNZ?= =?utf-8?B?cmhjMGJwRjUrN0JqY0toZkZSU2ZWamRsYXY4eE9kemNaUjJVU2FJV29KVnZs?= =?utf-8?B?cnA0ays0N0Q0RzRGRTVybWpCQWtGV1VFTjZmc2FHUXk3YTNvTGJ5dGJtbys2?= =?utf-8?B?bjgwUGRwYmE0VzZJaG9CbDlNYlBHMUFXd0EyTXgyNDE0ZFFBVmplOUM5Q0sx?= =?utf-8?B?VTFSZnhuY3NYTzVQS2Nqa0x4NUNZd2M1dmFLYXFUaXdqNjhqeGE4NlZ3Z2dl?= =?utf-8?B?ZFZ3QjFiRWpDM0JiRGljbVMzNS85NEFsalczdENTa2ZHUm5kS0F0b29hZ3RF?= =?utf-8?B?dXI1MjNOdjhUM0xHNFJ4aWhaOUFrZndNUVNEbFR6S1htZlhlckMyblQrRWw3?= =?utf-8?B?RDl0TEptdWtlL3B6VFZSMmQ4VnpnSkk0RmYyMkdLTThDSWNPYVNBcUhXVXZC?= =?utf-8?B?UFRZTWpzYTVKVk9PSjA2OC9veGRBeEowaHg2QVNYK3d1akx2S0RrY21hVXVa?= =?utf-8?B?WUQ4ZVdvVFd0TFNxSmZmUUE0YW1tU2ZFekhRNzVLbGtWeXR0eWRYenlma0lK?= =?utf-8?B?dTdnaVVDc1g2UEJCMERUT0p2MUo2VXhiOUlZL09YV3I4RTNqSHZ1U1EzS1B0?= =?utf-8?B?Uk5qQVVsbWx2K0tOUHozNUZFWWp0Z3JiMTl6TUF5emVNOG5SZzVMaGlOTVds?= =?utf-8?B?TmpJZXFyUVdDNzJNRmZaNEpTSFIwODRmK0Q2eG9vR3pQLzFxMkxxWG9qUGRS?= =?utf-8?B?cTg1NVJ5cjV5M0Q1RW5RaFQzTzNJU2k0STN6dHhMK1lndWk2TGZ5T2JYdm5B?= =?utf-8?B?MDZzVWRSTVhBekhCTDV1R1NmbUVNWjd0WldkR1dHeHNBOHo4WU5yUDd2cVBm?= =?utf-8?B?MS8rVVU0SFZkeWNIazZRQjBFSlNSNGZGNzNpbGNOcDdaMkJJZzNDMWVyWk5w?= =?utf-8?B?WUdiTU42MUVIR0ZGSXNxQnN2MmdZMjJUUVVyTEphbGdYVXVpSlcybnZSMjRj?= =?utf-8?B?Z0RTTjhTTzZoNEtsSTFpR3YxS1RSM3ZyZ2NTRzNpUm5UMnBvbEQ1UG93dW5k?= =?utf-8?B?c1ZRYnZKUHBtbnFiNzhLQzRNS1lYWXl6MEphQk0xenEwQ0NxVjhBWXNZV04x?= =?utf-8?B?SkhzSUZOOGFxK2RsRlVSbGNPNFNhb0xZRVVVdHkxekRRekVNbVcwWXV5U01k?= =?utf-8?B?b2FVbDB1Rnh4RWV0RFErbFZYV2hlb3ZPczEyNENuUy9lY2FPQy8yODZ6cDRD?= =?utf-8?B?VVAwcHE1eWZNT0IzRkc3Wjk2Qis2SHRFa0tSMVZXeHI0MGFMcG9JM3lQeldk?= =?utf-8?B?dTFWVk9zNHpKSWRTQU82OVlubHZTUzBGek50SzB2cEZoVXlZaFVyb2tiWWpI?= =?utf-8?B?cVh1bGxWZEdveGVOV1RLOHJTaFNhcGpEbHNFOWFvVzhmNFR1WmlFd2lQYUNv?= =?utf-8?B?S0I3VG1kOFJKM2NDUXdPV1hMZmF2NXd0Qm5jUG5QcW1TRHdDenZVd05ybkFN?= =?utf-8?B?UmNqeTg4REpjVG4xZjRIRW0wY0lPQ2JqMGJ6ZjVPNjRNUVd0azBGNTgzenFC?= =?utf-8?B?amlXQVhiRkpJN3R0UkI4NHZ4SVdacU1rT3JIL1pJQTdKblBCMGZVK0dNLzFo?= =?utf-8?B?MnJ1bDV1Ny9WWTRCUGxMUkdGeXdlanlEeHA0WHRUekRDT3BLMEU1QVp4bVBx?= =?utf-8?B?T1VUcHhCSExRMTBESXZSb2xBdlZYOWNWQk95aDd6T0hGRnRSUkdJSU5KM0du?= =?utf-8?B?S053SGpkMnJqU1VEKzBwZzJvWStpYWJPQWJkN0lYWDZEc3JpVDJ4TjZPN0g4?= =?utf-8?B?OUdxZC9XazFRaDA0d00zdU16WUtmdkZTT0M5WTltYkU3bnRCbFBpV2ovcWZ0?= =?utf-8?B?ZzF2eC93MGJaYXg2bnF2b2Z5VWkxWEZvRjI0SXJpTURZZVhhV0hZQjUxd1NM?= =?utf-8?B?WlJ6NzlmdCtZYzdDVWlwMkRMOEZoNjJwMnBTR2lRSTZVVVN6SXFVWjZjTUxL?= =?utf-8?B?RGdUL1lFd3g0L3hRQWRNVkhnbWU3Vzd2bDNxaksxdCt2VTlDQTNHQWZCOUNY?= =?utf-8?B?RXRRanJPT0daYjBwR2xQSG9VbzYxQU94Qkx0OFIyOXdaOXFmSTZsTnBTRmhM?= =?utf-8?B?YkgwV3hDTFArSy84eDFTbWpqcHI3UHJOVk5xeThhMStzVG5yS0xqSXNKOFFx?= =?utf-8?Q?j1lL0uQY5v/5xvYJEHoERUs=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 04489b1d-d9f3-4907-ad48-08d99efdefeb X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2021 19:12:54.1757 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: q8TE0uDbCOgeQZtX8+X5iJHBPjkixyo0X8HDTCOeuzY8TlmNUqpg41T54TeQscNdi0PF3v12yRbN/L4t6KDw+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5886 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix flex item flush X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/26/2021 4:20 PM, Gregory Etelson wrote: > Testpmd provides 2 sets of flex item create and destroy functions > One for hosts with JSON library. These functions parse > flex item configuration stored in JSON file and create or destroy > flex item object. The second functions set is for hosts without JSON > library for compilation compatibility. > > On hosts without JSON library, current implementation issues > "no JSON library" notification on port close. > The notification was triggered by port destructors that include > flex items flush routine. > > The patch introduces single implementation for testpmd > flex item destroy. > > Fixes: 59f3a8acbcdb ("app/testpmd: add flex item commands") > Signed-off-by: Gregory Etelson > --- > app/test-pmd/cmd_flex_item.c | 72 ++++++++++++++++++------------------ Hi Gregory, Ori, I just recognized that 'cmd_flex_item.c' doesn't have an explicit maintainer, which makes it fallback to Xialyoun, but I don't think that is related to existing coverage. Since the file is related to rte_flow and only user of it (also author of it) is nvidia, can one of you take the maintainership of the file? It is easier to add it to 'Flow API' block in MAINTAINERS file, that Ori already is the maintainer, if that suits. And perhaps, if you guys are OK, Gregory can be added to 'Flow API' too, it is good to have multiple maintainers. Thanks, ferruh