From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from USCAMAIL.TILERA.COM (uscamail.tilera.com [12.218.212.166]) by dpdk.org (Postfix) with ESMTP id 7BDBDB0C6 for ; Fri, 16 May 2014 18:51:29 +0200 (CEST) Received: from [10.107.0.247] (10.109.0.23) by USCAEXCH2.tad.internal.tilera.com (10.103.0.33) with Microsoft SMTP Server id 14.3.181.6; Fri, 16 May 2014 09:51:36 -0700 Message-ID: <5376430A.8010707@tilera.com> Date: Fri, 16 May 2014 09:55:38 -0700 From: Cyril Chemparathy User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Thomas Monjalon References: <1396546216-29200-1-git-send-email-cchemparathy@tilera.com> <2296399.R20Tya40om@xps13> In-Reply-To: <2296399.R20Tya40om@xps13> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.109.0.23] Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/6] Extensions to test-pmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 May 2014 16:51:29 -0000 On 5/16/2014 7:22 AM, Thomas Monjalon wrote: > Hi Cyril, > > 2014-04-03 10:30, Cyril Chemparathy: >> This patch series contains a few minor extensions to test-pmd. These >> changes have been added primarily for convenience while testing out various >> scenarios with DPDK. >> >> Cyril Chemparathy (6): >> test-pmd: add support for single port loopback topology >> test-pmd: add support for auto-start when interactive >> test-pmd: allow command line selection of forwarding mode >> test-pmd: allow txpkts to be setup via command line >> test-pmd: add mac swap forwarding mode >> test-pmd: add flowgen forwarding engine > Thanks for these new features. > > This is not the first time a new engine is added by copy/pasting the most part > of an existing engine. For instance, the "mac-retry" engine was added by Intel > as a copy/paste of the original "mac" one. > This is acceptable but not the perfect way to implement engines. > To address this issue, a new engine function could be introduced to setup some > parameters to be used by "packet_fwd" function. This way, similar engines > could be removed. Agreed that it sucks to incessantly replicate code. Maybe some of the packet_fwd code is common enough to bump into run_pkt_fwd_on_lcore()? Most of these forwarding modes have similar looking code to receive/transmit bursts and free the failed remnants of the burst. Could this common code be bumped up into run_pkt_fwd_on_lcore() maybe? > Acked-by: Thomas Monjalon > > Applied for version 1.7.0. Thanks! Much appreciated. -- Cyril.