From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 708981B437 for ; Thu, 22 Nov 2018 15:02:37 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id EC7BB212C8; Thu, 22 Nov 2018 09:02:36 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 22 Nov 2018 09:02:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=SUig/+a+3CCs+8ScFCL5ZHljw5sxTA98ziQHIb8ouQU=; b=VeeftbXvq4Yb YcyipSt0LUgbG1eO+YkFA5RLOybHprBiyezMmn2B2aZ/YAZcNT0S8ryaU1+SFf+m knaWi6IPAaus/ZRmeWp91X6QdU2lHNerr81Qgk5ZdHqoFFcdJLLa+fXa5EX/OtKG mzRtTeQVIquq0QK3iCCApwoc7TzwMdg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=SUig/+a+3CCs+8ScFCL5ZHljw5sxTA98ziQHIb8ou QU=; b=Hgdqe2AlDNA7uOK7NduLczzBEbQsLi6wtjFmRJvqZ18lEkSPhpTlKaC97 CHsQ3CE6K4AUnEU71razX6dV0R82uMRo74KmnBEtZzhLPzCfKny788m4ZOZcYrH+ iAueI06F/CGXPMEDXxoV+eRDtWRwolZMLfQodYad9B62eXJ0M37DFPg++S86ghqO V5SpSKKVA1az4+xi56orJQZsbztGI1/7+yA9LFXjSSFZ7ajeqEoC4rck4qXDp3+j +FyBBqryHucfqHE99F/OT+cHTxnCHRqm+IpDrbLr6hNFZtFSkGvYSBPditJ/64b8 W0dTCRheKrzMkCKV8DVJNJlSILjGw== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (68.16.136.77.rev.sfr.net [77.136.16.68]) by mail.messagingengine.com (Postfix) with ESMTPA id 82FA7102EE; Thu, 22 Nov 2018 09:02:33 -0500 (EST) From: Thomas Monjalon To: Olivier Matz Cc: dev@dpdk.org, anatoly.burakov@intel.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com, gaetan.rivet@6wind.com Date: Thu, 22 Nov 2018 15:02:28 +0100 Message-ID: <5377378.MItyz4mTKp@xps> In-Reply-To: <20181122132212.brq3ifximbtu5c5d@platinum> References: <20181121154545.14261-1-thomas@monjalon.net> <20181122103223.22837-1-thomas@monjalon.net> <20181122132212.brq3ifximbtu5c5d@platinum> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] doc: announce kvargs API change X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Nov 2018 14:02:37 -0000 22/11/2018 14:22, Olivier Matz: > On Thu, Nov 22, 2018 at 11:32:23AM +0100, Thomas Monjalon wrote: > > After processing a kvlist in rte_kvargs_process(), > > it may be needed to loop again over kvlist in order to know > > whether the key is matched or not. > > In order to simplify implementation of kvargs checks, > > a new pointer parameter may be used to get the match count. > > > > The change of the function prototype would be as below: > > > > int > > rte_kvargs_process(const struct rte_kvargs *kvlist, > > const char *key_match, > > + int *match_count, > > arg_handler_t handler, > > void *opaque_arg) > > > > Signed-off-by: Thomas Monjalon > > Maybe "unsigned int" instead of "int". Yes we will discuss such detail during review of the code patch. > Apart from this, > Acked-by: Olivier Matz Thanks I will consider the deprecation notice as approved when there will be 3 acks.