From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id EECC658F4 for ; Mon, 26 May 2014 16:27:07 +0200 (CEST) Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214] helo=[192.168.0.10]) by mail.droids-corp.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Wovte-0001gm-Gs; Mon, 26 May 2014 16:29:08 +0200 Message-ID: <53834F51.4070703@6wind.com> Date: Mon, 26 May 2014 16:27:29 +0200 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.4.0 MIME-Version: 1.0 To: Cristian Dumitrescu , dev@dpdk.org References: <1400858484-2402-1-git-send-email-cristian.dumitrescu@intel.com> <537F6A02.3020106@6wind.com> In-Reply-To: <537F6A02.3020106@6wind.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] cmdline: finish at EOF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 May 2014 14:27:08 -0000 Hi Cristian, On 05/23/2014 05:32 PM, Olivier MATZ wrote: > On 05/23/2014 05:21 PM, Cristian Dumitrescu wrote: >> Bug fix in cmdline library to allow return on EOF as opposed to >> infinite loop. >> >> Signed-off-by: Cristian Dumitrescu >> --- >> lib/librte_cmdline/cmdline.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> mode change 100644 => 100755 lib/librte_cmdline/cmdline.c > > Acked-by: Olivier Matz By the way, I just noticed that this bug had already been fixed into my cmdline project onto my personal website some time ago: http://git.droids-corp.org/?p=libcmdline.git;a=commitdiff;h=52e1d5772d1f465a013e65b8ae6e43a027438ed6 Regards, Olivier