[dpdk-dev] [PATCH] cmdline: finish at EOF

[dpdk-dev] [PATCH] cmdline: finish at EOF

[Cristian Dumitrescu]

Bug fix in cmdline library to allow return on EOF as opposed to infinite loop.

Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
 lib/librte_cmdline/cmdline.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
 mode change 100644 => 100755 lib/librte_cmdline/cmdline.c

diff --git a/lib/librte_cmdline/cmdline.c b/lib/librte_cmdline/cmdline.c
old mode 100644
new mode 100755
index 03a3fac..b3dc17c
--- a/lib/librte_cmdline/cmdline.c
+++ b/lib/librte_cmdline/cmdline.c
@@ -256,7 +256,7 @@ cmdline_interact(struct cmdline *cl)
 
 	c = -1;
 	while (1) {
-		if (read(cl->s_in, &c, 1) < 0)
+		if (read(cl->s_in, &c, 1) <= 0)
 			break;
 		if (cmdline_in(cl, &c, 1) < 0)
 			break;
-- 
1.7.7.6

Re: [dpdk-dev] [PATCH] cmdline: finish at EOF

[Olivier MATZ]

Hi Cristian,

On 05/23/2014 05:21 PM, Cristian Dumitrescu wrote:
> Bug fix in cmdline library to allow return on EOF as opposed to infinite loop.
>
> Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> ---
>   lib/librte_cmdline/cmdline.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>   mode change 100644 => 100755 lib/librte_cmdline/cmdline.c

Acked-by: Olivier Matz <olivier.matz@6wind.com>

Re: [dpdk-dev] [PATCH] cmdline: finish at EOF

[Olivier MATZ]

Hi Cristian,

On 05/23/2014 05:32 PM, Olivier MATZ wrote:
> On 05/23/2014 05:21 PM, Cristian Dumitrescu wrote:
>> Bug fix in cmdline library to allow return on EOF as opposed to
>> infinite loop.
>>
>> Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>> ---
>>   lib/librte_cmdline/cmdline.c |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>   mode change 100644 => 100755 lib/librte_cmdline/cmdline.c
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>

By the way, I just noticed that this bug had already been fixed into
my cmdline project onto my personal website some time ago:
http://git.droids-corp.org/?p=libcmdline.git;a=commitdiff;h=52e1d5772d1f465a013e65b8ae6e43a027438ed6

Regards,
Olivier

Re: [dpdk-dev] [PATCH] cmdline: finish at EOF

[Dumitrescu, Cristian]

Hi Olivier,

Great, so then maybe we should plan for an update of the DPDK command line library to your latest code base.

Are the code changes massive, i.e. would this be a big task?

Thanks,
Cristian

-----Original Message-----
From: Olivier MATZ [mailto:olivier.matz@6wind.com] 
Sent: Monday, May 26, 2014 3:27 PM
To: Dumitrescu, Cristian; dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] cmdline: finish at EOF

Hi Cristian,

On 05/23/2014 05:32 PM, Olivier MATZ wrote:
> On 05/23/2014 05:21 PM, Cristian Dumitrescu wrote:
>> Bug fix in cmdline library to allow return on EOF as opposed to
>> infinite loop.
>>
>> Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>> ---
>>   lib/librte_cmdline/cmdline.c |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>   mode change 100644 => 100755 lib/librte_cmdline/cmdline.c
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>

By the way, I just noticed that this bug had already been fixed into
my cmdline project onto my personal website some time ago:
http://git.droids-corp.org/?p=libcmdline.git;a=commitdiff;h=52e1d5772d1f465a013e65b8ae6e43a027438ed6

Regards,
Olivier
--------------------------------------------------------------
Intel Shannon Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263
Business address: Dromore House, East Park, Shannon, Co. Clare

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

Re: [dpdk-dev] [PATCH] cmdline: finish at EOF

[Olivier MATZ]

Hi Christian,

On 05/27/2014 08:38 PM, Dumitrescu, Cristian wrote:
> Great, so then maybe we should plan for an update of the DPDK command line library to your latest code base.
>
> Are the code changes massive, i.e. would this be a big task?

There have been some reworks, but it is not a major merge. It will
require some few ones to be done carefully such as:

http://git.droids-corp.org/?p=libcmdline.git;a=commit;h=f32d30f48ddfb55b86efd695e0dd144e9d15401e

In order to ease the merge, it can be started from commit 090c2ba0d6b.
Since cmdline is quite isolated in dpdk, it should be manageable.

Currently, I do not get time to do such merge. But I'll be pleased
review patches that update it.

Regards,
Olivier

Re: [dpdk-dev] [PATCH] cmdline: finish at EOF

[Thomas Monjalon]

> > Bug fix in cmdline library to allow return on EOF as opposed to infinite
> > loop.
> > 
> > Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> 
> Acked-by: Olivier Matz <olivier.matz@6wind.com>

Applied for version 1.7.0 with title:
	cmdline: fix infinite loop after EOF

Thanks
-- 
Thomas