DPDK patches and discussions
 help / color / mirror / Atom feed
From: Shannon Zhao <zhaoshenglong@huawei.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] cpu_layout.py: adjust output format to align
Date: Thu, 29 May 2014 15:48:18 +0800	[thread overview]
Message-ID: <5386E642.10805@huawei.com> (raw)
In-Reply-To: <2140757.fj3Ic02JMu@xps13>

Hi Thomas,

Thanks for your advice.
I'll modify the patch and send it as 'patch v3' later.

On 2014/5/29 15:22, Thomas Monjalon wrote:
> Hi Shannon,
> 
> I feel this version is better but it's really complicated to read.
> 
>> +max_processor_len=len(str(len(cores)*len(sockets)*2-1))
>> +max_core_map_len = max_processor_len*2+4
>> +if max_core_map_len < 12:
>> +        max_core_map_len = 12
> 
> This line is not indented as the other ones.
> 
>> +max_core_id_len=len(str(max(cores)))
>> +
>> +print " ".ljust(max_core_id_len+5),
>>  for s in sockets:
>> -	print "\tSocket %s" % s,
>> +	print "Socket %s" % str(s).ljust(max_core_map_len-7),
>>  print ""
>> +print " ".ljust(max_core_id_len+5),
> 
> Could you replace all these numbers by something meaningful and easier to 
> understand?
> Example: 5 can be replaced by len('Core ')
> 
> Other comment: please add spaces around operators (= + - *).
> 
> Thanks
> 

-- 
Shannon

  reply	other threads:[~2014-05-29  7:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-29  6:24 Shannon Zhao
2014-05-29  7:22 ` Thomas Monjalon
2014-05-29  7:48   ` Shannon Zhao [this message]
2014-06-18  4:18   ` [dpdk-dev] [PATCH v3] " Shannon Zhao
2014-06-18 18:17     ` De Lara Guarch, Pablo
2014-06-18 23:03       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5386E642.10805@huawei.com \
    --to=zhaoshenglong@huawei.com \
    --cc=dev@dpdk.org \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).