From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f178.google.com (mail-we0-f178.google.com [74.125.82.178]) by dpdk.org (Postfix) with ESMTP id 3F776678C for ; Wed, 28 May 2014 00:32:35 +0200 (CEST) Received: by mail-we0-f178.google.com with SMTP id u56so10188073wes.37 for ; Tue, 27 May 2014 15:32:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=xcK/kbmeUBqCS/c+Bjlgz+yLq4NpYVniDp0fiKjuDWI=; b=PflYOyy53xXMW+XYLQ8miKMiCuJHXqkwz5keWr8HCJKBPnTn95qBdCoKqN1SImDedq mCq9frxu++8B3ya2IRzWlXwSoahiRHx+Sg917m95d+L1cPtz4g3XL+ujSCkZszQXr9FU 1km4QnzmG7ucITKXtcHdFXe6iFxf4UsAc1Djgfbk2hIj1ddnng7tq6Dr0UZHjFqOJJ9i WDDxJ19tJSrqlaWpOdkreOqa2lAW98WIs7LZLXFMjH3l9jv5xjaGYAuAmLtsiv6O7lB9 7Gsd6ao+GMJYC18Vivf542uTX+8R84REwgsS/YgaVI3Sh0DLuL+K50S7Aq12fzab7sEO 57UA== X-Gm-Message-State: ALoCoQn5UwAD4lXYlm/cVDwBRsS/ckNm2A6rh0OnHauvTf5L+pP3vT49temjg6UdnIDT3gao9Zmz X-Received: by 10.180.187.111 with SMTP id fr15mr42003637wic.57.1401229966084; Tue, 27 May 2014 15:32:46 -0700 (PDT) Received: from xps13.localnet (ip-96.net-80-236-123.rev.numericable.fr. [80.236.123.96]) by mx.google.com with ESMTPSA id dk10sm7657268wib.1.2014.05.27.15.32.44 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 May 2014 15:32:45 -0700 (PDT) From: Thomas Monjalon To: Bruce Richardson Date: Wed, 28 May 2014 00:32:42 +0200 Message-ID: <5389412.OPcvyX8cEM@xps13> Organization: 6WIND User-Agent: KMail/4.13 (Linux/3.14.4-1-ARCH; KDE/4.13.0; x86_64; ; ) In-Reply-To: <1400580057-30155-1-git-send-email-bruce.richardson@intel.com> References: <1400580057-30155-1-git-send-email-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/4] New library: rte_distributor X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 May 2014 22:32:35 -0000 Hi Bruce, As for rte_acl, I have some formatting comments. 2014-05-20 11:00, Bruce Richardson: > This adds a new library to the Intel DPDK whereby a set of packets can be > distributed one-at-a-time to a set of worker cores, with dynamic load > balancing being done between those workers. Flows are identified by a tag > within the mbuf (currently the RSS hash field, 32-bit value), which is used > to ensure that no two packets of the same flow are processed in parallel, > thereby preserving ordering. > > app/test/Makefile | 2 + > app/test/commands.c | 7 +- > app/test/test.h | 2 + > app/test/test_distributor.c | 582 +++++++++++++++++++++++++ > app/test/test_distributor_perf.c | 274 ++++++++++++ > config/defconfig_i686-default-linuxapp-gcc | 5 + > config/defconfig_i686-default-linuxapp-icc | 5 + > config/defconfig_x86_64-default-bsdapp-gcc | 6 + > config/defconfig_x86_64-default-linuxapp-gcc | 5 + > config/defconfig_x86_64-default-linuxapp-icc | 5 + > lib/Makefile | 1 + > lib/librte_distributor/Makefile | 50 +++ > lib/librte_distributor/rte_distributor.c | 417 ++++++++++++++++++ > lib/librte_distributor/rte_distributor.h | 173 ++++++++ > lib/librte_eal/common/include/rte_tailq_elem.h | 2 + > mk/rte.app.mk | 4 + > 16 files changed, 1539 insertions(+), 1 deletion(-) As you are introducing a new library, you need to update doxygen configuration and start page: doc/doxy-api.conf doc/doxy-api-index.md I've run checkpatch.pl from kernel.org on these distributor patches and it reports some code style issues. Could you have a look at it please? Thanks -- Thomas