From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id B898E6848 for ; Mon, 2 Jun 2014 09:39:29 +0200 (CEST) Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214] helo=[192.168.0.10]) by mail.droids-corp.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1WrMs8-0007JU-NJ; Mon, 02 Jun 2014 09:41:35 +0200 Message-ID: <538C2A59.2060501@6wind.com> Date: Mon, 02 Jun 2014 09:40:09 +0200 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.4.0 MIME-Version: 1.0 To: Thomas Monjalon References: <1401195316-31149-1-git-send-email-thomas.monjalon@6wind.com> <5385CCE8.6030501@6wind.com> <2352405.jTgRhv3zRV@xps13> In-Reply-To: <2352405.jTgRhv3zRV@xps13> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] mk: fix link with gcc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jun 2014 07:39:29 -0000 Hi Thomas, On 05/29/2014 08:48 AM, Thomas Monjalon wrote: > You're right, title should be: > mk: fix 32-bit link with gcc > > And I should add some details in the commit log: > > I didn't see any error with -z muldefs but it isn't documented in gcc manual. > So it's safer to explicitly pass it to the linker. > > The variable CPU_LDFLAGS contains "-melf_i386" in 32-bit configurations. So > building 32-bit shared library raises this error: > gcc: error: unrecognized command line option ‘-melf_i386’ > > Olivier, I'll make these changes if you (or Neil) ack the patch. Acked-by: Olivier Matz