From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0043.outbound.protection.outlook.com [104.47.37.43]) by dpdk.org (Postfix) with ESMTP id 4E31DF04; Fri, 24 Nov 2017 10:34:02 +0100 (CET) Received: from CY4PR03CA0011.namprd03.prod.outlook.com (2603:10b6:903:33::21) by SN2PR03MB2365.namprd03.prod.outlook.com (2603:10b6:804:e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.260.4; Fri, 24 Nov 2017 09:33:58 +0000 Received: from BN1BFFO11FD046.protection.gbl (2a01:111:f400:7c10::1:156) by CY4PR03CA0011.outlook.office365.com (2603:10b6:903:33::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.260.4 via Frontend Transport; Fri, 24 Nov 2017 09:33:58 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1BFFO11FD046.mail.protection.outlook.com (10.58.145.1) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.218.12 via Frontend Transport; Fri, 24 Nov 2017 09:33:57 +0000 Received: from [10.232.134.49] ([10.232.134.49]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id vAO9XrXL021228; Fri, 24 Nov 2017 02:33:54 -0700 To: Nelio Laranjeiro , Declan Doherty CC: , Gaetan Rivet , References: <1c3b73f0912ad4b3da8423590dc76fc83df16b80.1511338151.git.nelio.laranjeiro@6wind.com> <5ed1354d41a6370faa8887a6f3acd1e20ef09668.1511431327.git.nelio.laranjeiro@6wind.com> From: Akhil Goyal Message-ID: <538dcacd-8d64-66b8-56dc-21339d1e8188@nxp.com> Date: Fri, 24 Nov 2017 15:03:52 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <5ed1354d41a6370faa8887a6f3acd1e20ef09668.1511431327.git.nelio.laranjeiro@6wind.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131559896378761306; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(346002)(39860400002)(376002)(39380400002)(2980300002)(1109001)(1110001)(339900001)(199003)(189002)(24454002)(81166006)(77096006)(2906002)(53936002)(81156014)(33646002)(65826007)(2950100002)(230700001)(53546010)(83506002)(356003)(64126003)(65956001)(305945005)(8676002)(5660300001)(498600001)(97736004)(47776003)(8936002)(50466002)(65806001)(104016004)(86362001)(15650500001)(58126008)(105606002)(5890100001)(54906003)(106466001)(110136005)(316002)(68736007)(229853002)(575784001)(4326008)(2486003)(189998001)(23676004)(67846002)(36756003)(50986999)(85426001)(54356999)(6246003)(76176999)(31686004)(31696002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR03MB2365; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD046; 1:xjXdfiZZswB1tavHWGC6+j+QMeEf2tfCeLvOiClbxcjjjWxTcKZHK4yA1a9VYECnU+sxqXa2M164dJuQn6LjNG8/u8WMOsG6nHmIufi5Sj3TClZod0AHHKZWvyYdgPJn X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4628075)(201703131517081)(2017052603258); SRVR:SN2PR03MB2365; X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2365; 3:raDiNnDt992putKdzTz+y+iPZn1qA+hk+5ADNZgGoEFwLt4qvcIFlrEGK+HB/epYvRbwLyjoIOSY8cqBvOwSoc3iqXA1cAsw+RComTUDz8nlqCTeA+I3TLwP4ajl0p/kvC63XOwjJj2nJdDrG3ZCLRXJ5dDl4jA4VPjkjfZFj/+1oRVRyBkmBjXJWotjyVADkTunduKezfQx0k0V/bbZlFcBUV3GJ5Ils0yXQHDv/3gdCXKxFTHWfc5Vi+34XrK3LDp7OBvWqYKXoZ8wBtiRe6VlFwkvsgbxuLxnFpGIcaMlx7cCSJY8QXLdoqadYIhUotmECKSoheH+cDdd4GVpgx83A/4hTQDataGZXpkCL5s=; 25:ErrdJhN2QQQBaJnc9EfBYzXfM/eCUpmcLDg1xkUAZN+aBJWEWcw7Krad/srL+y1/dmjNgP7r5pI8lgeTRUA0lar2AOUC0aLbc56MNd61o2P/MpCk3MxI3Ag4wtr46z/Vm71lSj+zFy0DabFQU3oyNly7xxzsywH0J40BYkIpch2ReSML3+26mOfulc/O7lC45QfsKZsSMtqopRCiGuoLz4UTjMZ7Ueh2x5VEL1Or0pdoQcMrSxarZawzeWofwzRA9szRnftOu451YhDyvXLBYrGXldRQMw2Tffsl0ps9PksDWYs6Y3z5CAHOj5rrACXZIByTJaVuRqfXTUEroRFeFQ== X-MS-TrafficTypeDiagnostic: SN2PR03MB2365: X-MS-Office365-Filtering-Correlation-Id: afe647b8-7cbd-4a4d-7efb-08d5331e7ccc X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2365; 31:f3WsJNV5ZyRwKThKh/Z4kYy9FPre1UXT+I2LICSqWu1HQtzpYAe7DGNudAEB5UCM5SaH63qeT6NXn6UntgCoqNaEUyWf1/hsyeCF+vQ8C/EAEOZ4Ti2KnbnywWwtoZrYxZ6Ssk8XuiDR8qGtw0O7cUgPOIkrjN+1+55VD9YB7K+FyM/2ZA9Oby3i5l9/6YIt+mSNqSOFsfBnma0JpaJvFI6S1emAFesh0aJO/CGvOTA=; 4:fkGWqXODeXRbkNH3RksF2r2w4kFPnMLI4bbGxKf7mL6cKyoGbBjAkGT/E1DUo1R1T+skNglEDm87P7/LoVV1EzzNIsTdk/mwmD3QUNBWVcD/S3LLfrTWzg9tOlZxJNH4LonhmkQpUuIZMcBDBF5e6SmSobC3XeXMXHR42jP/eCrmhayJ0li/9ixnHzcuMx/uGT2VzWVQO6v9dZa6UaalnY/j/n1P3x9seinCXTBQw12MK8lis/sQVPNUbiwMnBcBhL2gWSBiK9sUyH/o52slgInchu4VCewo9NDmw+NiC16bLuht4IlaR+t4UZK91DBWYg26TSZgaGFXjKkaPrb9Yy0slJQ7OYTOovwfazXKnkI= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192374486261705)(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(2401047)(5005006)(8121501046)(3231022)(10201501046)(3002001)(93006095)(93001095)(6055026)(6096035)(20161123563025)(201703131430075)(201703131433075)(201703131448075)(201703161259150)(201703151042153)(20161123565025)(20161123559100)(20161123561025)(20161123556025)(201708071742011); SRVR:SN2PR03MB2365; BCL:0; PCL:0; RULEID:(100000803101)(100110400095)(400006); SRVR:SN2PR03MB2365; X-Forefront-PRVS: 05015EB482 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjJQUjAzTUIyMzY1OzIzOnl3NHVMTjN3eEh3cU9rRjhSN25TWUZnRmNy?= =?utf-8?B?SVNTaG1MN2p1OGxZb3VYTXdSNWJWeU1HUDk1Ym9qNVMwSW56TGIxNFBHUXZT?= =?utf-8?B?S2s1YWZDSVhRV05LSGtZa2c2L2I3MEdRTTZtVlE0cHRkVGsvcWxsTGVVVEUx?= =?utf-8?B?MG5sTkxtY0tyaWQzRG9rNU5KbTQzbURKNjJraTl2YTl0K1JnQU55NWNuajM0?= =?utf-8?B?WHF5QnJqdlFZMGhHWDh3RkNDblprTFZGV1hQMUl6OERGV2d4RHBmSldSRlJw?= =?utf-8?B?T3NzSGIvYVZQcTdVVnlqQm5KUWNUQjA2Tlh0MGdDV0xzS1FrNldzdW1OZ1VT?= =?utf-8?B?aDBwM3ZKdm55VXhGK3kwZEJ3a0tLdjV0OWozRnFKelJ4K3FsbUJzSWM2YjI3?= =?utf-8?B?a2dDRVE5ZFUwbCtaQjZhRzZwK2V0L25nWitxVUdRenAyS01qbjJKUkpjdklQ?= =?utf-8?B?TFZTcnk0Z091K2gxZlo3VzJ1SnY1YTFRdXFiUXlFV1dIa1RZR3FPMlgwbmZL?= =?utf-8?B?a2VpN05IRDNKbVpUcFJZM3dtYmNJdkJEcDdsT3BxNjJyancrN2QrU3pKNnds?= =?utf-8?B?VXBPZmlLazR1Z3A1elhmckRMbmNRZTViSEVUSDFRYnRhZlluOUlNWXNxTWE2?= =?utf-8?B?VDNLRXllZTVCdnU5Vm1mN3VkcEtmazJzRmhVaGloMXNZU2pZQUNRa0h5MVN0?= =?utf-8?B?aXF1UFk5ajgwMm9PblhXckNjSnl5NWJKTjhYdkE2RFgzd0x6eVlWZmJobm9R?= =?utf-8?B?ZFZqRlJjSFNPNjM1LzNQM1F6eDJhZURzMG5JeXlCMmF0NjE0RnNTeVR2SkNS?= =?utf-8?B?ZWtFWDhLNWY1VExqV1V0cEx4ODVxMXRqRXlNQTViKzNPbXlTODByc3dlTFdR?= =?utf-8?B?V0dmVjVOMjUwc21QaTVGTEoxeHQzUmREenBpVVMzTkxFOW1yc1BqZUtScGs5?= =?utf-8?B?ck8wbnpTVFlBWjZPeFA1WW9kaWhFbXA2bTFmTjFRdEZoeGoxc24xV1pyUjdK?= =?utf-8?B?V0FNT2V6VVdKcFQwQjNWd2orbXNHNCtXeG41Q1JwZy9KeE5KbEpnOWQyVHNJ?= =?utf-8?B?MnorSmJMWkFJUUFEWXNTaWR3VGRzbGhoamtGYldKNGtTMVV2b1NpamZDVzB0?= =?utf-8?B?VWZMNDVvWXJLODBRRFAvMHo4ek9xUWZoYkhVeHZrMG1LTEZLMldQK3lUaWhK?= =?utf-8?B?aURzNldkM3lsWWhUaU1qVXhQcUJVeGdDeVZlZEtwcUJtSzgvWmFUWmZVTlJ3?= =?utf-8?B?YnZMbUJ6TFhlWkhVLytLTTVMMUV0ZHRhQ0Z0ZWJZU2g2RVJYaUJTdkJGRkNk?= =?utf-8?B?OG9Xc0RDL0tPd2NCV1BKbHNDQUFIcSt5MlJRNjdGRVNqZXUwb0FEdXBLenNS?= =?utf-8?B?azlNemRXR2tQR1BSdWYxb29KZ0lqckxGQzgwellkb01ROURyVk91VnRHUk81?= =?utf-8?B?OUhWR2F3ZTNWaHR1U09LNk1laTdXS21LUWhSaUNRQUJyL2JieGlkem5yZEUw?= =?utf-8?B?RDgzWGNkYW9XY1ZYOE9SalZ5UmMyL3B4Mys5MnZpRW85Q0RnRW5scitsTFQw?= =?utf-8?B?ZmVYZEE1RHoyQUI4WlNiRTN4RkM5Y2Jad0QxQ3U2Z3RWa29tSWFkM1lReFha?= =?utf-8?B?OGtkSEVkT0l0cG5aVVVCeFpIVnVxc3N5ZjE0RE9pai84VStMSkFKelZaeUhp?= =?utf-8?B?V3l2bTV1M0ZKdU5wNUtpMkZkbmRaTTk1VVkwM29DdG1WMDlWenBsUzhDRE1M?= =?utf-8?B?bHlHQmJlUk43eW1mZE91Wkwwa3kvZThBTTZabW9VWmN0V0RXUFZ5R0swOFp1?= =?utf-8?B?dEFtRXlBaWdSZlpFMnc2U0tGaEFGT2hoYTQyMmdkVE9DVzlSeE5tbHVmZzBh?= =?utf-8?B?SGpUNmxES1ZTTUdzWmtuQ0Z6N285M0x0eDd3Z3ZYa0VNNjNHdFYxTXJDbmZR?= =?utf-8?B?RW1FRUhWdzdZYUFoWnROQzRjbXhtQW5ZMFdwaHhtZkZmeDRUNzY5RWlLaUpT?= =?utf-8?Q?Ep9Oj6?= X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2365; 6:pE3XnTXkcmvbfyogSHDgDbl+F6Jy6YA4MoYCpTk+j/yjwA3Cwj7GQKBg0/jWWZAHzSXP9/jqk3nUrMTIzmUTM2ZFEUL9/qGhCAE8jieblFMDo3q2cUejOOXhiwzUPdJR77m8Z10cPcEBydsvMftVHVTkKH8z8amijrOsjnrQpsrkLBfiVcJr+5lft3EDajVLrcyffmwovw3da4zFO9EwPoVxOtXjqM7IrmId7OIJYvB+IxX2N1jeEXz6jFYU6KIP+M6kemWNqf8MZXewF56ytKNb5/91INPCg4yKmDgIQ5NzOhknQHNZ/xnOWtBOOXWzVklqRYQmDYOiDksaX6EiS4rnpj/mV9RXZlzoSsAV7AU=; 5:gxCD7YQD4H6zvnnkgrsnOxNVXQkpV8i2dQtjku2sewzH6HyUtF4AdaBGu17SV2gJtQA9pgsqFIxlPfKnyUcmOGHEaG4j1LKn3A1mS84N6yST5Cf280WowfZJ/4CVlCdKxd6FUssfRNJwWP8J3xeEqNuJdPkh1Tr8C6RDpJFz7HY=; 24:VVNuqdY2un+MQyS+s69J1aY5YP8dUVGCYhTXk/5L2lOZzdkWSjMnUS51lRfo6jt9/k9PrgY3jhS2E+D9Y7o0IaQvERo/g5V7ZupjKOAuZ1s=; 7:7oezLcJrCkOe+Vf76zcxHQX2JyiZDOWzfDGBbXlHjGd2AW0iTLN+nEsko7Y9boBSLJU3LdVBltbEFrD86t7IZAfPFKbjRtthWPNegIQGUNrPrvIhu1sdFDmdjp1lXenkWgl7+zDkVg3mBHXGDgAPNxgvIwetfpDBw40SjswlN9vJkHcuQMgKOktpXUPwjH3Ts9rVcCKuvnzkvTXwApfcKx3jgZHXpErl3Ks7DpN75fpaT3IEaeEw6R5XCJ1sa24l SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2017 09:33:57.4549 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: afe647b8-7cbd-4a4d-7efb-08d5331e7ccc X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2365 Subject: Re: [dpdk-dev] [PATCH v2 1/3] security: fix device operation type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Nov 2017 09:34:02 -0000 Hi Nelio, On 11/23/2017 3:32 PM, Nelio Laranjeiro wrote: > Device operation pointers should be constant to avoid any modification > while it is in use. > > Fixes: c261d1431bd8 ("security: introduce security API and framework") > Cc: akhil.goyal@nxp.com > Cc: stable@dpdk.org > > Signed-off-by: Nelio Laranjeiro > --- > lib/librte_security/rte_security.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_security/rte_security.h b/lib/librte_security/rte_security.h > index aa3a471a3..679c0a696 100644 > --- a/lib/librte_security/rte_security.h > +++ b/lib/librte_security/rte_security.h > @@ -94,7 +94,7 @@ enum rte_security_ipsec_tunnel_type { > struct rte_security_ctx { > void *device; > /**< Crypto/ethernet device attached */ > - struct rte_security_ops *ops; > + const struct rte_security_ops *ops; Do we require this change for crypto ops as well. > /**< Pointer to security ops for the device */ > uint16_t sess_cnt; > /**< Number of sessions attached to this context */ >