From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 449687F14 for <dev@dpdk.org>; Thu, 31 Mar 2016 15:40:54 +0200 (CEST) Received: by mail-wm0-f45.google.com with SMTP id 127so134792302wmu.1 for <dev@dpdk.org>; Thu, 31 Mar 2016 06:40:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=R5ok+AnXL4pnfljorGk+Tb29IeuFCaOI2KgJgp9Gx6k=; b=SctDa5KtAHYO7ptcggu8KCF7/3dsFk9yYNZ2XP+VaIgUKplIV3COGCLBqZIeqV0E78 LGffU8PHHbk9j/NPp0eRZ9kP0D5c9AZ1Ib/vsEXYsPQNegMiJZoQD+HMHujmkqyaTC28 g3/yz17US2fwdPMEXndsI1MjyWVHLQuYg+8rV4puvQgtBzes3sH2w1RjJKiPpDWuIoKy P5D1+XVXfgQGWakHA1T6hQqMMiCseJo2loiqdD0yl6aBUw6BtXMkp2lRJQz+zhMohknd VExosu6gbRFK4o8hQgYReOLUotI61g+zLrcpMpflzNh9pYMXfa62bH06Hd6aWdUkdxWA POTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=R5ok+AnXL4pnfljorGk+Tb29IeuFCaOI2KgJgp9Gx6k=; b=fz8ws1Mlw0DGpU00BaWFwxtnJbkV6ei3JefABmk/5KF11VBDRwU7rAmFAKgU/mVrkK PllPClHGm/ETL6Ie6GDG7It8g4yg2OYXF8kojKsYlRKuGhlO9+YIMuYC+Al1laLXP5cy uKzjbmLY6lXGQCM03wXhEinnOb/s8BbWjiy4KqKiRmHS4TwMjoeQdlYV3oKNjZyLeRiG +LS87ma7Idta/pY71V8k2jY9OTIRok7pLpAbRoDlcqAofWc2Uu9MM/Jb0aJNPbi4vrp1 hoWblTki3j90ixjFryaB1Y3XjX2uQxqIebQXbZ/u7Yy0E8+l71TGmpHA+ezoEgQwwaqx q15g== X-Gm-Message-State: AD7BkJJgYI0LfiSo782aRWX5fg6Bfy4dxRl1AM1VNjK2z/SFA5DXf3D+MELf7MWxHUOMShDS X-Received: by 10.194.57.100 with SMTP id h4mr15716464wjq.18.1459431654071; Thu, 31 Mar 2016 06:40:54 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id h7sm24895877wmf.9.2016.03.31.06.40.53 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 31 Mar 2016 06:40:53 -0700 (PDT) Date: Thu, 31 Mar 2016 06:40:53 -0700 (PDT) X-Google-Original-Date: Thu, 31 Mar 2016 15:39 +0200 From: Thomas Monjalon <thomas.monjalon@6wind.com> To: John Daley <johndale@cisco.com>, Nelson Escobar <neescoba@cisco.com> Cc: dev@dpdk.org Message-ID: <5397245.3TK0dfaEoQ@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1458953090-12764-1-git-send-email-johndale@cisco.com> References: <1458953090-12764-1-git-send-email-johndale@cisco.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] bonding: fix bond link detect in non-interrupt mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 31 Mar 2016 13:40:54 -0000 2016-03-25 17:44, John Daley: > From: Nelson Escobar <neescoba@cisco.com> > > Stopping then re-starting a bond interface containing slaves that > used polling for link detection caused the bond to think all slave > links were down and inactive. > > Move the start of the polling for link from slave_add() to > bond_ethdev_start() and in bond_ethdev_stop() make sure we clear > the last_link_status of the slaves. > > Signed-off-by: Nelson Escobar <neescoba@cisco.com> > Signed-off-by: John Daley <johndale@cisco.com> A "Fixes:" line would be appreciated to know the origin of the bug. Thanks