From: Olivier MATZ <olivier.matz@6wind.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] mk: allow updates to build config on make install
Date: Tue, 10 Jun 2014 18:02:44 +0200 [thread overview]
Message-ID: <53972C24.1040305@6wind.com> (raw)
In-Reply-To: <1402408293-19426-1-git-send-email-thomas.monjalon@6wind.com>
Hi Thomas,
On 06/10/2014 03:51 PM, Thomas Monjalon wrote:
> + if [ -f $(BUILD_DIR)/$*/.config.orig ] ; then \
> + tmp_build=/tmp/dpdk-$*-$$$$; \
> + $(MAKE) config T=$* O=$$(tmp_build); \
> + if ! cmp -s $(BUILD_DIR)/$*/.config.orig $$(tmp_build)/.config ; then \
> + echo "Conflict: local config and template config have both changed"; \
> + exit 1; \
I missed it the first time, but what do you think about using
$(BUILD_DIR)/$*/.config.tmp instead of /tmp/dpdk-$*-$$ ?
I think using /tmp should be avoided when possible as it is a
shared folder.
Regards,
Olivier
next prev parent reply other threads:[~2014-06-10 16:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 10:22 [dpdk-dev] [PATCH] " Bruce Richardson
2014-05-14 10:33 ` Thomas Monjalon
2014-05-14 10:51 ` Richardson, Bruce
2014-05-14 11:55 ` Thomas Monjalon
2014-05-14 12:33 ` Richardson, Bruce
2014-05-14 12:54 ` Thomas Monjalon
2014-05-14 12:57 ` Richardson, Bruce
2014-05-14 15:55 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
2014-05-20 11:37 ` Olivier MATZ
2014-06-10 13:51 ` [dpdk-dev] [PATCH v3] " Thomas Monjalon
2014-06-10 16:02 ` Olivier MATZ [this message]
2014-06-10 16:29 ` Richardson, Bruce
2014-06-10 16:38 ` [dpdk-dev] [PATCH v4] " Thomas Monjalon
2014-06-10 18:43 ` Richardson, Bruce
2014-06-11 9:54 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53972C24.1040305@6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).