From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com
 [209.85.212.178]) by dpdk.org (Postfix) with ESMTP id C1475B0C2
 for <dev@dpdk.org>; Tue, 10 Jun 2014 18:02:34 +0200 (CEST)
Received: by mail-wi0-f178.google.com with SMTP id n15so3355206wiw.5
 for <dev@dpdk.org>; Tue, 10 Jun 2014 09:02:48 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to
 :subject:references:in-reply-to:content-type
 :content-transfer-encoding;
 bh=wHa/6TcmJEGJ9pZ4mLfmMDAtCXHTfUx/PMbCMg3/VI8=;
 b=T1+vAJA+qdqUfDyWKv8aT+ef62FIZb+tiOVW/nP4PtAKhyVeVgd4eriI2EjqdJRVH6
 ERTbjOqyyZ6Zg5s1NM5rPWFy1sPEVJzF/KZoMQESsH2tcaDoRX3zhK0C3C35+/3DIZsc
 lQ45lxmuKmt+iv9XWJUIl0qYbNN86QT9F/s50WhPRCPZtOnA+GAsj5A1toEZtzISwnR7
 FGWazQADqbzqAvjN4oB66MeckScSM+KmztADq9bum1VygiqyoJu9oV3YNvwpK6uzvQGq
 EZNJyYa2LxXPJiJdb5Yz29byVWkMkmhBdvzI9HZoLHNgq76cWGPGi7Kl+qZaL1IY/hUn
 fiYg==
X-Gm-Message-State: ALoCoQncvAO4YSq+HyS6pde+2rHrh+vg8RB1+KmBatPTl/Bmh/VsPpZSmnslrDaM+T19pLKphzxA
X-Received: by 10.180.84.7 with SMTP id u7mr30734035wiy.31.1402416167159;
 Tue, 10 Jun 2014 09:02:47 -0700 (PDT)
Received: from [10.16.0.195] (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id nb8sm21654765wic.18.2014.06.10.09.02.45
 for <multiple recipients>
 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Tue, 10 Jun 2014 09:02:46 -0700 (PDT)
Message-ID: <53972C24.1040305@6wind.com>
Date: Tue, 10 Jun 2014 18:02:44 +0200
From: Olivier MATZ <olivier.matz@6wind.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:24.0) Gecko/20100101 Icedove/24.4.0
MIME-Version: 1.0
To: Thomas Monjalon <thomas.monjalon@6wind.com>, dev@dpdk.org
References: <537B3E91.4030400@6wind.com>
 <1402408293-19426-1-git-send-email-thomas.monjalon@6wind.com>
In-Reply-To: <1402408293-19426-1-git-send-email-thomas.monjalon@6wind.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v3] mk: allow updates to build config on make
 install
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Jun 2014 16:02:35 -0000

Hi Thomas,

On 06/10/2014 03:51 PM, Thomas Monjalon wrote:
> +		if [ -f $(BUILD_DIR)/$*/.config.orig ] ; then \
> +			tmp_build=/tmp/dpdk-$*-$$$$; \
> +			$(MAKE) config T=$* O=$$(tmp_build); \
> +			if ! cmp -s $(BUILD_DIR)/$*/.config.orig $$(tmp_build)/.config ; then \
> +				echo "Conflict: local config and template config have both changed"; \
> +				exit 1; \

I missed it the first time, but what do you think about using
$(BUILD_DIR)/$*/.config.tmp instead of /tmp/dpdk-$*-$$ ?
I think using /tmp should be avoided when possible as it is a
shared folder.

Regards,
Olivier