From: David Marchand <david.marchand@6wind.com>
To: "Liu, Jijiang" <jijiang.liu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 2/7] ethdev: add autoneg parameter in flow ctrl accessors
Date: Mon, 23 Jun 2014 11:26:46 +0200 [thread overview]
Message-ID: <53A7F2D6.50803@6wind.com> (raw)
In-Reply-To: <1ED644BD7E0A5F4091CF203DAFB8E4CC01D3B9A6@SHSMSX101.ccr.corp.intel.com>
Hello,
On 06/23/2014 05:35 AM, Liu, Jijiang wrote:
> There was an error when we used the following test command to test latest master branch for 10G NIC flow control
> test command:
> ./x86_64-native-linuxapp-gcc/app/testpmd -c f -n 4-- -i --burst=1 --txpt=32 --txht=8 --txwt=0 --txfreet=0 --rxfreet=64 --mbcache=250 --portmask=f
> testpmd> set flow_ctrl rx off tx off 300 50 10 1 mac_ctrl_frame_fwd on 0
> bad flow contrl parameter, return code = -95
>
> And the reason is that autoneg check failed in ixgbe_flow_ctrl_set() function.
> if (fc_conf->autoneg != !hw->fc.disable_fc_autoneg)
> return -ENOTSUP;
Ok, indeed, there is a problem with the autoneg field I added.
I will try to send a fix, but I am a bit short on time (and I will be
offline for a week starting thursday), so if you have a fix before me,
feel free to send it.
--
David Marchand
next prev parent reply other threads:[~2014-06-23 9:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 18:09 [dpdk-dev] [PATCH v3 0/7] add mtu and flow control handlers David Marchand
2014-06-17 18:09 ` [dpdk-dev] [PATCH v3 1/7] ethdev: retrieve flow control configuration David Marchand
2014-06-17 18:09 ` [dpdk-dev] [PATCH v3 2/7] ethdev: add autoneg parameter in flow ctrl accessors David Marchand
2014-06-23 3:35 ` Liu, Jijiang
2014-06-23 9:26 ` David Marchand [this message]
2014-06-17 18:09 ` [dpdk-dev] [PATCH v3 3/7] ethdev: store min rx buffer size David Marchand
2014-06-17 18:09 ` [dpdk-dev] [PATCH v3 4/7] ethdev: introduce enable_scatter rx mode David Marchand
2014-06-17 18:09 ` [dpdk-dev] [PATCH v3 5/7] ethdev: add mtu accessors David Marchand
2014-06-17 18:09 ` [dpdk-dev] [PATCH v3 6/7] ixgbe: add set_mtu to ixgbevf David Marchand
2014-06-17 18:09 ` [dpdk-dev] [PATCH v3 7/7] app/testpmd: allow to configure mtu David Marchand
2014-06-17 22:30 ` [dpdk-dev] [PATCH v3 0/7] add mtu and flow control handlers Ananyev, Konstantin
2014-06-17 22:59 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A7F2D6.50803@6wind.com \
--to=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=jijiang.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).