From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 19D685922 for ; Fri, 27 Jun 2014 14:32:55 +0200 (CEST) Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214] helo=[192.168.0.10]) by mail.droids-corp.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1X0VN5-0003vT-2Z; Fri, 27 Jun 2014 14:35:17 +0200 Message-ID: <53AD64D3.9000100@6wind.com> Date: Fri, 27 Jun 2014 14:34:27 +0200 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.4.0 MIME-Version: 1.0 To: "De Lara Guarch, Pablo" , "dev@dpdk.org" References: <1403867097-18848-1-git-send-email-pablox.de.lara.guarch@intel.com> <53AD55BB.8090807@6wind.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] string: fix potential seg fault on snprintf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jun 2014 12:32:55 -0000 Hi Pablo, On 06/27/2014 02:13 PM, De Lara Guarch, Pablo wrote: > With last Thomas' patch, cmdline unit test does not pass due to this problem (basically it tests this situation). > After test passed, by fixing this issue in several functions, I looked for other places where this happened. Indeed I missed the unit test, thanks. I think that testing the NULL case is not required. To me, it is like testing snprintf(NULL, ...) Regards, Olivier