From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailer1.neclab.eu (mailer1.neclab.eu [195.37.70.40]) by dpdk.org (Postfix) with ESMTP id CE393594D for ; Wed, 23 Jul 2014 14:04:10 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mailer1.neclab.eu (Postfix) with ESMTP id 10F941077D0; Wed, 23 Jul 2014 14:05:34 +0200 (CEST) X-Virus-Scanned: Amavisd on Debian GNU/Linux (netlab.nec.de) Received: from mailer1.neclab.eu ([127.0.0.1]) by localhost (atlas-a.office.hd [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nhnoYU8pBdci; Wed, 23 Jul 2014 14:05:33 +0200 (CEST) X-ENC: Last-Hop-TLS-encrypted X-ENC: Last-Hop-TLS-encrypted Received: from METHONE.office.hd (methone.office.hd [192.168.24.54]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mailer1.neclab.eu (Postfix) with ESMTPS id E5ED61077C7; Wed, 23 Jul 2014 14:05:18 +0200 (CEST) Received: from [10.1.2.203] (10.1.2.203) by skoll.office.hd (192.168.125.11) with Microsoft SMTP Server (TLS) id 14.1.323.3; Wed, 23 Jul 2014 14:05:18 +0200 Message-ID: <53CFA4FD.1060108@neclab.eu> Date: Wed, 23 Jul 2014 14:05:17 +0200 From: Simon Kuenzer Organization: NEC Laboratories Europe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Thomas Monjalon , Hiroshi Shimamoto References: <1404808110-16314-1-git-send-email-simon.kuenzer@neclab.eu> <10116389.N4VFaZKECM@xps13> <7F861DC0615E0C47A872E6F3C5FCDDBD011625D2@BPXM14GP.gisp.nec.co.jp> <3356411.EsFcTdggfg@xps13> In-Reply-To: <3356411.EsFcTdggfg@xps13> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.1.2.203] Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] eal/linuxapp: Add parameter to specify master lcore id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2014 12:04:11 -0000 On 23.07.2014 11:04, Thomas Monjalon wrote: > 2014-07-23 08:53, Hiroshi Shimamoto: >> 2014-07-23 09:50, Thomas Monjalon: >>> 2014-07-22 23:40, Hiroshi Shimamoto: >>>> does anyone have interest in this functionality? >>>> >>>> I think this is important and useful. >>>> Since we should care about core assignment to get high performance >>>> and the master lcore thread is special in DPDK, we will want to >>>> assign the master to the target core. >>>> For example, with hyperthreading I'd like to make a pair of packet >>>> processing threads into one physical core and separate the master >>>> thread which does some management. >>> >>> Thank you for showing your interest. >>> Does it mean you carefully reviewed this patch? In this case, I'd appreciate >>> a note "Reviewed-by:". >> >> Not yet deeply, wait a bit, we're testing this patch in our application. >> Will report if it works fine. >> >> By the way, we should add the same code into the BSD code, right? > > Right. > I'd prefer to reduce the duplicated footprint and have more common code > between BSD and Linux. But waiting this enhancement, we have to maintain > the duplicated code for BSD. > Hi all, I can provide the same patch also for BSD. However, I do not have a machine to test it. Interested? Thanks, Simon