From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by dpdk.org (Postfix) with ESMTP id 46FC8ADBE for ; Wed, 30 Jul 2014 21:05:26 +0200 (CEST) Received: from azsmga001.ch.intel.com ([10.2.17.19]) by azsmga101.ch.intel.com with ESMTP; 30 Jul 2014 12:07:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,766,1400050800"; d="scan'208";a="463288741" Received: from venky-cp-ivb2.jf.intel.com (HELO [134.134.172.59]) ([134.134.172.59]) by azsmga001.ch.intel.com with ESMTP; 30 Jul 2014 12:06:53 -0700 Message-ID: <53D9418A.5020308@intel.com> Date: Wed, 30 Jul 2014 12:03:38 -0700 From: Venky Venkatesan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: dev@dpdk.org References: <1406665466-29654-1-git-send-email-nhorman@tuxdriver.com> <1406731769-18523-1-git-send-email-nhorman@tuxdriver.com> In-Reply-To: <1406731769-18523-1-git-send-email-nhorman@tuxdriver.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 0/2] dpdk: Allow for dynamic enablement of some isolated features X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jul 2014 19:05:26 -0000 Neil, > Hey all- > I've been trying to update the fedora dpdk package to support VFIO > enabled drivers and ran into a problem in which ixgbe didn't compile because the > rxtx_vec code uses sse4.2 instruction intrinsics, which aren't supported in the > default config I have. I tried to remedy this by replacing the intrinsics with > the __builtin macros, but it was pointed out (correctly), that this doesn't work > properly. So this is my second attempt, which I actually like a bit better. I > noted that code that uses intrinsics (ixgbe and the acl library), don't need to > have those instructions turned on build-wide. Rather, we can just enable the > instructions in the specific code we want to build with support for that, and > test for instruction support dynamically at run time. This allows me to build > the dpdk for a generic platform, but in such a way that some optimizations can > be used if the executing cpu supports them at run time. > > Change notes: > > v2) > * Added Log messages to run time check failures per Konstantin > * Removed run time check caching in acl per Konstantin > > Signed-off-by: Neil Horman > CC: Thomas Monjalon > One possible change to look at - the _mm_shuffle_epi8 is something that is available all the way from SSSE3, so you should be able to leave that in. The SSE4.2 dependency is only for the popcount (and __builtin_popcountll will work for that anyway). That should make things simpler. -Venky