Re: [dpdk-dev] [PATCH v5 3/3] net/tap: add queues when attaching from secondary process

["Wiles, Keith" <keith.wiles@intel.com>]

> On Oct 10, 2018, at 2:03 AM, Raslan Darawsheh <rasland@mellanox.com> wrote:
> 
> In the case the device is created by the primary process,
> the secondary must request some file descriptors to attach the queues.
> The file descriptors are shared via IPC Unix socket.
> 
> Thanks to the IPC synchronization, the secondary process
> is now able to do Rx/Tx on a TAP created by the primary process.
> 
> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> 
> ---
>    v2:
>       - translate file descriptors via IPC API
>       - add documentation
>    v3:
>       - rabse the commit
>       - use private static array for fd's to be local for each process
> 
>    v4:
>       - removed TODO and FIXME tags
>       - used strlcpy instead of strcpy
> 
>    v5: rebase the commit on top of Alejandro Lucero patch for secondary
>        process private pointer.
>        http://patches.dpdk.org/patch/46185/
> 
Maybe the patch title could be better,

net/tap: allow secondary process to access primary TAP device queues

Maybe we can just have the title changed at apply time and not require a new patch.

Regards,
Keith