From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 6F6FB1B4DD for ; Wed, 10 Oct 2018 14:47:53 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Oct 2018 05:47:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,364,1534834800"; d="scan'208";a="81443282" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga006.jf.intel.com with ESMTP; 10 Oct 2018 05:47:50 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 10 Oct 2018 05:47:49 -0700 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.34]) by fmsmsx118.amr.corp.intel.com ([169.254.1.230]) with mapi id 14.03.0319.002; Wed, 10 Oct 2018 05:47:48 -0700 From: "Wiles, Keith" To: Raslan Darawsheh CC: Thomas Monjalon , "dev@dpdk.org" , Shahaf Shuler , Ori Kam , "Yigit, Ferruh" Thread-Topic: [PATCH v5 3/3] net/tap: add queues when attaching from secondary process Thread-Index: AQHUYGdlw2lGRD7Fsk2AjnoJdowcqKUY428A Date: Wed, 10 Oct 2018 12:47:48 +0000 Message-ID: <53E19DB1-1266-4588-8EB2-04062A5DEBB1@intel.com> References: <1539154988-20652-1-git-send-email-rasland@mellanox.com> <1539154988-20652-3-git-send-email-rasland@mellanox.com> In-Reply-To: <1539154988-20652-3-git-send-email-rasland@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.38.137] Content-Type: text/plain; charset="us-ascii" Content-ID: <76D4789174141C4596D89D43377A995C@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 3/3] net/tap: add queues when attaching from secondary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Oct 2018 12:47:54 -0000 > On Oct 10, 2018, at 2:03 AM, Raslan Darawsheh wrot= e: >=20 > In the case the device is created by the primary process, > the secondary must request some file descriptors to attach the queues. > The file descriptors are shared via IPC Unix socket. >=20 > Thanks to the IPC synchronization, the secondary process > is now able to do Rx/Tx on a TAP created by the primary process. >=20 > Signed-off-by: Raslan Darawsheh > Signed-off-by: Thomas Monjalon >=20 > --- > v2: > - translate file descriptors via IPC API > - add documentation > v3: > - rabse the commit > - use private static array for fd's to be local for each process >=20 > v4: > - removed TODO and FIXME tags > - used strlcpy instead of strcpy >=20 > v5: rebase the commit on top of Alejandro Lucero patch for secondary > process private pointer. > http://patches.dpdk.org/patch/46185/ >=20 Maybe the patch title could be better, net/tap: allow secondary process to access primary TAP device queues Maybe we can just have the title changed at apply time and not require a ne= w patch. Regards, Keith