From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by dpdk.org (Postfix) with ESMTP id 9B8A7B39D for ; Tue, 12 Aug 2014 09:56:51 +0200 (CEST) Received: by mail-wi0-f169.google.com with SMTP id n3so6612430wiv.0 for ; Tue, 12 Aug 2014 00:59:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=88K5aSyk3WrTjjB2CXNtY2BuMWMp6+7h+1mUB4Wbhbc=; b=bQvE3Egbq9yUAPRXbRYbsSDSbRpxKh/eGlXFsK9HakiZ8FcOdBzMihOUb7Opsk4c+9 I+v0ZI+8IvB/7tWCQj9Aic8zNOMLpIrePJ5MQqpwACvlQUay1NyqczILxzBDo9EovVzu h9d+hZJx+Lq9U/LmDEvDwO6Z5yzEfeViINKKyWk+pKPjijE+sfhP6TKLH7kitD8el6td WLO55XTb9CpvBCUsaXL3cNT93W6fEAoNOSuzH4+3DkKlmh3wUGkYzokFdJSQvdfGOmTX tRyM9Wxexq9JxJ8k+2HFAlgLjGLvzvTJcY6BDbeN/2enPOpOLWrBasUsdKP3oGwCQpkM kedw== X-Gm-Message-State: ALoCoQlIsSPoak1AFmz0yIVhVZUXhMieMoTd/DmE2vEIhoiYZ3ZNlefxFYtLVVc2mr7YpPW5r8OT X-Received: by 10.180.108.13 with SMTP id hg13mr31892150wib.28.1407830386002; Tue, 12 Aug 2014 00:59:46 -0700 (PDT) Received: from [10.16.0.195] (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id gi5sm7425968wjd.33.2014.08.12.00.59.44 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 12 Aug 2014 00:59:45 -0700 (PDT) Message-ID: <53E9C96F.6050904@6wind.com> Date: Tue, 12 Aug 2014 09:59:43 +0200 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0 MIME-Version: 1.0 To: Bruce Richardson References: <1407789890-17355-1-git-send-email-bruce.richardson@intel.com> <1407789890-17355-2-git-send-email-bruce.richardson@intel.com> <20140811144521.21058e5b@haswell.linuxnetplumber.net> In-Reply-To: <20140811144521.21058e5b@haswell.linuxnetplumber.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [RFC PATCH 01/14] mbuf: rename RTE_MBUF_SCATTER_GATHER into RTE_MBUF_REFCNT X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Aug 2014 07:56:51 -0000 Hi Bruce, On 08/11/2014 11:45 PM, Stephen Hemminger wrote: > On Mon, 11 Aug 2014 21:44:37 +0100 > Bruce Richardson wrote: > >> From: Olivier Matz >> >> It seems that RTE_MBUF_SCATTER_GATHER is not the proper name for the >> feature it provides. "Scatter gather" means that data is stored using >> several buffers. RTE_MBUF_REFCNT seems to be a better name for that >> feature as it provides a reference counter for mbufs. >> >> The macro RTE_MBUF_SCATTER_GATHER is poisoned to ensure this >> modification is seen by drivers or applications using it. >> >> Signed-off-by: Olivier Matz >> Signed-off-by: Bruce Richardson After applying this first patch, I still get references to "scatter gather": $ git grep RTE_MBUF_SCATTER_GATHER examples/Makefile:DIRS-$(CONFIG_RTE_MBUF_SCATTER_GATHER) += ip_fragmentation examples/Makefile:DIRS-$(CONFIG_RTE_MBUF_SCATTER_GATHER) += ipv4_multicast examples/ip_fragmentation/Makefile:ifneq ($(CONFIG_RTE_MBUF_SCATTER_GATHER),y) examples/ip_fragmentation/Makefile:$(error This application requires RTE_MBUF_SCATTER_GATHER to be enabled) examples/ip_pipeline/Makefile:ifeq ($(CONFIG_RTE_MBUF_SCATTER_GATHER),y) lib/librte_mbuf/rte_mbuf.h:#pragma GCC poison RTE_MBUF_SCATTER_GATHER lib/librte_port/Makefile:ifeq ($(CONFIG_RTE_MBUF_SCATTER_GATHER),y) lib/librte_port/Makefile:ifeq ($(CONFIG_RTE_MBUF_SCATTER_GATHER),y) Olivier