From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f182.google.com (mail-we0-f182.google.com [74.125.82.182]) by dpdk.org (Postfix) with ESMTP id AEA0CB39D for ; Tue, 12 Aug 2014 10:24:44 +0200 (CEST) Received: by mail-we0-f182.google.com with SMTP id k48so9613981wev.13 for ; Tue, 12 Aug 2014 01:27:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=MqZTOHhQA11A/00KAy+j+QFam1ZEpOhC2ODhTm4uB1Y=; b=eqQnQdRkdTgLOoraWNO0OZEVYJdD2rczYCvd4RlmjzvHjxYmFAx4Cpxc4vQgZpTKJY kvkopDWaJ4r7orHQ9tjsRGdc4ar6S2P0FgUEuA1ut8HbXvO1KuDfcreBcExIdHTWODCU oKqvBuptcLimFhBETsW89WaYRsDJCAzCgZDc/EAnBIBZ42c9kyiE4peg1uyQb0rNPsx6 FHybKciKetu9Vmc50SdCFZ1jPORzvNaAMVn4DW12mPC5wgx3Nhx7cg/hARiWh1blv6De YUqx5U+2o5kVDTjj6ZavqomtVpiU7zsYY5yRDUbuLO8GwlCBUE6dJPlOaaD82yx23Xrx ntVg== X-Gm-Message-State: ALoCoQk6Z086ibavoS1+9BTw6isoR5meyt4P8lETFL6MmpdwdaKVMbUDphJl4EcBzjmW0hvPn/u5 X-Received: by 10.194.92.148 with SMTP id cm20mr3703872wjb.57.1407832059005; Tue, 12 Aug 2014 01:27:39 -0700 (PDT) Received: from [10.16.0.195] (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id ft17sm7631219wjc.14.2014.08.12.01.27.37 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 12 Aug 2014 01:27:37 -0700 (PDT) Message-ID: <53E9CFF8.6060002@6wind.com> Date: Tue, 12 Aug 2014 10:27:36 +0200 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0 MIME-Version: 1.0 To: Bruce Richardson , dev@dpdk.org References: <1407789890-17355-1-git-send-email-bruce.richardson@intel.com> <1407789890-17355-3-git-send-email-bruce.richardson@intel.com> In-Reply-To: <1407789890-17355-3-git-send-email-bruce.richardson@intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC PATCH 02/14] mbuf: remove rte_ctrlmbuf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Aug 2014 08:24:44 -0000 Hi Bruce, On 08/11/2014 10:44 PM, Bruce Richardson wrote: > From: Olivier Matz > > The initial role of rte_ctrlmbuf is to carry generic messages (data > pointer + data length) but it's not used by the DPDK or it applications. > Keeping it implies: > - loosing 1 byte in the rte_mbuf structure > - having some dead code rte_mbuf.[ch] > > This patch removes this feature. Thanks to it, it is now possible to > simplify the rte_mbuf structure by merging the rte_pktmbuf structure > in it. This is done in next commit. > > Signed-off-by: Olivier Matz > > Conflicts: > lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c > > Signed-off-by: Bruce Richardson Same here, "git grep ctrlmbuf" finds results in examples/ip_pipeline/cmdline.c and examples/ip_pipeline/init.c You can also see it by doing "make examples T=x86_64-native-linuxapp-gcc" from dpdk root. > @@ -204,14 +182,10 @@ struct rte_mbuf { > #else > uint16_t refcnt_reserved; /**< Do not use this field */ > #endif > - uint8_t type; /**< Type of mbuf. */ > - uint8_t reserved; /**< Unused field. Required for padding. */ > + uint16_t reserved; /**< Unused field. Required for padding. */ This line breaks the alignment of comments (this typo was already present in my initial patch). By the way, there was also a patch called "mbuf: cosmetic changes in rte_mbuf structure" to restore the comments alignment for all the fields of the structure. Maybe it should be integrated in your series. Regards, Olivier