From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id B25F5B3A7 for ; Tue, 12 Aug 2014 10:35:38 +0200 (CEST) Received: by mail-wi0-f170.google.com with SMTP id f8so6647805wiw.1 for ; Tue, 12 Aug 2014 01:38:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=t+VnNMm6ZwAJ/NxK8I3DJp1d1+nUMG4Yf7w7voTTN1E=; b=J3fqz9NKVKVB81erl0X4eLvcICzyxJhXAYe60a4OcnirxttSJWdioBbPgd/Jt1nvIh LrxfOkf7Ha86qrLiHWIVbSi4zQEHB0EE6nBjzsvjthB6Zw4TzRq5LsJDtQY6puDTAF23 yF/qtlFWHfbsWXaZ4jdIG3EvEIkqnilJYooEty6x9SBPdUR7wKn2yIUlwTk3e5e9KNW5 bM5jTkFCPyWZ0BINUxWLmOj96UDR0cY+Pkj35fuD55otrP6hUqCav+Lv0KY/eOFqkXD6 Qpd+9ILJLlXN2JiT2j/a3zCTtTORagVx46inGszxoG9pRxkci7mMELEA86A2k0rEgPGz Tumw== X-Gm-Message-State: ALoCoQm99cQXhO+AjdANm6OlPvmw3BvjlVGl4erJWuiUzKEHyt2hpFVQ845etOXfXAoxxBiJVUjV X-Received: by 10.180.73.6 with SMTP id h6mr31023398wiv.65.1407832713168; Tue, 12 Aug 2014 01:38:33 -0700 (PDT) Received: from [10.16.0.195] (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id bx2sm7604009wjb.47.2014.08.12.01.38.31 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 12 Aug 2014 01:38:32 -0700 (PDT) Message-ID: <53E9D287.7020404@6wind.com> Date: Tue, 12 Aug 2014 10:38:31 +0200 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0 MIME-Version: 1.0 To: Bruce Richardson , dev@dpdk.org References: <1407789890-17355-1-git-send-email-bruce.richardson@intel.com> <1407789890-17355-4-git-send-email-bruce.richardson@intel.com> In-Reply-To: <1407789890-17355-4-git-send-email-bruce.richardson@intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC PATCH 03/14] mbuf: remove the rte_pktmbuf structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Aug 2014 08:35:38 -0000 Hi Bruce, On 08/11/2014 10:44 PM, Bruce Richardson wrote: > From: Olivier Matz > > The rte_pktmbuf structure was initially included in the rte_mbuf > structure. This was needed when there was 2 types of mbuf (ctrl and > packet). As the control mbuf has been removed, we can merge the > rte_pktmbuf into the rte_mbuf structure. > > Advantages of doing this: > - the access to mbuf fields is easier (ex: m->data instead of m->pkt.data) > - make the structure more consistent: for instance, there was no reason > to have the ol_flags field in rte_mbuf > - it will allow a deeper reorganization of the rte_mbuf structure in the > next commits, allowing to gain several bytes in it > > Signed-off-by: Olivier Matz > > Conflicts: > lib/librte_pmd_virtio/virtio_rxtx.c > lib/librte_pmd_virtio/virtqueue.h > lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c > > Signed-off-by: Bruce Richardson Some files are missing. We can find some with: git grep "pkt\." in app/test/packet_burst_generator.c examples/ip_fragmentation/main.c examples/ip_pipeline/pipeline_rx.c examples/ip_pipeline/pipeline_tx.c lib/librte_port/rte_port_frag.c I'm not sure it gives all remaining occurences. The best way to find them is probably to check the compilation of examples for all targets. Olivier