From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33997A0C41; Tue, 11 May 2021 10:35:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C85FE406A3; Tue, 11 May 2021 10:35:56 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 102B44003E for ; Tue, 11 May 2021 10:35:54 +0200 (CEST) IronPort-SDR: GaD3KjkuBR1OBABOo8a2P8+LdkFYtkH71ZzvidnnqtuNPeApYAyQJBcEs27HMOY9qS7ayMlnju 3qkNy2eUxeUg== X-IronPort-AV: E=McAfee;i="6200,9189,9980"; a="179651819" X-IronPort-AV: E=Sophos;i="5.82,290,1613462400"; d="scan'208";a="179651819" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2021 01:35:53 -0700 IronPort-SDR: L8vw2KugfJZQIokYor6bEMEq3+LQE2kzD4xjShHkPLcKmx2wjXNi572XsuQcRij2MkwkZIibUh RFAQB3rnzQGw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,290,1613462400"; d="scan'208";a="430214011" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga007.jf.intel.com with ESMTP; 11 May 2021 01:35:53 -0700 Received: from shsmsx604.ccr.corp.intel.com (10.109.6.214) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 11 May 2021 01:35:52 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX604.ccr.corp.intel.com (10.109.6.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 11 May 2021 16:35:50 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2106.013; Tue, 11 May 2021 16:35:50 +0800 From: "Zhang, Qi Z" To: "Zhang, AlvinX" , "Xing, Beilei" , "Xu, Ting" CC: "dev@dpdk.org" , "Zhang, AlvinX" Thread-Topic: [dpdk-dev] [PATCH] net/iavf: fix error logs Thread-Index: AQHXRZb/+b3jfZ0BmkC6njvd/K97xard9dsg Date: Tue, 11 May 2021 08:35:50 +0000 Message-ID: <53b5e88b68c04beb95223143e291e019@intel.com> References: <20210510122050.32668-1-alvinx.zhang@intel.com> <20210510122050.32668-2-alvinx.zhang@intel.com> In-Reply-To: <20210510122050.32668-2-alvinx.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix error logs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Alvin Zhang > Sent: Monday, May 10, 2021 8:21 PM > To: Xing, Beilei ; Xu, Ting > Cc: dev@dpdk.org; Zhang, AlvinX > Subject: [dpdk-dev] [PATCH] net/iavf: fix error logs >=20 > Remove some useless logs which are duplicated of the lower-level function > logs and may confuse users when running VF without some features > supportted by PF. >=20 > Fixes: 5a038d19962d ("net/iavf: fix RSS configuration on i40e VF") > Fixes: 95f2f0e9fc2a ("net/iavf: improve default RSS") >=20 > Signed-off-by: Alvin Zhang > --- > drivers/net/iavf/iavf_vchnl.c | 13 ++----------- > 1 file changed, 2 insertions(+), 11 deletions(-) >=20 > diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.= c index > ca5c56e..dfa7ce3 100644 > --- a/drivers/net/iavf/iavf_vchnl.c > +++ b/drivers/net/iavf/iavf_vchnl.c > @@ -1519,11 +1519,8 @@ > args.out_size =3D IAVF_AQ_BUF_SZ; >=20 > err =3D iavf_execute_vf_cmd(adapter, &args); > - if (err) { > - PMD_DRV_LOG(ERR, > - "Failed to execute command of > OP_GET_RSS_HENA_CAPS"); I don't think we should remove these logs, it help us to understand which c= ommand virtchnl failed. > + if (err) > return err; > - } >=20 > *caps =3D ((struct virtchnl_rss_hena *)args.out_buffer)->hena; > return 0; > @@ -1535,7 +1532,6 @@ > struct iavf_info *vf =3D IAVF_DEV_PRIVATE_TO_VF(adapter); > struct virtchnl_rss_hena vrh; > struct iavf_cmd_info args; > - int err; >=20 > vrh.hena =3D hena; > args.ops =3D VIRTCHNL_OP_SET_RSS_HENA; > @@ -1544,12 +1540,7 @@ > args.out_buffer =3D vf->aq_resp; > args.out_size =3D IAVF_AQ_BUF_SZ; >=20 > - err =3D iavf_execute_vf_cmd(adapter, &args); > - if (err) > - PMD_DRV_LOG(ERR, > - "Failed to execute command of OP_SET_RSS_HENA"); Same as above. > - > - return err; > + return iavf_execute_vf_cmd(adapter, &args); > } >=20 > int > -- > 1.8.3.1