From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0FF1242D16; Wed, 21 Jun 2023 18:50:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D79124068E; Wed, 21 Jun 2023 18:50:55 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2072.outbound.protection.outlook.com [40.107.220.72]) by mails.dpdk.org (Postfix) with ESMTP id 9EF6C4003C for ; Wed, 21 Jun 2023 18:50:53 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UagmZiqUc8x/9rLKqZyzF2BfoHIgtX1KdwwFsxeyVYLWIne54pI3E359O2OQpm8s1L8inG+nszwD0H2hDWGjWcK6tts4+SR7GhIcGmJVB+chpxfKwZcm/jHcl9YcjegzAmzJkTIx/Dhp8rJKfBXyWiyyQIra2hhBBCJtosGm/Qg/MdOgj46o7/WcK9ghokuVxDaJYNPR5uWBob6gJMrNzlgYzAcWDFLNmmbuRp7k8Pq3cQBdjDI6X4SEmT6j8th5Sxk7pOJ+IKWcM664baJkkppoV/8Q6GlmnZo4GWBoCV87Z7TVh4lbiVXZrcicD0O58sZBmp1iN9njZBB3WoPjzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=owfkm+QgbJxrsvS5b/7rR/OjtREyePBc+ZB5jhYhEXc=; b=eI3JkrXSO3v+hGs+n68izjfOhco7pQySIFSoJyQdWWlaBuckBACuQLwRYPSS/UOFpX6s0RP3aB4Dlj+L65QxN2HHcba86HREDtJpONqzSnyt/WSQJZmr53OUS1oorxE7+eE2hd78yDpDy+O9Al1yvnRz1L9Eeedoy2EZvPLPaoiVWwElY/aWiWqqOkrOyKSv8yKUI/ix1x1DY59SkDLdvJM+pYohzwVp8gsk4tcRyYtkKNHAtK7T6aJA96m6CEVIP29f9bSjGgUjfZwCH9dE6VqraGv6OAL62/f/IODlCoRh0xx1qlBALIKTPAioyy6k2CXZaZggVA3g57Rda/hwew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=owfkm+QgbJxrsvS5b/7rR/OjtREyePBc+ZB5jhYhEXc=; b=Tm+p75baj+Ksx0x8OQA6t7/LNMA+ujn95KuDPwOboQ+iUk781hrjOnUp+ccUDwMrcImgO3HIHQMiROwd8UOEEtyG/+3mbYdLOlt44YRMiC7uK3SD9WmsjxpDFfgZWbWVDYbiQQWEVy68b1K8Fi3PW0EcMoamlOr2rvWo42XetnQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MW4PR12MB6804.namprd12.prod.outlook.com (2603:10b6:303:20d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.37; Wed, 21 Jun 2023 16:50:51 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6521.023; Wed, 21 Jun 2023 16:50:51 +0000 Message-ID: <53b8dffe-de19-b38c-6213-c45887e99bac@amd.com> Date: Wed, 21 Jun 2023 17:50:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: Ivan Malov , dev@dpdk.org Cc: Andrew Rybchenko , Andy Moreton References: <20230601195538.8265-1-ivan.malov@arknetworks.am> <20230607130245.8048-1-ivan.malov@arknetworks.am> <20230607130245.8048-28-ivan.malov@arknetworks.am> From: Ferruh Yigit Subject: Re: [PATCH v4 27/34] net/sfc: add support for IPv4 NAT offload to MAE backend In-Reply-To: <20230607130245.8048-28-ivan.malov@arknetworks.am> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0130.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c6::19) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MW4PR12MB6804:EE_ X-MS-Office365-Filtering-Correlation-Id: 92ed4c25-1e05-4b37-c36c-08db7277ab92 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: m/UY0/DyhgxXfVIEByDXSJgHoCON8pkYr8m/NuOzGVxmvbdLs6IaSw4AGSu5x8FxvkINIJSXTNRFbg/A5RnSPyNRDNJ+7hMH0yq4ZmIDyDOWVtQzcomsBB6Xwc2jbsImVLufWo1wAojIKUZZgzo2ApfDM/9xbDjdbxmZWT1SMmAzBQB86MUnSbqvCnzC1t53WBZeATP6qdL4RQYGOFy3WGWBonauvMB7HZ5flUNq2HXYbxaleSU3EFQoOcGts3x3UzgY3i6ANOJMFZgJ1wiGyow9fGn1JaOEFKqLzO8icNChFuj4c2r3Sx9lAPr2+S9JROjW3+IGE/6M9shlyR4QgWzlHp8/SJwmFnpDLy1Ojq3acNKAKIobdpdHEvx/LXG33DWa5D2mjYBCei1xP0+71lh9r8yqN4bx//dqHj/hDCr2+53EwXrOZ4K9SxmRkzgDkoHrc8/byXYBOvaHLsa06xmrHWImg/rhJscdI4v/5vHkr4Dm36/Mn/vBnwOcpKzA4EDY5n/GQTVNvoPpravAMkB8vfeZO94zaZv73oZsOpdTGMxjtMRT2XIU9Ct8JzG81HzkhL+gldmPXptzZD2b0OaAjyHSA+Tc7SXoG82JYCyLBp/V3oLQBKyOpoAdrElZDM175b0J8JC3x3ATEayyEw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(346002)(39860400002)(366004)(136003)(396003)(376002)(451199021)(186003)(66556008)(66946007)(4326008)(66476007)(8676002)(5660300002)(8936002)(54906003)(6486002)(6666004)(316002)(36756003)(41300700001)(478600001)(26005)(6512007)(6506007)(53546011)(38100700002)(31686004)(83380400001)(31696002)(2906002)(44832011)(2616005)(86362001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TUtPaFFVeFQ4UU9Iclppajg0OFJlcDhydnRab1h4Qm81UDdTK0RCcUZMNFNR?= =?utf-8?B?dGZmWngwaERMVVVtOFBudGxTcUdlUE5wS0FpbC9TcCtjWms0UTlVUWpJd0Zn?= =?utf-8?B?OFQ2L3gyeUxVSXBQOFdYRDF1SjBnci9ablNWcHdxODB1QnpSdjFPWlVuSFg1?= =?utf-8?B?NlNjelZoQWh6dk44U2R4SEJGL3YwelM1Q0lyMy9ubmRCUDE4cGY1akRDNXhz?= =?utf-8?B?dm5GMTlsYWpqRkpWUTdxV2tjbnEyblRod0VmL2NPR0I4blphUzlqTERxRVUw?= =?utf-8?B?dE10bTFYZU1WM3dOSkNFRVRNbGJJRVJBRkJPc3ZoZlRzZHJLWVZYNTFibTBB?= =?utf-8?B?aXZ3Q2FrcHdMR0RhRTVQOHE2elZ6SmI5RWRlbUlEWDFJb01nNjJQNDIzRDNz?= =?utf-8?B?elFCUGhyNFVwK3o3alhhYXVUS1dGa1phWk5xYS9ocHBINGFzUXV0TGtzZVlX?= =?utf-8?B?d0I4dDNvTGQzR1lYaklMOER2NW9wVEZzNzA4bGQwVXV0VW1NOU1reGlGR1ND?= =?utf-8?B?RTQwRkU0d3llVGd6NFRRODU2Y1lEZjZSWk5vQ05UZXgxZVNia1hFczZGWnJJ?= =?utf-8?B?L2o5dGRhOVVuQ1VsUHl0b1ZzWHhZc2xKYlFXVnBaMjI2cjkxOFFRdXN3cVJO?= =?utf-8?B?d3hIRmJ5cG9pbkJPdEp3UDNHOHhhNVI3TGsxaW8rWU1GbW1IK0dhOWRwbHJJ?= =?utf-8?B?K09QYm1QV2xTWkk0TnJjdFhjR1A4OTd1LzBrYzdYM3pSNWt0N00wdWZtNnJX?= =?utf-8?B?V3U1SmdGZ3ZDSTY5Umo4QVlmSTdCZ296b0xZWVVRNytQelF6OXNlRDBEdDhj?= =?utf-8?B?Wlc3UWRuOC9VVVFCRXZkcUNneGpaQ01iQWZVYzgvbm9OVmE3VnZLcUdybFJR?= =?utf-8?B?RVBjeDMrN1lESTVnTWV1T2lXLzBQdTRNdkwwWFFsT1c2QWlXWG5XWEh6M2Rw?= =?utf-8?B?NExuckRocXNvV2NtNFhHaEN4RTBOSlVMeUFRY1BYalF3UnU2OWtWVkJ5aG9Q?= =?utf-8?B?THhhR0tFQzkxb1VBWTFTbTNCWU1WNG5YVEN5S2NIbDU4OEhIU1dHZ1k3ZUU2?= =?utf-8?B?WEVRWnUvQXdvY1k3ME9sSXgrb1A3T3U5V3dOeDJTZnMvekRHMGlJU05PV0tv?= =?utf-8?B?VkpJUWhnTklqbVZOVjNtT3ZUNFFhRkVmZ3NsSGxGaVZpN2hiSVFPRjlZTVVZ?= =?utf-8?B?MkJaK3dtTHpvMEYwUmxqeGhFOEhBTXlGcEdaS0VkR0E3TlZwSDRXV3BHWUk5?= =?utf-8?B?dzB5clo0cGtpSG16OG5SZWZMTHZ0WUhENTNqcGhBU1N5OE9Fc3FSbU1kSmVm?= =?utf-8?B?dlBOUFk3cE5qcjZGTGRxYWFrRDlMUmxDc1ZJWkxPR0dQc2dqT1N2a3k0K0pN?= =?utf-8?B?Y05vbVRwYTl0TjVQenZWR3BCcGFCRTZhV0hZYi9BOThEQUxmZ3RIVEEycXlt?= =?utf-8?B?cWozMlQ1OEx0K2VXcnpXV0dNZ2NJWjk2cGFwZE5rRFIxN016cXYrdUZUQWVM?= =?utf-8?B?Tm9ndTBnenRTRitrUURkODhwU0NYWk5WMkZmUXlFNGdzNVNRYm1DTllYSEY2?= =?utf-8?B?bVFDdm1iL3ZhWldZTE9YVEh1TzBJL3N3aTFZeXJ2bi9nQlcybWFsQnhyR1ZE?= =?utf-8?B?bUhuWk5VLzcrcXVXK0VHR1JQUEU0bGFTYVlnQXlBenlzMjR5VWNIT0dwL1dZ?= =?utf-8?B?dEpJNHN0a0Y2Ym1yQlZ6R0cyc1hIU3ZyaEpqMDgrS2xzRUdzV0VmYTJOemtV?= =?utf-8?B?V0p4cDI0ME10WXl1UGE4M0o3ZmRXTFpKMGtwSTAzc2N0cmpKOC82TU5oeDVm?= =?utf-8?B?ZU9teWNIbWlKclRrdHRaKysxNU9yTWZiL29DMk0rOWdMbExsWGRnd1JSMVVp?= =?utf-8?B?REd0UHZoNEVrV0FsZUNJU0JJazZtaC9GZ3AxcjgrTmpHdEtlRXZLRURRYnE2?= =?utf-8?B?UkcvNUVXS3BmYU45aGd4ZnlLUi9JMnpzTFJiWnd6bHZhaFdHbmMyYVJmdjlY?= =?utf-8?B?RzMvWXJCTThLbFhNTCtzTm9TR1JNYWE2VU5MTGlZeEQ1UXdGY3dYSGZFTUJP?= =?utf-8?B?SmFyZHNoVUtmZ21OY1Y0NkNMaGJ6RkNqWXAyNUlrNXNsTWRJMzNzeVIrN040?= =?utf-8?Q?1linVynoRP2aVwro5lCCgDAtB?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92ed4c25-1e05-4b37-c36c-08db7277ab92 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2023 16:50:51.0752 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AaVPUE/UYoGcC0Vm6DZxY9hEPqkrI07N8BgM5gkSW6/d2BLG3Mk7Kjb/SkCrNoUC X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6804 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/7/2023 2:02 PM, Ivan Malov wrote: > For this offload to work, the innermost pattern items must > provide the full set of exact match criteria, which are as > follows: EtherType, IP DST, IP SRC, TP protocol ID, TP DST > and TP SRC, where the protocol types can be autodetected. > > The offload requires that the IPv4 and the TP actions be > requested simultaneously in the same flow by the caller: > SET_IPV4_DST + SET_TP_DST or SET_IPV4_SRC + SET_TP_SRC. > > The offload operates on the outermost frame, which, > if action VXLAN_DECAP was requested, maps to the > inner frame of the original packet. The caller > is responsible to request this offload only > when the target header is an IPv4-based one. > > Signed-off-by: Ivan Malov > Reviewed-by: Andy Moreton <...> > --- a/doc/guides/rel_notes/release_23_07.rst > +++ b/doc/guides/rel_notes/release_23_07.rst > @@ -55,6 +55,21 @@ New Features > Also, make sure to start the actual text at the margin. > ======================================================= > > +* **Updated Solarflare network PMD.** > + > + Updated the Solarflare ``sfc_efx`` driver with changes including: > + > + * Added partial support for transfer flow actions SET_IPV4_DST, > + SET_TP_DST, SET_IPV4_SRC and SET_TP_SRC on SN1000 SmartNICs. > + It is required that the innermost pattern items provide the > + full set of exact match criteria: EtherType, IP DST, IP SRC, > + TP protocol ID, TP DST and TP SRC. The IPv4 and TP actions > + must be requested simultaneously in the same flow. These > + actions operate on the outermost frame, at the point > + where action VXLAN_DECAP (if any) has done its job. > + The caller is responsible to request this offload > + only when the target header is an IPv4-based one. > + Reordered update, moved it under existing Solarflare update and simplified note as more suitable for release notes.