From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
Aman Singh <aman.deep.singh@intel.com>
Cc: <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal: add log to print dpdk version at start
Date: Thu, 2 Sep 2021 11:02:11 +0100 [thread overview]
Message-ID: <53eba2ae-7406-6aa2-496b-58bb3b224e7e@intel.com> (raw)
In-Reply-To: <YS9EW8oS0h/RXCzq@bricha3-MOBL.ger.corp.intel.com>
On 9/1/2021 10:14 AM, Bruce Richardson wrote:
> On Wed, Sep 01, 2021 at 11:48:21AM +0530, Aman Singh wrote:
>> From the logs it is difficult to get the DPDK version
>> that was used. So added a debug log to print the same.
>> The log has been added in eal_init so it gets printed
>> at startup for any application.
>>
>> Signed-off-by: Aman Singh <aman.deep.singh@intel.com>
>> ---
>> lib/eal/freebsd/eal.c | 2 +-
>> lib/eal/linux/eal.c | 2 +-
>> lib/eal/windows/eal.c | 1 +
>> 3 files changed, 3 insertions(+), 2 deletions(-)
>>
> Note: EAL already has the "-v" flag which prints the version number at startup.
>
More common usage is when -v (--version) is provided app prints the version and
exits.
No strong opinion but it is possible to have the version output always as debug,
and convert '-v' to log and exit.
next prev parent reply other threads:[~2021-09-02 10:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 6:18 Aman Singh
2021-09-01 6:55 ` Andrew Rybchenko
2021-09-01 9:14 ` Bruce Richardson
2021-09-02 10:02 ` Ferruh Yigit [this message]
2021-09-01 17:12 ` Stephen Hemminger
2021-09-02 10:11 ` Ferruh Yigit
2021-09-02 10:27 ` Bruce Richardson
2021-09-06 13:28 ` Singh, Aman Deep
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53eba2ae-7406-6aa2-496b-58bb3b224e7e@intel.com \
--to=ferruh.yigit@intel.com \
--cc=aman.deep.singh@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).