From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Tim Shearer <tim.shearer@overturenetworks.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] librte: Link status interrupt race condition, IGB E1000
Date: Tue, 27 Oct 2015 18:45:20 +0100 [thread overview]
Message-ID: <5406727.UN0rhZ0d4I@xps13> (raw)
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC0909020A2AE8@shsmsx102.ccr.corp.intel.com>
2015-10-26 05:25, Lu, Wenzhuo:
> I think you're right. To my opinion, this if is added to avoid the race condition. So, it should be " dev->data->dev_conf.intr_conf.lsc == 0". It means if the interrupts are not enabled, we'd update the link when starting, if not we can leave it the interrupt handler.
> Seems it's not an igb specific but common issue.
Tim, please could you send an appropriate patch?
The procedure is described in http://dpdk.org/dev#send
Could you also check if other PMDs have the same bug?
Thanks
next prev parent reply other threads:[~2015-10-27 17:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-24 20:44 Tim Shearer
2015-10-25 22:55 ` Thomas Monjalon
2015-10-26 5:25 ` Lu, Wenzhuo
2015-10-27 17:45 ` Thomas Monjalon [this message]
2015-10-27 21:38 ` [dpdk-dev] [PATCH] lib/librte_ether: Prevent link status race condition when LSI enabled Tim Shearer
2015-11-04 22:13 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5406727.UN0rhZ0d4I@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=tim.shearer@overturenetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).