From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by dpdk.org (Postfix) with ESMTP id 672C88D8D for ; Tue, 27 Oct 2015 18:46:30 +0100 (CET) Received: by wicfx6 with SMTP id fx6so170555436wic.1 for ; Tue, 27 Oct 2015 10:46:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=bFEpeYT2DVsXEM1JLec0Iq5FbstzuyrPRt8iY8qmORk=; b=N1Wt7NK9ceJCG/Or0Ii9xnwq+RkTM6mW/6z9dqAKEpJvTP4IdfDbPwORzb5cALwB08 EJybsvpq5E8+mShXjd2ZCnb37iRLOKDz3Beqv0fUQhjM3xFLvdgMHoLZwi6sav/U8jS0 oj7W5RqL6zLFXOscSQnPcPHr9aztvt687amcuJMfoTgCScaBc4Rw9/b+BRCAVODnkYHQ STexuRfwWCl1S7uIJtNBLCFbKKqDj38/CzH0hXH/3qO509kwlQiBm7XcOl+ZJBGgMXHT T++DiCCNrr3T5w14EX/CfrXnYW5PLAKgUYiOhbtgAry4ZjQ9hjWne1GNoB9hv1BRTrMM BdBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=bFEpeYT2DVsXEM1JLec0Iq5FbstzuyrPRt8iY8qmORk=; b=BMZfrBe7DI5QVDn6Y9VE7plXYqBFGIXXd2203QbC7CYWouIcP/zFyp1VwwqxtEYapn mEtKvhtVS16OP51A3sEyxOQJitnobqLJM6AO7XqHjRAUn/+hTA+Tb8cA1YieEnPuYK3b dv0nCZUw+xJEpTx932k8KZDaaO4/EA36NfIgdhduT2xESrkJG/n4sf7bYwreHt64BkCg vcOaxtYH3R3g79K1LVDX6aFa+o6vjvP6FLstZMs19Qfb/Ob57Ip6JOCzD2R2EUmidXCF 8HZf82Zvn7hOap0vxy2z4FGjWl1NAT/uHgOcPrdLJh/F4HHtg5lCInEJMZoP/mX1FdPA Ph0A== X-Gm-Message-State: ALoCoQnkfH4LOhuPV86EtAUsRV24iZGgKNuXcU8DzTFTgkzrFdcNMebK7qrx11Vda8P/LUUhhBHI X-Received: by 10.194.61.13 with SMTP id l13mr34920554wjr.76.1445967990200; Tue, 27 Oct 2015 10:46:30 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id d4sm2354064wiy.11.2015.10.27.10.46.29 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Oct 2015 10:46:29 -0700 (PDT) From: Thomas Monjalon To: Tim Shearer Date: Tue, 27 Oct 2015 18:45:20 +0100 Message-ID: <5406727.UN0rhZ0d4I@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC0909020A2AE8@shsmsx102.ccr.corp.intel.com> References: <33526A3108217C45B7DAFFA5277E4B67485277B3@mbx024-e1-nj-2.exch024.domain.local> <6060754.bW1Xky3pZ1@xps13> <6A0DE07E22DDAD4C9103DF62FEBC0909020A2AE8@shsmsx102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] librte: Link status interrupt race condition, IGB E1000 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Oct 2015 17:46:30 -0000 2015-10-26 05:25, Lu, Wenzhuo: > I think you're right. To my opinion, this if is added to avoid the race condition. So, it should be " dev->data->dev_conf.intr_conf.lsc == 0". It means if the interrupts are not enabled, we'd update the link when starting, if not we can leave it the interrupt handler. > Seems it's not an igb specific but common issue. Tim, please could you send an appropriate patch? The procedure is described in http://dpdk.org/dev#send Could you also check if other PMDs have the same bug? Thanks