From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 0E606683A
 for <dev@dpdk.org>; Mon,  8 Sep 2014 10:16:59 +0200 (CEST)
Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214]
 helo=[192.168.0.10])
 by mail.droids-corp.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)
 (Exim 4.80) (envelope-from <olivier.matz@6wind.com>)
 id 1XQuFR-0007eW-FR; Mon, 08 Sep 2014 10:24:32 +0200
Message-ID: <540D671B.9040104@6wind.com>
Date: Mon, 08 Sep 2014 10:21:47 +0200
From: Olivier MATZ <olivier.matz@6wind.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:24.0) Gecko/20100101 Icedove/24.5.0
MIME-Version: 1.0
To: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
References: <1409154628-30825-1-git-send-email-bruce.richardson@intel.com>
 <1409240559-14447-4-git-send-email-bruce.richardson@intel.com>
In-Reply-To: <1409240559-14447-4-git-send-email-bruce.richardson@intel.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2 3/6] mbuf: remove rte_ctrlmbuf
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Sep 2014 08:16:59 -0000

Hi Bruce,

On 08/28/2014 05:42 PM, Bruce Richardson wrote:
> From: Olivier Matz <olivier.matz@6wind.com>
> 
> The initial role of rte_ctrlmbuf is to carry generic messages (data
> pointer + data length) but it's not used by the DPDK or it applications.
> Keeping it implies:
>   - loosing 1 byte in the rte_mbuf structure
>   - having some dead code rte_mbuf.[ch]
> 
> This patch removes this feature. Thanks to it, it is now possible to
> simplify the rte_mbuf structure by merging the rte_pktmbuf structure
> in it. This is done in next commit.
> 
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> 
> * Updated patch to HEAD.
> * Modified patch to retain the old function names for ctrl mbufs as
>   macros. This helps with app compatibility, and allows the concept
>   of a control mbuf to be reintroduced via a single-bit flag in
>   a future change.
> * Updated the packet framework ip_pipeline example application to
>   work following this change.
> 
> Changes in v2:
> * Fixed whitespace errors introduced by this patch flagged by checkpatch
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

To be honest, I'm not convinced that keeping the old function names
is really required, but I suppose you had good reasons to reintroduce
them. Just for information, is it for compatibility purpose or is there
a real wish to reintroduce a sort of control mbuf in the future ?

Acked-by: Olivier Matz <olivier.matz@6wind.com>