From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgw.gov.kz (mgw.gov.kz [89.218.88.242]) by dpdk.org (Postfix) with ESMTP id A13CAB3A0 for ; Mon, 8 Sep 2014 12:29:44 +0200 (CEST) Received: from mgw.gov.kz (mx.ctsat.kz [178.89.4.95]) by mgw.gov.kz with ESMTP id s88AYdxs007001-s88AYdxt007001; Mon, 8 Sep 2014 16:34:39 +0600 Received: from EXCASHUB2.rgp.local (192.168.40.53) by EdgeForefront.rgp.local (192.168.40.59) with Microsoft SMTP Server (TLS) id 14.2.247.3; Mon, 8 Sep 2014 16:34:29 +0600 Received: from [192.168.35.15] (192.168.35.15) by excashub2.rgp.local (192.168.40.48) with Microsoft SMTP Server (TLS) id 14.2.247.3; Mon, 8 Sep 2014 16:34:49 +0600 Message-ID: <540D85E0.4030203@sts.kz> Date: Mon, 8 Sep 2014 16:33:04 +0600 From: Yerden Zhumabekov User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Olivier MATZ , Bruce Richardson , References: <1409759378-10113-1-git-send-email-bruce.richardson@intel.com> <1409759378-10113-4-git-send-email-bruce.richardson@intel.com> <540D8228.809@6wind.com> In-Reply-To: <540D8228.809@6wind.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [192.168.35.15] X-FEAS-SYSTEM-WL: e_zhumabekov@sts.kz Subject: Re: [dpdk-dev] [PATCH 03/13] mbuf: add packet_type field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Sep 2014 10:29:45 -0000 I would use it :) It's useful to store the IP protocol number (UDP, TCP etc) and version of IP (4, 6) and then relay packet to specific handler. 08.09.2014 16:17, Olivier MATZ пишет: > Hi Bruce, > > On 09/03/2014 05:49 PM, Bruce Richardson wrote: >> Replace a reserved slot with the new packet type field used to identify >> the type of the packet, i.e. what protocols are used. >> >> Signed-off-by: Bruce Richardson >> --- >> lib/librte_mbuf/rte_mbuf.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h >> index f136d37..8d0c6fb 100644 >> --- a/lib/librte_mbuf/rte_mbuf.h >> +++ b/lib/librte_mbuf/rte_mbuf.h >> @@ -146,7 +146,7 @@ struct rte_mbuf { >> uint32_t reserved1; /**< Unused field. Required for padding */ >> >> /* remaining bytes are set on RX when pulling packet from descriptor */ >> - uint16_t reserved2; /**< Unused field. Required for padding */ >> + uint16_t packet_type; /**< Type of packet, e.g. protocols used */ >> uint16_t data_len; /**< Amount of data in segment buffer. */ >> uint32_t pkt_len; /**< Total pkt len: sum of all segments. */ >> uint16_t l3_len:9; /**< L3 (IP) Header Length. */ >> > This patch adds a new fields that nobody uses. So why should we add it ? -- Sincerely, Yerden Zhumabekov State Technical Service Astana, KZ