From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id D53F3B399 for ; Mon, 8 Sep 2014 14:04:04 +0200 (CEST) Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214] helo=[192.168.0.10]) by mail.droids-corp.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XQxnF-0007jf-83; Mon, 08 Sep 2014 14:11:40 +0200 Message-ID: <540D9C57.4070206@6wind.com> Date: Mon, 08 Sep 2014 14:08:55 +0200 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0 MIME-Version: 1.0 To: Bruce Richardson , dev@dpdk.org References: <1409759378-10113-1-git-send-email-bruce.richardson@intel.com> <1409759378-10113-9-git-send-email-bruce.richardson@intel.com> In-Reply-To: <1409759378-10113-9-git-send-email-bruce.richardson@intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 08/13] mbuf: add named points inside the mbuf structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Sep 2014 12:04:05 -0000 On 09/03/2014 05:49 PM, Bruce Richardson wrote: > Add markers or "labels" at given points inside the mbuf which can be > used instead of individual fields to identify the start of logical > sections inside the mbuf. > > The use of typedefs and dummy fields was chosen over using unions > because of a couple reasons: > * unions cause an extra level of indentation (more likely two levels as > a union containing a struct for multiple fields would be needed). This > makes the lines longer than they need to be and increases the need for > wrapping. [This was the main reason] > * with markers, you can apply multiple markers at the same point if > wanted. > > Signed-off-by: Bruce Richardson Acked-by: Olivier Matz