From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 011F4B3A6 for ; Mon, 8 Sep 2014 14:27:53 +0200 (CEST) Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214] helo=[192.168.0.10]) by mail.droids-corp.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XQyAI-0007kp-KX; Mon, 08 Sep 2014 14:35:29 +0200 Message-ID: <540DA1EC.10603@6wind.com> Date: Mon, 08 Sep 2014 14:32:44 +0200 From: Olivier MATZ User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0 MIME-Version: 1.0 To: Bruce Richardson , dev@dpdk.org References: <1409154628-30825-1-git-send-email-bruce.richardson@intel.com> In-Reply-To: <1409154628-30825-1-git-send-email-bruce.richardson@intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 0/6] Mbuf structure Rework, part 1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Sep 2014 12:27:54 -0000 Hi Bruce, On 08/27/2014 05:50 PM, Bruce Richardson wrote: > This patch set does some initial pre-work to prepare the mbuf data structure > (and ixgbe vector driver to a lesser extent) for more major changes which > will follow on in a subsequent patch set. [See previous RFC patch set for > more indications of the future coming changes]. > > The main changes here are the flattening out of the mbuf data structure, with > much of it based off work by Olivier. The ctrlmbuf and pktmbuf structures are > now gone, as is the vlan_macip structure. However, in this set, the concept > of having a separate ctrl mbuf type is kept around. The plan is in a later set > when we expand the flags field to 64-bits, we can use a single bit in the flags > to indicate a control packet. For now, though, the ctrlmbuf functions and macros > just are aliases for the pktmbuf equivalents as much as possible. I'm wondering it "struct rte_kni_mbuf" should be updated accordingly each time "struct mbuf" is modified. Regards, Olivier