From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36450A04B5; Tue, 27 Oct 2020 04:36:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 903642BD5; Tue, 27 Oct 2020 04:36:55 +0100 (CET) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by dpdk.org (Postfix) with ESMTP id DC7DD2BD3 for ; Tue, 27 Oct 2020 04:36:50 +0100 (CET) Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CKy786YDMz15Lyw for ; Tue, 27 Oct 2020 11:36:52 +0800 (CST) Received: from [10.67.103.119] (10.67.103.119) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.487.0; Tue, 27 Oct 2020 11:36:44 +0800 To: References: <20201014100114.26596-1-huwei013@chinasoftinc.com> <20201014100114.26596-2-huwei013@chinasoftinc.com> From: oulijun Message-ID: <540f7150-fca1-22c6-6900-eab7673b3238@huawei.com> Date: Tue, 27 Oct 2020 11:36:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.119] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH 1/2] net/hns3: support SVE Rx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 在 2020/10/26 0:18, David Marchand 写道: > Hello Wei Hu, > >> diff --git a/drivers/net/hns3/meson.build b/drivers/net/hns3/meson.build >> index bf69ad4..ca0f21a 100644 >> --- a/drivers/net/hns3/meson.build >> +++ b/drivers/net/hns3/meson.build >> @@ -31,4 +31,9 @@ deps += ['hash'] >> >> if arch_subdir == 'arm' and dpdk_conf.get('RTE_ARCH_64') >> sources += files('hns3_rxtx_vec.c') >> + if (dpdk_conf.has('RTE_MACHINE_CPUFLAG_SVE')) >> + dpdk_conf.set('RTE_LIBRTE_HNS3_INC_VECTOR_SVE', 1) >> + cflags = ['-DCC_SVE_SUPPORT'] >> + sources += files('hns3_rxtx_vec_sve.c') >> + endif >> endif > > This patch is already merged in main, but RTE_MACHINE_CPUFLAG_* have > been removed, see https://git.dpdk.org/dpdk/commit/?id=84fb33fec1 > I guess SVE support is not working because of this. > > Please use compiler flags to check for support. > If you need an example on how to do this, you can probably look at > what has been done for Intel vector stuff. > > Besides, RTE_LIBRTE_HNS3_INC_VECTOR_SVE is not used anywhere and can be removed. > Hi， David Thank your reviews. Wei Hu has left and adjust the work. I will review and upstream his work as a new developer. I will get your comments first and handle it latter. Thanks Lijun Ou >