From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2665AA04BA; Wed, 7 Oct 2020 11:28:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E69D31B3C8; Wed, 7 Oct 2020 11:28:49 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 52DB92B8C for ; Wed, 7 Oct 2020 11:28:47 +0200 (CEST) IronPort-SDR: 95sP+6r9gNLwEPAfj75l/yryakvi0H85fdzDQN/1duaw8zkVyOdd6Kkkiwk87BehIPi10Z1ulu +zuEeKQC8Aew== X-IronPort-AV: E=McAfee;i="6000,8403,9766"; a="144794170" X-IronPort-AV: E=Sophos;i="5.77,346,1596524400"; d="scan'208";a="144794170" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2020 02:28:45 -0700 IronPort-SDR: XRQJuhtXEj9bakwk6jT+DV6y/Y1mmOzUzBJaiDFVGc+zYK69ZN0J1sy43riGVMrpwAogCSrECt iOgjGV0fMdpg== X-IronPort-AV: E=Sophos;i="5.77,346,1596524400"; d="scan'208";a="461246642" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.193.102]) ([10.213.193.102]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2020 02:28:43 -0700 To: "humin (Q)" , dev Cc: "konstantin.ananyev" , thomas , arybchenko , Linuxarm References: <1599534347-20430-1-git-send-email-humin29@huawei.com> <1601341419-15870-1-git-send-email-humin29@huawei.com> <1601341419-15870-4-git-send-email-humin29@huawei.com> <27557195-5b72-9db5-f1b2-924139243b37@intel.com> From: Ferruh Yigit Message-ID: <5414371e-4d5c-0b55-8a5b-72773d98b2f7@intel.com> Date: Wed, 7 Oct 2020 10:28:39 +0100 MIME-Version: 1.0 In-Reply-To: <27557195-5b72-9db5-f1b2-924139243b37@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH V15 3/3] app/testpmd: add FEC command X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/7/2020 1:15 AM, humin (Q) wrote: > HI，Ferruh, > >      how about only considering the first patch:ethdev:add fec API. If this > patch looks great to you, I wish it could be merged into 20.11. > >       To that patch, app/testpmd add fec command, I will fix it later. Hi Connor, Better to get them together if possible, -rc1 has been postponed to October 16, can this additional week help to get a new version? > >       thanks. > > -------------------------------------------------- > 胡敏 Hu Min > Mobile: +86-13528728164 > Email: humin29@huawei.com > > *发件人：*Ferruh Yigit > *收件人：*humin (Q) ;dev > *抄 送：*konstantin.ananyev ;thomas > ;arybchenko ;Linuxarm > > *时 间：*2020-10-01 00:53:37 > *主 题：*Re: [PATCH V15 3/3] app/testpmd: add FEC command > > On 9/29/2020 2:03 AM, Min Hu (Connor) wrote: >> This commit adds testpmd capability to query and config FEC >> function of device. This includes: >> - show FEC capabilities, example: >>        testpmd> show port 0 fec capabilities >> - show FEC mode, example: >>        testpmd> show port 0 fec_mode >> - config FEC mode, example: >>        testpmd> set port 0 >> > > I guess it is: > set port fec_mode > >>        where: >> >>        auto|off|rs|baser are four kinds of FEC mode which dev >>        support according to MAC link speed. >> >> Signed-off-by: Min Hu (Connor) >> Reviewed-by: Wei Hu (Xavier) >> Reviewed-by: Chengwen Feng >> Reviewed-by: Chengchang Tang >> --- >> v12->v13: >> change fec get capa interface. >> >> --- >> v10->v11: >> change mode to capa bitmask. >> >> --- >> v8->v9: >> added acked-by. >> >> --- >> v6->v7: >> used RTE_DIM(fec_mode_name) instead of RTE_ETH_FEC_NUM >> >> --- >> v5->v6: >> fixed code styles according to DPDK coding style. >> added _eth prefix. >> >> --- >> v4->v5: >> Add RTE_ prefix for public FEC mode enum. >> >> --- >> v3->v4: >> adjust the display format of FEC mode >> >> --- >> v2->v3: >> adjust the display format of FEC capability. >> >> --- >>   app/test-pmd/cmdline.c | 223 +++++++++++++++++++++++++++++++++++++++++++++++++ >>   app/test-pmd/config.c  |  91 ++++++++++++++++++++ >>   app/test-pmd/testpmd.h |   2 + >>   3 files changed, 316 insertions(+) > > Can you please update the testpmd documenatation for the new commands? > > Also can add the new command to the --help output? ('cmd_help_long_parsed()') > > <...> > >> +cmdline_parse_inst_t cmd_set_fec_mode = { >> +     .f = cmd_set_port_fec_mode_parsed, >> +     .data = NULL, >> +     .help_str = "set port fec_mode ", > > Can you please update the help string as: > "set port fec_mode auto|off|rs|baser" > > '<>' is to define the variable name, like in '' you expect numbers like > 0,1,2 .. but 'auto|off|rs|baser' are keywords, not variables.