From: Thomas Monjalon <thomas@monjalon.net>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, stable@dpdk.org,
Bruce Richardson <bruce.richardson@intel.com>,
juraj.linkes@pantheon.tech
Subject: Re: [dpdk-dev] [PATCH v2] buildtools: fix all drivers disabled on Windows
Date: Sat, 17 Apr 2021 12:48:27 +0200 [thread overview]
Message-ID: <5416283.Zr4YGCYZWr@thomas> (raw)
In-Reply-To: <20210416204852.15888-1-dmitry.kozliuk@gmail.com>
16/04/2021 22:48, Dmitry Kozlyuk:
> buildtools/list-dir-globs.py printed paths with OS directory separator,
> which is "/" on Unices and "\" on Windows, while Meson code always
> expected "/". This resulted in all drivers being disabled on Windows.
>
> Replace "\" with "/" in script output. Forward slash is a valid,
> although non-default, separator on Windows, so no paths can be broken
> by this substitution.
>
> Fixes: ab9407c3addd ("build: allow using wildcards to disable drivers")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> v2: Change fixes line, correct a typo (Juraj, Bruce).
>
> Not sure if it's worth backporting: it wasn't an issue in 20.11
> and the patch won't apply as-is.
The commit you mention was introduced in 21.02.
No matter which release it is, it is good to suggest backporting
for those who need to maintain an old release even if not upstream.
Applied, thanks
prev parent reply other threads:[~2021-04-17 10:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 21:36 [dpdk-dev] [PATCH] " Dmitry Kozlyuk
2021-04-16 6:44 ` Juraj Linkeš
2021-04-16 9:14 ` Bruce Richardson
2021-04-16 20:48 ` [dpdk-dev] [PATCH v2] " Dmitry Kozlyuk
2021-04-17 10:48 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5416283.Zr4YGCYZWr@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=juraj.linkes@pantheon.tech \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).