From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id D05F8A0C5B;
Fri, 27 Aug 2021 21:44:41 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 9918B4067C;
Fri, 27 Aug 2021 21:44:41 +0200 (CEST)
Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com
[64.147.123.24])
by mails.dpdk.org (Postfix) with ESMTP id 0B61E40150;
Fri, 27 Aug 2021 21:44:41 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
by mailout.west.internal (Postfix) with ESMTP id 5C1F63200917;
Fri, 27 Aug 2021 15:44:38 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute2.internal (MEProxy); Fri, 27 Aug 2021 15:44:38 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm2; bh=
k8wQ5X9rGUB3Sr+waGRXVTS0LMT0so4V9mcNZabmd4w=; b=NMAqC/lmc32PHVtv
ei5iuSwc4AnydLEHwG69WCHDtTKCXC2X5owovH7PaPPP0w2bQsXkvef3z8DAEJO2
IPmGwVWbwMCULRQf0CbBx4tuYGMsWSV7ESE6M72iFVVNqHaEBTlyxhZ5/WLIQTId
pCfBK/aAaWZ/R7X05b4zQkpegBrvCUmK0d5xIiOnSZlNysKBn9qNSh5pqn9izzdI
uP7wE5JgR4E+F9z6Mde16R00mkUSmBDh/hpkhYSRZHou0MLFQhsrcLsW02q6BsYY
lZfgZ2Gc7zQH9XSPUSI7jg+ZVKvIr+wK47OXOsMQipYyUvcxlzAauKykkILQtGFf
57bjyA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm3; bh=k8wQ5X9rGUB3Sr+waGRXVTS0LMT0so4V9mcNZabmd
4w=; b=o9LYFb7ANzSMCR37qMMyOzNLIDdFwm2TJD7eCti7n4F8lyInvo1iIaXCs
Iw9SXrV9sxJ0KLynhycFRFzYlBylqczfBTNFquQ/YE2MchN0oU5ptIoPW39ke0Ui
4KuccNpqXkf0t3JnuHJbySc3qsaNP7w1YAz5PZZL7O0z86X5wrzS/gok5i6wUv8O
vvF65o+pNuWGBs7eJ14fo5427wxTWeysG/G7uiKpj2L39DrNMsxGOiL5LiJb5Roi
ZolDDK3Qpw/fJeahbeJth9HuMCkvU4GVd7FSWITuAaJl2CvVqf+GkO9nsSZkVTYN
XFfNwo3bDfB4S2TTa5w4tdZgptJ7A==
X-ME-Sender: <xms:pUApYedKo95VM2DookjmgBZG_aIfaAohFburSQDfWcNTg5LwB3ILbg>
<xme:pUApYYOKvCdatySLyDnBP1AuOQ_bRp90ALrLptkDcmI9mkydNaiReTOp5CLdCSm1Z
xO9AZ6kqgggZJb23Q>
X-ME-Received: <xmr:pUApYfgD3ZFfAvpQBiaKQca9mtJbPdGDyRS3JIGGQvDNZbnFZjIxmgkPf0WkfqKjyMYNw0Bu73OGjcHfZbZIJbBQdw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddruddufedgudegtdcutefuodetggdotefrod
ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm
rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc
ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej
ueeiiedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh
hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght
X-ME-Proxy: <xmx:pUApYb_sLqok0cEbSZANFQT1cpu59ZcHgXcc0T-A5lNQG47NnRF3bQ>
<xmx:pUApYasrBr30Mp8XQI20TyW99begap4ZDMwrH3Ee8j2EQQ8VrWW_IA>
<xmx:pUApYSHWZhNysU9dxHbRpx1Mi7aTHuUXwjSlARGokOwFu212K754cg>
<xmx:pkApYcKxyXQBBrt3llVyX2lxBUCXoxOkVT18yKUv1WXbzjjeysRJdg>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri,
27 Aug 2021 15:44:36 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, nick.connolly@mayadata.io, stable@dpdk.org,
Narcisa Vasile <navasile@linux.microsoft.com>,
Bruce Richardson <bruce.richardson@intel.com>
Date: Fri, 27 Aug 2021 21:44:34 +0200
Message-ID: <5417783.tFEs8zH1ei@thomas>
In-Reply-To: <YRvJN/3O49QkTyNg@bricha3-MOBL.ger.corp.intel.com>
References: <20210810230322.230150-1-dmitry.kozliuk@gmail.com>
<YRvJN/3O49QkTyNg@bricha3-MOBL.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] build: fix install from arbitrary directory
for meson 0.55
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
17/08/2021 16:35, Bruce Richardson:
> On Wed, Aug 11, 2021 at 02:03:22AM +0300, Dmitry Kozlyuk wrote:
> > Install command for meson >= 0.55.0 referenced the script by a plain
> > string, assuming the build directory to be directly under the source
> > tree root. This resulted in an error when the assumption did not hold:
> >
> > c:\python\python.exe: can't open file
> > '../buildtools/symlink-drivers-solibs.py':
> > [Errno 2] No such file or directory
> >
> > Use files() to make a valid script path for any build directory.
> >
> > Fixes: cd27047dbee1 ("build: support drivers symlink on Windows")
> > Cc: nick.connolly@mayadata.io
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> > ---
> > Note: this is not limited to Windows, it just happens that Windows
> > requires newer meson and the error example is from Windows build.
It is used only for Windows.
Beginning of commit log is adjusted:
"Install command on Windows for Meson >= 0.55.0"
> > # 0.55.0 is required to use external program with add_install_script
> > - meson.add_install_script(py3, '../buildtools/symlink-drivers-solibs.py',
> > + meson.add_install_script(py3,
> > + files('../buildtools/symlink-drivers-solibs.py'),
>
> Rather than using a relative path, we could also use "files()" in the
> buildtools directory and store it in a variable to re-use either. Most
> other python scripts in the buildtools directory, use that pattern to have
> a single (array) variable with the python and script calls together.
>
> Either way as here, or with buildtools change:
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied as-is, thanks.